public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Iain Sandoe <idsandoe@googlemail.com>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
Cc: Jeff Law <law@redhat.com>,
	Richard Biener <richard.guenther@gmail.com>,
	"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
	David Edelsohn <dje.gcc@gmail.com>, nd <nd@arm.com>
Subject: Re: [PATCH] PR85678: Change default to -fno-common
Date: Mon, 28 Oct 2019 21:52:00 -0000	[thread overview]
Message-ID: <CF764EA8-3AE8-41BD-847F-03A883337999@googlemail.com> (raw)
In-Reply-To: <VI1PR0801MB212712A8E68791E2E1EE180D83660@VI1PR0801MB2127.eurprd08.prod.outlook.com>

Wilco Dijkstra <Wilco.Dijkstra@arm.com> wrote:
>>> 
>>> I suppose targets can override this decision. 
>> I think they probably could via the override_options mechanism.
> 
> Yes, it's trivial to add this to target_option_override():
> 
>  if (!global_options_set.x_flag_no_common)
>    flag_no_common = 0;

for the record,  Darwin bootstraps OK with the change (which is to be expected,
since the preferred setting for it is -fno-common).

Testsuite fails are order “a few hundred” mostly seem to be related to tree-prof
and vector tests (plus the anticipated scan-asm stuff, where code-gen will have
changed).  I don’t have cycles to analyse the causes right now - but that gives
an idea.

cheers
Iain



  reply	other threads:[~2019-10-28 21:39 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-28 19:04 David Edelsohn
2019-10-28 19:46 ` Richard Biener
2019-10-28 20:06   ` Jeff Law
2019-10-28 20:29     ` Wilco Dijkstra
2019-10-28 21:52       ` Iain Sandoe [this message]
2019-10-29  8:42         ` Richard Biener
2019-10-29 12:15         ` Wilco Dijkstra
2019-10-29 12:27           ` Iain Sandoe
  -- strict thread matches above, loose matches on Subject: below --
2019-10-25 16:00 Wilco Dijkstra
2019-10-25 19:11 ` Georg-Johann Lay
2019-10-26 12:45   ` Iain Sandoe
2019-10-26 13:27     ` Segher Boessenkool
2019-10-25 22:44 ` Segher Boessenkool
2019-10-26 18:21 ` Jeff Law
2019-10-28 16:15   ` Wilco Dijkstra
2019-10-28 18:44     ` Segher Boessenkool
2019-10-27  5:58 ` Harald van Dijk
2019-11-29 13:17 ` Martin Liška
2019-11-29 14:46   ` Wilco Dijkstra
2019-11-29 15:09     ` Martin Liška
2019-12-01  4:17   ` Jeff Law
2019-12-04 15:26     ` Wilco Dijkstra
2019-12-04 17:27       ` Jeff Law
2019-12-04 21:03         ` Joseph Myers
2019-12-04 21:14           ` Jeff Law
2019-12-05  9:16         ` Martin Liška
2019-12-05 10:01           ` Tobias Burnus
2019-12-05 13:18             ` Wilco Dijkstra
2019-12-05 16:49               ` Jeff Law
2019-12-05 15:40           ` Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CF764EA8-3AE8-41BD-847F-03A883337999@googlemail.com \
    --to=idsandoe@googlemail.com \
    --cc=Wilco.Dijkstra@arm.com \
    --cc=dje.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=law@redhat.com \
    --cc=nd@arm.com \
    --cc=richard.guenther@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).