* [PATCH] Don't set full_profile in auto-profile [PR113765]
@ 2024-03-28 3:02 Eugene Rozenfeld
2024-04-03 11:56 ` Richard Biener
0 siblings, 1 reply; 2+ messages in thread
From: Eugene Rozenfeld @ 2024-03-28 3:02 UTC (permalink / raw)
To: gcc-patches; +Cc: Jan Hubicka
auto-profile currently doesn't guarantee that it will set probabilities
on all edges because of zero basic block counts. Normally those edges
just have probabilities set by the preceding profile_estimate pass but
under -O0 profile_estimate pass doesn't run. The patch removes setting
of full_profile to true in auto-profile.
Tested on x86_64-pc-linux-gnu.
gcc/ChangeLog:
* auto-profile.cc (afdo_annotate_cfg): Don't set full_profile to true
---
gcc/auto-profile.cc | 1 -
1 file changed, 1 deletion(-)
diff --git a/gcc/auto-profile.cc b/gcc/auto-profile.cc
index e5407d32fbb..de59b94bcb3 100644
--- a/gcc/auto-profile.cc
+++ b/gcc/auto-profile.cc
@@ -1580,7 +1580,6 @@ afdo_annotate_cfg (const stmt_set &promoted_stmts)
}
update_max_bb_count ();
profile_status_for_fn (cfun) = PROFILE_READ;
- cfun->cfg->full_profile = true;
if (flag_value_profile_transformations)
{
gimple_value_profile_transformations ();
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] Don't set full_profile in auto-profile [PR113765]
2024-03-28 3:02 [PATCH] Don't set full_profile in auto-profile [PR113765] Eugene Rozenfeld
@ 2024-04-03 11:56 ` Richard Biener
0 siblings, 0 replies; 2+ messages in thread
From: Richard Biener @ 2024-04-03 11:56 UTC (permalink / raw)
To: Eugene Rozenfeld; +Cc: gcc-patches, Jan Hubicka
On Thu, Mar 28, 2024 at 4:03 AM Eugene Rozenfeld
<Eugene.Rozenfeld@microsoft.com> wrote:
>
> auto-profile currently doesn't guarantee that it will set probabilities
> on all edges because of zero basic block counts. Normally those edges
> just have probabilities set by the preceding profile_estimate pass but
> under -O0 profile_estimate pass doesn't run. The patch removes setting
> of full_profile to true in auto-profile.
OK.
Thanks,
Richard.
> Tested on x86_64-pc-linux-gnu.
>
> gcc/ChangeLog:
> * auto-profile.cc (afdo_annotate_cfg): Don't set full_profile to true
> ---
> gcc/auto-profile.cc | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/gcc/auto-profile.cc b/gcc/auto-profile.cc
> index e5407d32fbb..de59b94bcb3 100644
> --- a/gcc/auto-profile.cc
> +++ b/gcc/auto-profile.cc
> @@ -1580,7 +1580,6 @@ afdo_annotate_cfg (const stmt_set &promoted_stmts)
> }
> update_max_bb_count ();
> profile_status_for_fn (cfun) = PROFILE_READ;
> - cfun->cfg->full_profile = true;
> if (flag_value_profile_transformations)
> {
> gimple_value_profile_transformations ();
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-03 11:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-28 3:02 [PATCH] Don't set full_profile in auto-profile [PR113765] Eugene Rozenfeld
2024-04-03 11:56 ` Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).