From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122302 invoked by alias); 12 Apr 2016 08:25:56 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 122284 invoked by uid 89); 12 Apr 2016 08:25:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-exchange-antispam-report-cfa-test:102415293, Hx-exchange-antispam-report-cfa-test:102615271, H*c:HHH, wi X-HELO: na01-bn1-obe.outbound.protection.outlook.com Received: from mail-bn1bn0100.outbound.protection.outlook.com (HELO na01-bn1-obe.outbound.protection.outlook.com) (157.56.110.100) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA256 encrypted) ESMTPS; Tue, 12 Apr 2016 08:25:42 +0000 Received: from CO2PR07MB2694.namprd07.prod.outlook.com (10.166.214.7) by CO2PR07MB2694.namprd07.prod.outlook.com (10.166.214.7) with Microsoft SMTP Server (TLS) id 15.1.453.26; Tue, 12 Apr 2016 08:25:37 +0000 Received: from CO2PR07MB2694.namprd07.prod.outlook.com ([10.166.214.7]) by CO2PR07MB2694.namprd07.prod.outlook.com ([10.166.214.7]) with mapi id 15.01.0453.029; Tue, 12 Apr 2016 08:25:37 +0000 From: "Hurugalawadi, Naveen" To: "marc.glisse@inria.fr" CC: "ramana.radhakrishnan@foss.arm.com" , "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH] Fix PR31096 Date: Tue, 12 Apr 2016 08:25:00 -0000 Message-ID: References: , , , In-Reply-To: authentication-results: foss.arm.com; dkim=none (message not signed) header.d=none;foss.arm.com; dmarc=none action=none header.from=caviumnetworks.com; x-ms-office365-filtering-correlation-id: f5dd811b-c44b-410e-4d6e-08d362ac06b5 x-microsoft-exchange-diagnostics: 1;CO2PR07MB2694;5:BKKmv4GOpin45EvilTdFkeQPwxgtMjgxr1kLxkM6O9BpXeI/sPO4L1FO/NmEj+nPTspLJtiuDIWqaR0JbaqEH7P4rrnbjecCciOIkTTJciy8RDbqVOeCgSVgq76Mp8WXwAkbQg4FNrchy4De/YU89w==;24:jC7r6GDCRl74IdEXYb3VscERgesv/F3910+6J5LZ6kDcNh3PUXJpodQuIDAEPZ32u1gn8Hd0HQ3nCO+k0VR5fOiLn4FryazLtY6Z9DJIbvw= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CO2PR07MB2694; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(102415293)(102615271)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:CO2PR07MB2694;BCL:0;PCL:0;RULEID:;SRVR:CO2PR07MB2694; x-forefront-prvs: 0910AAF391 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(81166005)(11100500001)(74316001)(3280700002)(92566002)(3660700001)(54356999)(164054004)(5004730100002)(77096005)(2906002)(76176999)(9686002)(33656002)(87936001)(5640700001)(122556002)(1220700001)(1096002)(189998001)(4326007)(2501003)(5008740100001)(110136002)(586003)(66066001)(86362001)(106116001)(3846002)(10400500002)(2950100001)(6116002)(2900100001)(5890100001)(76576001)(93886004)(102836003)(99286002)(99936001)(5002640100001)(50986999)(5003600100002)(2351001);DIR:OUT;SFP:1101;SCL:1;SRVR:CO2PR07MB2694;H:CO2PR07MB2694.namprd07.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: multipart/mixed; boundary="_002_CO2PR07MB26941B6AA9C0417C2151C59B8E950CO2PR07MB2694namp_" MIME-Version: 1.0 X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2016 08:25:36.9720 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR07MB2694 X-SW-Source: 2016-04/txt/msg00495.txt.bz2 --_002_CO2PR07MB26941B6AA9C0417C2151C59B8E950CO2PR07MB2694namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 471 Hi, >> type is the return type of the comparison. The relevant type here is TREE_TYPE (@0).=20 Done. >>Maybe add a testcase with unsigned, to check that it does not transform? Added the testcase >> you could probably use tree_expr_nonzero_p Done. I had !wi::eq_p (@1, 0) for INTEGER_CST, but when tried to use it for general, then used the integer_zerop Please find attached the modified patch with all the modifications and let me know if its okay? Thanks, Naveen= --_002_CO2PR07MB26941B6AA9C0417C2151C59B8E950CO2PR07MB2694namp_ Content-Type: text/x-diff; name="pr31096-3.patch" Content-Description: pr31096-3.patch Content-Disposition: attachment; filename="pr31096-3.patch"; size=4027; creation-date="Tue, 12 Apr 2016 08:25:00 GMT"; modification-date="Tue, 12 Apr 2016 08:25:00 GMT" Content-Transfer-Encoding: base64 Content-length: 5462 ZGlmZiAtLWdpdCBhL2djYy9mb2xkLWNvbnN0LmMgYi9nY2MvZm9sZC1jb25z dC5jCmluZGV4IDBmNGJmN2UuLjU5MjJkYmQgMTAwNjQ0Ci0tLSBhL2djYy9m b2xkLWNvbnN0LmMKKysrIGIvZ2NjL2ZvbGQtY29uc3QuYwpAQCAtOTE3Nyw3 ICs5MTc3LDcgQEAgdHJlZV9leHByX25vbnplcm9fd2FybnZfcCAodHJlZSB0 LCBib29sICpzdHJpY3Rfb3ZlcmZsb3dfcCkKIC8qIFJldHVybiB0cnVlIHdo ZW4gVCBpcyBhbiBhZGRyZXNzIGFuZCBpcyBrbm93biB0byBiZSBub256ZXJv LgogICAgSGFuZGxlIHdhcm5pbmdzIGFib3V0IHVuZGVmaW5lZCBzaWduZWQg b3ZlcmZsb3cuICAqLwogCi1zdGF0aWMgYm9vbAorYm9vbAogdHJlZV9leHBy X25vbnplcm9fcCAodHJlZSB0KQogewogICBib29sIHJldCwgc3RyaWN0X292 ZXJmbG93X3A7CmRpZmYgLS1naXQgYS9nY2MvZm9sZC1jb25zdC5oIGIvZ2Nj L2ZvbGQtY29uc3QuaAppbmRleCAwMmY0MjcwLi44NTc5NjIyIDEwMDY0NAot LS0gYS9nY2MvZm9sZC1jb25zdC5oCisrKyBiL2djYy9mb2xkLWNvbnN0LmgK QEAgLTE2Nyw2ICsxNjcsNyBAQCBleHRlcm4gdHJlZSBzaXplX2RpZmZvcF9s b2MgKGxvY2F0aW9uX3QsIHRyZWUsIHRyZWUpOwogI2RlZmluZSBub25fbHZh bHVlKFQpIG5vbl9sdmFsdWVfbG9jIChVTktOT1dOX0xPQ0FUSU9OLCBUKQog ZXh0ZXJuIHRyZWUgbm9uX2x2YWx1ZV9sb2MgKGxvY2F0aW9uX3QsIHRyZWUp OwogCitleHRlcm4gYm9vbCB0cmVlX2V4cHJfbm9uemVyb19wICh0cmVlKTsK IGV4dGVybiBib29sIHRyZWVfZXhwcl9ub25uZWdhdGl2ZV9wICh0cmVlKTsK IGV4dGVybiBib29sIHRyZWVfZXhwcl9ub25uZWdhdGl2ZV93YXJudl9wICh0 cmVlLCBib29sICosIGludCA9IDApOwogZXh0ZXJuIHRyZWUgbWFrZV9yYW5n ZSAodHJlZSwgaW50ICosIHRyZWUgKiwgdHJlZSAqLCBib29sICopOwpkaWZm IC0tZ2l0IGEvZ2NjL21hdGNoLnBkIGIvZ2NjL21hdGNoLnBkCmluZGV4IDc1 YWE2MDEuLjQ3OWEzYTMgMTAwNjQ0Ci0tLSBhL2djYy9tYXRjaC5wZAorKysg Yi9nY2MvbWF0Y2gucGQKQEAgLTMxLDYgKzMxLDcgQEAgYWxvbmcgd2l0aCBH Q0M7IHNlZSB0aGUgZmlsZSBDT1BZSU5HMy4gIElmIG5vdCBzZWUKICAgIHpl cm9wCiAgICBDT05TVEFOVF9DTEFTU19QCiAgICB0cmVlX2V4cHJfbm9ubmVn YXRpdmVfcAorICAgdHJlZV9leHByX25vbnplcm9fcAogICAgaW50ZWdlcl92 YWx1ZWRfcmVhbF9wCiAgICBpbnRlZ2VyX3BvdzJwCiAgICBIT05PUl9OQU5T KQpAQCAtODk0LDcgKzg5NSwyNiBAQCBERUZJTkVfSU5UX0FORF9GTE9BVF9S T1VORF9GTiAoUklOVCkKICAgICAgICYmIHRyZWVfbm9wX2NvbnZlcnNpb25f cCAodHlwZSwgVFJFRV9UWVBFIChAMSkpKQogICAoY29udmVydCAoYml0X2Fu ZCAoYml0X25vdCBAMSkgQDApKSkpCiAKKy8qIEZvbGQgQSAqIDEwID09IEIg KiAxMCBpbnRvIEEgPT0gQi4gICovCisoZm9yIGNtcCAoZXEgbmUpCisgKHNp bXBsaWZ5CisgIChjbXAgKG11bHQ6YyBAMCBAMSkgKG11bHQ6YyBAMiBAMSkp CisgIChpZiAoSU5URUdSQUxfVFlQRV9QIChUUkVFX1RZUEUgKEAxKSkKKyAg ICAgICAmJiBUWVBFX09WRVJGTE9XX1VOREVGSU5FRCAoVFJFRV9UWVBFIChA MCkpCisgICAgICAgJiYgdHJlZV9leHByX25vbnplcm9fcCAoQDEpKQorICAg KGNtcCBAMCBAMikpKSkKIAorLyogRm9sZCBBICogMTAgPCBCICogMTAgaW50 byBBIDwgQi4gICovCisoZm9yIGNtcCAobHQgZ3QgbGUgZ2UpCisgKHNpbXBs aWZ5CisgIChjbXAgKG11bHQ6YyBAMCBAMSkgKG11bHQ6YyBAMiBAMSkpCisg IChpZiAoSU5URUdSQUxfVFlQRV9QIChUUkVFX1RZUEUgKEAxKSkKKyAgICAg ICAmJiBUWVBFX09WRVJGTE9XX1VOREVGSU5FRCAoVFJFRV9UWVBFIChAMCkp CisgICAgICAgJiYgdHJlZV9leHByX25vbnplcm9fcCAoQDEpKQorICAgKGlm ICh0cmVlX2V4cHJfbm9ubmVnYXRpdmVfcCAoQDEpKQorICAgIChjbXAgQDAg QDIpCisgICAoaWYgKCF0cmVlX2V4cHJfbm9ubmVnYXRpdmVfcCAoQDEpKQor ICAgIChjbXAgQDIgQDApKSkpKSkKIAogLyogKChYIGlubmVyX29wIEMwKSBv dXRlcl9vcCBDMSkKICAgIFdpdGggWCBiZWluZyBhIHRyZWUgd2hlcmUgdmFs dWVfcmFuZ2UgaGFzIHJlYXNvbmVkIGNlcnRhaW4gYml0cyB0byBhbHdheXMg YmUKZGlmZiAtLWdpdCBhL2djYy90ZXN0c3VpdGUvZ2NjLmRnL3ByMzEwOTYt MS5jIGIvZ2NjL3Rlc3RzdWl0ZS9nY2MuZGcvcHIzMTA5Ni0xLmMKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uNWY2MmRkYwotLS0gL2Rl di9udWxsCisrKyBiL2djYy90ZXN0c3VpdGUvZ2NjLmRnL3ByMzEwOTYtMS5j CkBAIC0wLDAgKzEsMjkgQEAKKy8qIFBSIG1pZGRsZS1lbmQvMzEwOTYgKi8K Ky8qIHsgZGctZG8gY29tcGlsZSB9ICovCisvKiB7IGRnLW9wdGlvbnMgIi1P MiAtZmR1bXAtdHJlZS1vcHRpbWl6ZWQiIH0gICovCisKK2ludAorZiAoaW50 IGEsIGludCBiKQoreworICByZXR1cm4gYSA+IGI7Cit9CisKK2ludAorZjEg KGludCBhLCBpbnQgYikKK3sKKyAgcmV0dXJuIGEgKiAxMCA+PSBiICogMTA7 Cit9CisKK2ludAorZjIgKGludCBhLCBpbnQgYikKK3sKKyAgcmV0dXJuIGEg KiAtNDIgPCAgYiAqIC00MjsKK30KKworaW50CitmMyAoaW50IGEsIGludCBi KQoreworICByZXR1cm4gYSAqIDAgPD0gYiAqIDA7Cit9CisKKy8qIHsgZGct ZmluYWwgeyBzY2FuLXRyZWUtZHVtcC1ub3QgIlxcKERcXCkgXFwqIiAib3B0 aW1pemVkIiB9IH0gKi8KZGlmZiAtLWdpdCBhL2djYy90ZXN0c3VpdGUvZ2Nj LmRnL3ByMzEwOTYtMi5jIGIvZ2NjL3Rlc3RzdWl0ZS9nY2MuZGcvcHIzMTA5 Ni0yLmMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uZWM1 MTgxNwotLS0gL2Rldi9udWxsCisrKyBiL2djYy90ZXN0c3VpdGUvZ2NjLmRn L3ByMzEwOTYtMi5jCkBAIC0wLDAgKzEsMjkgQEAKKy8qIFBSIG1pZGRsZS1l bmQvMzEwOTYgKi8KKy8qIHsgZGctZG8gY29tcGlsZSB9ICovCisvKiB7IGRn LW9wdGlvbnMgIi1PMiAtZmR1bXAtdHJlZS1vcHRpbWl6ZWQiIH0gICovCisK K2ludAorZiAodW5zaWduZWQgaW50IGEsIHVuc2lnbmVkIGludCBiKQorewor ICByZXR1cm4gYSA9PSBiOworfQorCitpbnQKK2YxICh1bnNpZ25lZCBpbnQg YSwgdW5zaWduZWQgaW50IGIpCit7CisgIHJldHVybiBhICogMTAgPT0gYiAq IDEwOworfQorCitpbnQKK2YyICh1bnNpZ25lZCBpbnQgYSwgdW5zaWduZWQg aW50IGIpCit7CisgIHJldHVybiBhICogLTQyIDwgIGIgKiAtNDI7Cit9CisK K2ludAorZjMgKHVuc2lnbmVkIGludCBhLCB1bnNpZ25lZCBpbnQgYikKK3sK KyAgcmV0dXJuIGEgKiAwIDw9IGIgKiAwOworfQorCisvKiB7IGRnLWZpbmFs IHsgc2Nhbi10cmVlLWR1bXAtdGltZXMgIlxcKERcXCkgXFwqIiA0ICJvcHRp bWl6ZWQiIH0gfSAqLwpkaWZmIC0tZ2l0IGEvZ2NjL3Rlc3RzdWl0ZS9nY2Mu ZGcvcHIzMTA5Ni5jIGIvZ2NjL3Rlc3RzdWl0ZS9nY2MuZGcvcHIzMTA5Ni5j Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjkwY2I3MWIK LS0tIC9kZXYvbnVsbAorKysgYi9nY2MvdGVzdHN1aXRlL2djYy5kZy9wcjMx MDk2LmMKQEAgLTAsMCArMSwyOSBAQAorLyogUFIgbWlkZGxlLWVuZC8zMTA5 NiAqLworLyogeyBkZy1kbyBjb21waWxlIH0gKi8KKy8qIHsgZGctb3B0aW9u cyAiLU8yIC1mZHVtcC10cmVlLW9wdGltaXplZCIgfSAgKi8KKworaW50Citm IChpbnQgYSwgaW50IGIpCit7CisgIHJldHVybiBhID09IGI7Cit9CisKK2lu dAorZjEgKGludCBhLCBpbnQgYikKK3sKKyAgcmV0dXJuIGEgKiAxMCA9PSBi ICogMTA7Cit9CisKK2ludAorZjIgKGludCBhLCBpbnQgYikKK3sKKyAgcmV0 dXJuIGEgKiAtNDIgIT0gIGIgKiAtNDI7Cit9CisKK2ludAorZjMgKGludCBh LCBpbnQgYikKK3sKKyAgcmV0dXJuIGEgKiAwICE9IGIgKiAwOworfQorCisv KiB7IGRnLWZpbmFsIHsgc2Nhbi10cmVlLWR1bXAtbm90ICJcXChEXFwpIFxc KiIgIm9wdGltaXplZCIgfSB9ICovCg== --_002_CO2PR07MB26941B6AA9C0417C2151C59B8E950CO2PR07MB2694namp_--