From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125972 invoked by alias); 14 Apr 2016 03:12:05 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 125957 invoked by uid 89); 14 Apr 2016 03:12:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Simply, Hx-languages-length:1300, H*c:HHH X-HELO: na01-by2-obe.outbound.protection.outlook.com Received: from mail-by2on0056.outbound.protection.outlook.com (HELO na01-by2-obe.outbound.protection.outlook.com) (207.46.100.56) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA256 encrypted) ESMTPS; Thu, 14 Apr 2016 03:11:54 +0000 Received: from CO2PR07MB2694.namprd07.prod.outlook.com (10.166.214.7) by BL2PR07MB2305.namprd07.prod.outlook.com (10.167.101.7) with Microsoft SMTP Server (TLS) id 15.1.453.26; Thu, 14 Apr 2016 03:11:51 +0000 Received: from CO2PR07MB2694.namprd07.prod.outlook.com ([10.166.214.7]) by CO2PR07MB2694.namprd07.prod.outlook.com ([10.166.214.7]) with mapi id 15.01.0453.030; Thu, 14 Apr 2016 03:11:51 +0000 From: "Hurugalawadi, Naveen" To: Richard Biener CC: Senthil Kumar Selvaraj , "gcc-patches@gcc.gnu.org" , "Pinski, Andrew" Subject: Re: PATCH] Fix PR 31531: A microoptimization of isnegative of signed integer Date: Thu, 14 Apr 2016 03:12:00 -0000 Message-ID: References: <87egcn7eae.fsf@atmel.com> , In-Reply-To: authentication-results: atmel.com; dkim=none (message not signed) header.d=none;atmel.com; dmarc=none action=none header.from=caviumnetworks.com; x-ms-office365-filtering-correlation-id: 5fe538f8-17a0-4d26-80a7-08d364128609 x-microsoft-exchange-diagnostics: 1;BL2PR07MB2305;5:fYqUp3sy3GNhHIhAUxkLNv+bhbtlwy6OoZ3lKLT6ulczFrI265iNa2mKxbIbNEpDced+hJ+NZShHlweW2AhyRSFv7wMj99SjFvfr0QzSnj4pfXS3B6GstaiTZT2MbyCeHpj26BW98Sd5QIuv2nFT1A==;24:mVyfhzygnHFwbiQ9YirCXN+KGvEdpcp1VvZ+BxCwtqsBsqd8G2Eg4c0K5UlB55DCL67Nr6BMs5SckQGOqFhu9WZQzFu0PZzUuqBgVuR4B5Q= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BL2PR07MB2305; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(102415293)(102615271)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:BL2PR07MB2305;BCL:0;PCL:0;RULEID:;SRVR:BL2PR07MB2305; x-forefront-prvs: 0912297777 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(51914003)(5008740100001)(5002640100001)(77096005)(93886004)(76176999)(50986999)(76576001)(99936001)(5004730100002)(3846002)(74316001)(106116001)(122556002)(107886002)(6116002)(189998001)(81166005)(110136002)(4326007)(102836003)(586003)(54356999)(33656002)(3280700002)(9686002)(66066001)(1220700001)(3660700001)(1096002)(92566002)(2950100001)(2906002)(2900100001)(5003600100002)(4001430100002)(10400500002)(87936001)(11100500001)(164054004)(86362001);DIR:OUT;SFP:1101;SCL:1;SRVR:BL2PR07MB2305;H:CO2PR07MB2694.namprd07.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: multipart/mixed; boundary="_002_CO2PR07MB26947B9181291A7985890EBC8E970CO2PR07MB2694namp_" MIME-Version: 1.0 X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2016 03:11:49.9705 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR07MB2305 X-SW-Source: 2016-04/txt/msg00639.txt.bz2 --_002_CO2PR07MB26947B9181291A7985890EBC8E970CO2PR07MB2694namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 380 Hi Richard, >> What's the motivation of splitting this into a equal type=20 >> and a non-equal type case? Simply only allow nop-conversions here >> (tree_nop_conversion_p) and unconditionally emit Done. Thanks for the review and Comments. Implemented the modifications as per you review comments. Please review the modified patch and let me know if its okay? Thanks, Naveen= --_002_CO2PR07MB26947B9181291A7985890EBC8E970CO2PR07MB2694namp_ Content-Type: text/x-diff; name="pr31531.patch" Content-Description: pr31531.patch Content-Disposition: attachment; filename="pr31531.patch"; size=896; creation-date="Thu, 14 Apr 2016 03:11:38 GMT"; modification-date="Thu, 14 Apr 2016 03:11:38 GMT" Content-Transfer-Encoding: base64 Content-length: 1216 ZGlmZiAtLWdpdCBhL2djYy9tYXRjaC5wZCBiL2djYy9tYXRjaC5wZAppbmRl eCA3NWFhNjAxLi45MjhhNTI5IDEwMDY0NAotLS0gYS9nY2MvbWF0Y2gucGQK KysrIGIvZ2NjL21hdGNoLnBkCkBAIC0xODk2LDEwICsxODk2LDEzIEBAIERF RklORV9JTlRfQU5EX0ZMT0FUX1JPVU5EX0ZOIChSSU5UKQogKGZvciBjbXAg KHNpbXBsZV9jb21wYXJpc29uKQogICAgICBzY21wIChzd2FwcGVkX3NpbXBs ZV9jb21wYXJpc29uKQogIChzaW1wbGlmeQotICAoY21wIChiaXRfbm90QDIg QDApIENPTlNUQU5UX0NMQVNTX1BAMSkKKyAgKGNtcCAoY29udmVydD9AMyAo Yml0X25vdEAyIEAwKSkgQ09OU1RBTlRfQ0xBU1NfUEAxKQogICAoaWYgKHNp bmdsZV91c2UgKEAyKQotICAgICAgICYmIChUUkVFX0NPREUgKEAxKSA9PSBJ TlRFR0VSX0NTVCB8fCBUUkVFX0NPREUgKEAxKSA9PSBWRUNUT1JfQ1NUKSkK LSAgIChzY21wIEAwIChiaXRfbm90IEAxKSkpKSkKKyAgICAgICAmJiAoVFJF RV9DT0RFIChAMSkgPT0gSU5URUdFUl9DU1QgfHwgVFJFRV9DT0RFIChAMSkg PT0gVkVDVE9SX0NTVCkKKyAgICAgICAmJiAoVFlQRV9QUkVDSVNJT04gKFRS RUVfVFlQRSAoQDMpKSA9PSBUWVBFX1BSRUNJU0lPTiAoVFJFRV9UWVBFIChA MikpKQorICAgICAgICYmIHRyZWVfbm9wX2NvbnZlcnNpb25fcCAodHlwZSwg VFJFRV9UWVBFIChAMCkpKQorICAgKHdpdGggeyB0cmVlIG5ld3R5cGUgPSBU UkVFX1RZUEUgKEAxKTsgfQorICAgIChzY21wICh2aWV3X2NvbnZlcnQ6bmV3 dHlwZSBAMCkgKGJpdF9ub3QgQDEpKSkpKSkKIAogKGZvciBjbXAgKHNpbXBs ZV9jb21wYXJpc29uKQogIC8qIEZvbGQgKGRvdWJsZSlmbG9hdDEgQ01QIChk b3VibGUpZmxvYXQyIGludG8gZmxvYXQxIENNUCBmbG9hdDIuICAqLwo= --_002_CO2PR07MB26947B9181291A7985890EBC8E970CO2PR07MB2694namp_--