From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105601 invoked by alias); 27 Mar 2017 04:57:10 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 105569 invoked by uid 89); 27 Mar 2017 04:57:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_WEB,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=345, Fuse, fuse, 7927 X-HELO: NAM02-SN1-obe.outbound.protection.outlook.com Received: from mail-sn1nam02on0081.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) (104.47.36.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 27 Mar 2017 04:57:07 +0000 Received: from CO2PR07MB2694.namprd07.prod.outlook.com (10.166.214.7) by CO2PR07MB2615.namprd07.prod.outlook.com (10.166.213.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.991.14; Mon, 27 Mar 2017 04:57:06 +0000 Received: from CO2PR07MB2694.namprd07.prod.outlook.com ([10.166.214.7]) by CO2PR07MB2694.namprd07.prod.outlook.com ([10.166.214.7]) with mapi id 15.01.0991.017; Mon, 27 Mar 2017 04:57:04 +0000 From: "Hurugalawadi, Naveen" To: Wilco Dijkstra , "Pinski, Andrew" CC: Kyrylo Tkachov , James Greenhalgh , nd , GCC Patches Subject: Re: [PATCH][AArch64] Implement ALU_BRANCH fusion Date: Mon, 27 Mar 2017 07:33:00 -0000 Message-ID: References: , In-Reply-To: authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=cavium.com; x-microsoft-exchange-diagnostics: 1;CO2PR07MB2615;7:GOUhrzWDtbViATTvzPBNZG7nAuwcV3upXYcEMsWxbjDEUCz4KWauhMB6Vf5pbqT6oA765POoN1aNM3n4E/ROE+NWKH+pWV3sxS63mea5Q0On0ULhakq2uCEaz3M70RrrfHKnwP6A6JbwaAftB7PF1Ysh5KHanQ2PaH6heawt6nNB578I7yNxdAy1z5V7YG3rdby3IyRrhwTHrtbQ62wLoPjiDs5owgYCQPQL+VZBv/bB+pxNEC8t8bKWQtGYWaaD7Y7scmseVrPPdmPQxjRVMnrlqoa12WbTlsXFPT34stT/ByVHTBQSaRx4M9YTdZXRfZ4aG6w+2GgjO78yS41tKA== x-forefront-antispam-report: SFV:SKI;SCL:-1SFV:NSPM;SFS:(10009020)(6009001)(39410400002)(39840400002)(51914003)(6116002)(66066001)(102836003)(3846002)(53936002)(2906002)(5660300001)(81166006)(122556002)(86362001)(3280700002)(8676002)(38730400002)(6246003)(3660700001)(54356999)(50986999)(76176999)(7696004)(25786009)(2900100001)(305945005)(99936001)(7736002)(74316002)(6436002)(33656002)(4326008)(6636002)(6506006)(189998001)(77096006)(229853002)(9686003)(6306002)(99286003)(54906002)(8936002)(2950100002)(55016002);DIR:OUT;SFP:1101;SCL:1;SRVR:CO2PR07MB2615;H:CO2PR07MB2694.namprd07.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; x-ms-office365-filtering-correlation-id: 531a46de-7851-4e1b-ac02-08d474cdb6be x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075);SRVR:CO2PR07MB2615; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(22074186197030)(183786458502308); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(102415395)(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123562025)(20161123560025)(20161123564025)(20161123555025)(20161123558025)(6072148);SRVR:CO2PR07MB2615;BCL:0;PCL:0;RULEID:;SRVR:CO2PR07MB2615; x-forefront-prvs: 02596AB7DA spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: multipart/mixed; boundary="_002_CO2PR07MB2694C7735276CCB2A0233A4583330CO2PR07MB2694namp_" MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Mar 2017 04:57:04.7538 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR07MB2615 X-SW-Source: 2017-03/txt/msg01370.txt.bz2 --_002_CO2PR07MB2694C7735276CCB2A0233A4583330CO2PR07MB2694namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 852 Hi, Thanks for the review and suggestions. > I think the patch isn't quite complete yet. You will also need changes in > generic code. Currently sched_macro_fuse_insns() does: Modified the sched_macro_fuse_insns() as required. > Basically the idea is to push the check for CC usage into target macros Done. Pushed the check into target macros. The modifications were generic and and quite different from ALU+BRANCH fusion; a separate patch is posted with the above 2 modifications at:- https://gcc.gnu.org/ml/gcc-patches/2017-03/msg01368.html > Also in aarch64.c's macro fusion you need check that the branch >> instruction uses the same register=20 Added to check that same registers are used in ALU and Branch instruction. Bootstrapped and Regression tested on AArch64. Please review the patch and let us know if its okay? Thanks, Naveen= --_002_CO2PR07MB2694C7735276CCB2A0233A4583330CO2PR07MB2694namp_ Content-Type: text/x-patch; name="alu-branch-4.patch" Content-Description: alu-branch-4.patch Content-Disposition: attachment; filename="alu-branch-4.patch"; size=2359; creation-date="Mon, 27 Mar 2017 04:51:14 GMT"; modification-date="Mon, 27 Mar 2017 04:51:14 GMT" Content-Transfer-Encoding: base64 Content-length: 3201 ZGlmZiAtLWdpdCBhL2djYy9jb25maWcvYWFyY2g2NC9hYXJjaDY0LWZ1c2lv bi1wYWlycy5kZWYgYi9nY2MvY29uZmlnL2FhcmNoNjQvYWFyY2g2NC1mdXNp b24tcGFpcnMuZGVmCmluZGV4IGYwZTZkYmMuLjMwMGNkMDAgMTAwNjQ0Ci0t LSBhL2djYy9jb25maWcvYWFyY2g2NC9hYXJjaDY0LWZ1c2lvbi1wYWlycy5k ZWYKKysrIGIvZ2NjL2NvbmZpZy9hYXJjaDY0L2FhcmNoNjQtZnVzaW9uLXBh aXJzLmRlZgpAQCAtMzQsNSArMzQsNiBAQCBBQVJDSDY0X0ZVU0lPTl9QQUlS ICgibW92ayttb3ZrIiwgTU9WS19NT1ZLKQogQUFSQ0g2NF9GVVNJT05fUEFJ UiAoImFkcnArbGRyIiwgQURSUF9MRFIpCiBBQVJDSDY0X0ZVU0lPTl9QQUlS ICgiY21wK2JyYW5jaCIsIENNUF9CUkFOQ0gpCiBBQVJDSDY0X0ZVU0lPTl9Q QUlSICgiYWVzK2Flc21jIiwgQUVTX0FFU01DKQorQUFSQ0g2NF9GVVNJT05f UEFJUiAoImFsdSticmFuY2giLCBBTFVfQlJBTkNIKQogCiAjdW5kZWYgQUFS Q0g2NF9GVVNJT05fUEFJUgpkaWZmIC0tZ2l0IGEvZ2NjL2NvbmZpZy9hYXJj aDY0L2FhcmNoNjQuYyBiL2djYy9jb25maWcvYWFyY2g2NC9hYXJjaDY0LmMK aW5kZXggNGY3NjlhNC4uMzFiYzVmNCAxMDA2NDQKLS0tIGEvZ2NjL2NvbmZp Zy9hYXJjaDY0L2FhcmNoNjQuYworKysgYi9nY2MvY29uZmlnL2FhcmNoNjQv YWFyY2g2NC5jCkBAIC03OTIsNyArNzkyLDggQEAgc3RhdGljIGNvbnN0IHN0 cnVjdCB0dW5lX3BhcmFtcyB0aHVuZGVyeDJ0OTlfdHVuaW5ncyA9CiAgICZn ZW5lcmljX2FwcHJveF9tb2RlcywKICAgNCwgLyogbWVtbW92X2Nvc3QuICAq LwogICA0LCAvKiBpc3N1ZV9yYXRlLiAgKi8KLSAgKEFBUkNINjRfRlVTRV9D TVBfQlJBTkNIIHwgQUFSQ0g2NF9GVVNFX0FFU19BRVNNQyksIC8qIGZ1c2li bGVfb3BzICAqLworICAoQUFSQ0g2NF9GVVNFX0NNUF9CUkFOQ0ggfCBBQVJD SDY0X0ZVU0VfQUVTX0FFU01DCisgICB8IEFBUkNINjRfRlVTRV9BTFVfQlJB TkNIKSwgLyogZnVzaWJsZV9vcHMgICovCiAgIDE2LAkvKiBmdW5jdGlvbl9h bGlnbi4gICovCiAgIDgsCS8qIGp1bXBfYWxpZ24uICAqLwogICAxNiwJLyog bG9vcF9hbGlnbi4gICovCkBAIC0xMzk4MSw2ICsxMzk4Miw1MCBAQCBhYXJj aF9tYWNyb19mdXNpb25fcGFpcl9wIChydHhfaW5zbiAqcHJldiwgcnR4X2lu c24gKmN1cnIpCiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0KIAorICBp ZiAoYWFyY2g2NF9mdXNpb25fZW5hYmxlZF9wIChBQVJDSDY0X0ZVU0VfQUxV X0JSQU5DSCkKKyAgICAgICYmIGFueV9jb25kanVtcF9wIChjdXJyKSkKKyAg ICB7CisgICAgICAvKiBXZSdyZSB0cnlpbmcgdG8gbWF0Y2g6CisJICBwcmV2 IChhbHVfaW5zbikgPT0gKHNldCAocjApIHBsdXMgKChyMCkgKHIxL2ltbSkp KQorCSAgY3VyciAoY2J6KSA9PSAgKHNldCAocGMpIChpZl90aGVuX2Vsc2Ug KGVxL25lKSAocjApCisJCQkJCQkJIChjb25zdF9pbnQgMCkpCisJCQkJCQkg KGxhYmVsX3JlZiAoIlNZTSIpKQorCQkJCQkJIChwYykpICAqLworCisgICAg ICBpZiAoU0VUX0RFU1QgKGN1cnJfc2V0KSAhPSAocGNfcnR4KQorCSAgfHwg R0VUX0NPREUgKFNFVF9TUkMgKGN1cnJfc2V0KSkgIT0gSUZfVEhFTl9FTFNF CisJICB8fCAhIFJFR19QIChYRVhQIChYRVhQIChTRVRfU1JDIChjdXJyX3Nl dCksIDApLCAwKSkKKwkgIHx8ICEgUkVHX1AgKFNFVF9ERVNUIChwcmV2X3Nl dCkpCisJICB8fCBSRUdOTyAoU0VUX0RFU1QgKHByZXZfc2V0KSkKKwkgICAg ICE9IFJFR05PIChYRVhQIChYRVhQIChTRVRfU1JDIChjdXJyX3NldCksIDAp LCAwKSkpCisJcmV0dXJuIGZhbHNlOworCisgICAgICAvKiBGdXNlIEFMVSBv cGVyYXRpb25zIGZvbGxvd2VkIGJ5IGNvbmRpdGlvbmFsIGJyYW5jaCBpbnN0 cnVjdGlvbi4gICovCisgICAgICBzd2l0Y2ggKGdldF9hdHRyX3R5cGUgKHBy ZXYpKQorCXsKKwljYXNlIFRZUEVfQUxVX0lNTToKKwljYXNlIFRZUEVfQUxV X1NSRUc6CisJY2FzZSBUWVBFX0FEQ19SRUc6CisJY2FzZSBUWVBFX0FEQ19J TU06CisJY2FzZSBUWVBFX0FEQ1NfUkVHOgorCWNhc2UgVFlQRV9BRENTX0lN TToKKwljYXNlIFRZUEVfTE9HSUNfUkVHOgorCWNhc2UgVFlQRV9MT0dJQ19J TU06CisJY2FzZSBUWVBFX0NTRUw6CisJY2FzZSBUWVBFX0FEUjoKKwljYXNl IFRZUEVfTU9WX0lNTToKKwljYXNlIFRZUEVfU0hJRlRfUkVHOgorCWNhc2Ug VFlQRV9TSElGVF9JTU06CisJY2FzZSBUWVBFX0JGTToKKwljYXNlIFRZUEVf UkJJVDoKKwljYXNlIFRZUEVfUkVWOgorCWNhc2UgVFlQRV9FWFRFTkQ6CisJ ICByZXR1cm4gdHJ1ZTsKKworCWRlZmF1bHQ6OworCX0KKyAgICB9CisKICAg cmV0dXJuIGZhbHNlOwogfQogCg== --_002_CO2PR07MB2694C7735276CCB2A0233A4583330CO2PR07MB2694namp_--