From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 98552 invoked by alias); 15 Mar 2017 05:33:05 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 98540 invoked by uid 89); 15 Mar 2017 05:33:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_WEB,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=345, uop, H*c:HHH X-HELO: NAM03-CO1-obe.outbound.protection.outlook.com Received: from mail-co1nam03on0065.outbound.protection.outlook.com (HELO NAM03-CO1-obe.outbound.protection.outlook.com) (104.47.40.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 15 Mar 2017 05:33:02 +0000 Received: from CO2PR07MB2694.namprd07.prod.outlook.com (10.166.214.7) by CO2PR07MB2614.namprd07.prod.outlook.com (10.166.213.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.947.12; Wed, 15 Mar 2017 05:33:01 +0000 Received: from CO2PR07MB2694.namprd07.prod.outlook.com ([10.166.214.7]) by CO2PR07MB2694.namprd07.prod.outlook.com ([10.166.214.7]) with mapi id 15.01.0947.022; Wed, 15 Mar 2017 05:32:58 +0000 From: "Hurugalawadi, Naveen" To: James Greenhalgh CC: "gcc-patches@gcc.gnu.org" , "Pinski, Andrew" , Marcus Shawcroft , Richard Earnshaw , "nd@arm.com" Subject: Re: [PATCH][AArch64] Implement ALU_BRANCH fusion Date: Wed, 15 Mar 2017 05:33:00 -0000 Message-ID: References: <20170308180359.GD25712@arm.com> ,<20170309102200.GA40049@arm.com> In-Reply-To: <20170309102200.GA40049@arm.com> authentication-results: gcc.gnu.org; dkim=none (message not signed) header.d=none;gcc.gnu.org; dmarc=none action=none header.from=cavium.com; x-microsoft-exchange-diagnostics: 1;CO2PR07MB2614;7:nQ3Uto6bpz51piZ4PUnMsVjXVMUzH2hk6AyTtrqvwfDge/kEIS2LaJ/8OkQXnimR3RT9rAbFBDNzjdmU+g1ZadgsCp8YjzQAwPwo5PUpyT8UVHDiOZA4A8iG+E/RnMQqPvm4/Mt7paHLwrw70LguqvFmYmvF66xYSycCJpSoHMVH/0MA+5bylFtmikI8nrFmLAIQp5inlzycAKkIXFYpwIc5gOTkSolx6Sgr1IXZPYvn5mDto6vRZZrsM5xbAxusW7rMXaS+jGDF8mxR2WOIq/na1/ngM52xp4pZOzg7cpk2w4NlCKvmD6djzlyOhFPCaE4wpm10rTsBDWiBepVStw== x-forefront-antispam-report: SFV:SKI;SCL:-1SFV:NSPM;SFS:(10009020)(6009001)(39450400003)(5660300001)(66066001)(25786008)(9686003)(102836003)(93886004)(3280700002)(110136004)(53936002)(2906002)(54906002)(38730400002)(6246003)(305945005)(7736002)(3846002)(189998001)(86362001)(8936002)(8676002)(77096006)(3660700001)(81166006)(74316002)(33656002)(229853002)(2900100001)(55016002)(122556002)(6116002)(7696004)(6506006)(99286003)(76176999)(4326008)(5890100001)(6916009)(54356999)(50986999)(99936001)(6436002)(2950100002);DIR:OUT;SFP:1101;SCL:1;SRVR:CO2PR07MB2614;H:CO2PR07MB2694.namprd07.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; x-ms-office365-filtering-correlation-id: fe3cf4d4-ca31-4090-90da-08d46b64bdb0 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:CO2PR07MB2614; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(102415395)(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041248)(20161123555025)(20161123564025)(20161123558025)(20161123562025)(20161123560025)(6072148);SRVR:CO2PR07MB2614;BCL:0;PCL:0;RULEID:;SRVR:CO2PR07MB2614; x-forefront-prvs: 02475B2A01 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: multipart/mixed; boundary="_002_CO2PR07MB2694F153A769D9F2E51D7CEB83270CO2PR07MB2694namp_" MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Mar 2017 05:32:58.6667 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR07MB2614 X-SW-Source: 2017-03/txt/msg00803.txt.bz2 --_002_CO2PR07MB2694F153A769D9F2E51D7CEB83270CO2PR07MB2694namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 524 Hi James, >> My reason for asking is that the instruction fusion implemented in LLVM >> ( lib/Target/AArch64/AArch64MacroFusion.cpp::shouldScheduleAdjacent ) Sorry. There seems to be some confusion in the branch instructions. The branch should be conditional for ALU_BRANCH fusion. Please find attached the modified patch that fuses ALU instructions and conditional branches. Bootstrapped and Regression tested on aarch64-thunder-linux. Please review the patch and let us know if its okay? Thanks, Naveen =20=20=20=20= --_002_CO2PR07MB2694F153A769D9F2E51D7CEB83270CO2PR07MB2694namp_ Content-Type: text/x-patch; name="alu-branch-1.patch" Content-Description: alu-branch-1.patch Content-Disposition: attachment; filename="alu-branch-1.patch"; size=1947; creation-date="Wed, 15 Mar 2017 05:31:54 GMT"; modification-date="Wed, 15 Mar 2017 05:31:54 GMT" Content-Transfer-Encoding: base64 Content-length: 2640 ZGlmZiAtLWdpdCBhL2djYy9jb25maWcvYWFyY2g2NC9hYXJjaDY0LWZ1c2lv bi1wYWlycy5kZWYgYi9nY2MvY29uZmlnL2FhcmNoNjQvYWFyY2g2NC1mdXNp b24tcGFpcnMuZGVmCmluZGV4IGYwZTZkYmMuLjMwMGNkMDAgMTAwNjQ0Ci0t LSBhL2djYy9jb25maWcvYWFyY2g2NC9hYXJjaDY0LWZ1c2lvbi1wYWlycy5k ZWYKKysrIGIvZ2NjL2NvbmZpZy9hYXJjaDY0L2FhcmNoNjQtZnVzaW9uLXBh aXJzLmRlZgpAQCAtMzQsNSArMzQsNiBAQCBBQVJDSDY0X0ZVU0lPTl9QQUlS ICgibW92ayttb3ZrIiwgTU9WS19NT1ZLKQogQUFSQ0g2NF9GVVNJT05fUEFJ UiAoImFkcnArbGRyIiwgQURSUF9MRFIpCiBBQVJDSDY0X0ZVU0lPTl9QQUlS ICgiY21wK2JyYW5jaCIsIENNUF9CUkFOQ0gpCiBBQVJDSDY0X0ZVU0lPTl9Q QUlSICgiYWVzK2Flc21jIiwgQUVTX0FFU01DKQorQUFSQ0g2NF9GVVNJT05f UEFJUiAoImFsdSticmFuY2giLCBBTFVfQlJBTkNIKQogCiAjdW5kZWYgQUFS Q0g2NF9GVVNJT05fUEFJUgpkaWZmIC0tZ2l0IGEvZ2NjL2NvbmZpZy9hYXJj aDY0L2FhcmNoNjQuYyBiL2djYy9jb25maWcvYWFyY2g2NC9hYXJjaDY0LmMK aW5kZXggYTA2OTQyNy4uZjc2YTJmZiAxMDA2NDQKLS0tIGEvZ2NjL2NvbmZp Zy9hYXJjaDY0L2FhcmNoNjQuYworKysgYi9nY2MvY29uZmlnL2FhcmNoNjQv YWFyY2g2NC5jCkBAIC03OTIsNyArNzkyLDggQEAgc3RhdGljIGNvbnN0IHN0 cnVjdCB0dW5lX3BhcmFtcyB0aHVuZGVyeDJ0OTlfdHVuaW5ncyA9CiAgICZn ZW5lcmljX2FwcHJveF9tb2RlcywKICAgNCwgLyogbWVtbW92X2Nvc3QuICAq LwogICA0LCAvKiBpc3N1ZV9yYXRlLiAgKi8KLSAgKEFBUkNINjRfRlVTRV9D TVBfQlJBTkNIIHwgQUFSQ0g2NF9GVVNFX0FFU19BRVNNQyksIC8qIGZ1c2li bGVfb3BzICAqLworICAoQUFSQ0g2NF9GVVNFX0NNUF9CUkFOQ0ggfCBBQVJD SDY0X0ZVU0VfQUVTX0FFU01DCisgICB8IEFBUkNINjRfRlVTRV9BTFVfQlJB TkNIKSwgLyogZnVzaWJsZV9vcHMgICovCiAgIDE2LAkvKiBmdW5jdGlvbl9h bGlnbi4gICovCiAgIDgsCS8qIGp1bXBfYWxpZ24uICAqLwogICAxNiwJLyog bG9vcF9hbGlnbi4gICovCkBAIC0xMzk4MSw2ICsxMzk4MiwzNyBAQCBhYXJj aF9tYWNyb19mdXNpb25fcGFpcl9wIChydHhfaW5zbiAqcHJldiwgcnR4X2lu c24gKmN1cnIpCiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0KIAorICBp ZiAoYWFyY2g2NF9mdXNpb25fZW5hYmxlZF9wIChBQVJDSDY0X0ZVU0VfQUxV X0JSQU5DSCkKKyAgICAgICYmIGFueV9jb25kanVtcF9wIChjdXJyKSkKKyAg ICB7CisgICAgICAvKiBUaGVzZSB0eXBlcyBjb3JyZXNwb25kIHRvIHRoZSBy ZXNlcnZhdGlvbiAidnVsY2FuX2FsdV9iYXNpYyIgZm9yCisJIEJyb2FkY29t IFZ1bGNhbjogdGhlc2UgYXJlIEFMVSBvcGVyYXRpb25zIHRoYXQgcHJvZHVj ZSBhIHNpbmdsZSB1b3AKKwkgZHVyaW5nIGluc3RydWN0aW9uIGRlY29kaW5n LiAgKi8KKyAgICAgIHN3aXRjaCAoZ2V0X2F0dHJfdHlwZSAocHJldikpCisJ eworCWNhc2UgVFlQRV9BTFVfSU1NOgorCWNhc2UgVFlQRV9BTFVfU1JFRzoK KwljYXNlIFRZUEVfQURDX1JFRzoKKwljYXNlIFRZUEVfQURDX0lNTToKKwlj YXNlIFRZUEVfQURDU19SRUc6CisJY2FzZSBUWVBFX0FEQ1NfSU1NOgorCWNh c2UgVFlQRV9MT0dJQ19SRUc6CisJY2FzZSBUWVBFX0xPR0lDX0lNTToKKwlj YXNlIFRZUEVfQ1NFTDoKKwljYXNlIFRZUEVfQURSOgorCWNhc2UgVFlQRV9N T1ZfSU1NOgorCWNhc2UgVFlQRV9TSElGVF9SRUc6CisJY2FzZSBUWVBFX1NI SUZUX0lNTToKKwljYXNlIFRZUEVfQkZNOgorCWNhc2UgVFlQRV9SQklUOgor CWNhc2UgVFlQRV9SRVY6CisJY2FzZSBUWVBFX0VYVEVORDoKKwkgIHJldHVy biB0cnVlOworCisJZGVmYXVsdDo7CisJfQorICAgIH0KKwogICByZXR1cm4g ZmFsc2U7CiB9CiAK --_002_CO2PR07MB2694F153A769D9F2E51D7CEB83270CO2PR07MB2694namp_--