From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by sourceware.org (Postfix) with ESMTPS id E1C663846456 for ; Thu, 30 Jun 2022 01:51:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E1C663846456 X-IronPort-AV: E=McAfee;i="6400,9594,10393"; a="270980972" X-IronPort-AV: E=Sophos;i="5.92,232,1650956400"; d="scan'208";a="270980972" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2022 18:51:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,232,1650956400"; d="scan'208";a="658805088" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga004.fm.intel.com with ESMTP; 29 Jun 2022 18:51:41 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 29 Jun 2022 18:51:41 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 29 Jun 2022 18:51:41 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.49) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 29 Jun 2022 18:51:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kwz2JCSdDraOPbkcjkSOkII6xlIfvDT3wnVqGreMtlcwx1uCPgFQum3jmYVI9zos2psGjJqljajZmIq4zWJoSnKBptVvoJc9zRwSje6eh99Xrc97BhKSp1vK9+U6udF6U/Hr6tuuPnCVQC6C/U5pl3/lyS5gfb3Dis9DKrhOA2vZvKqHLm7hbEMuG4hI2tUryxdf46MJhK+rY/0WAuOITn1og9BbXVUdDPRSHXRDwq2Bbm4dcPNfVFvxigSv2bGHrYT62EWema+Roac2Hi7R0yDZTPagHqh/OIYKTReTS/690TnDSHwlFtlgz0U0y4tVvuIxnyJxzbJo4RivU1o4xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/BMARoTCtFT3J+9Jax6VycS+DeyZAL6iB4m09yXK1RI=; b=dB9TyStWzD+6NTp6wYanhOwvaySJ+hUvuKQlwknnDEoNklOhmrmrprunVf0J+ph1gOYIIKMTe7N1VU8G+Wb62KAQb/rV2bJ4R3IX2X578JpHmQ88EBp4wkpvXJhCxnUGu4R02CQpkIajrV+0MwqFhVPWqWRw69XfSfrKNfR50B5cdb1J37vR9ZDfXonVh6qK3h43MPMmrQ89qdOoh+UwW5rctEZEFLhFolWpg2qLMQVq1wpGff+wJ0YJrKXXa0ijfcAgxkci4p5FNp6p7q+THRu0DsbAcWYtOV56UA3WgKPJAMQGMcL7WG6sdBE9DldYioWuw2605QAxFGk4epO9Bw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CY4PR1101MB2150.namprd11.prod.outlook.com (2603:10b6:910:18::11) by DM6PR11MB4153.namprd11.prod.outlook.com (2603:10b6:5:19f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.18; Thu, 30 Jun 2022 01:51:39 +0000 Received: from CY4PR1101MB2150.namprd11.prod.outlook.com ([fe80::7129:b2fb:bd33:e1f2]) by CY4PR1101MB2150.namprd11.prod.outlook.com ([fe80::7129:b2fb:bd33:e1f2%3]) with mapi id 15.20.5395.014; Thu, 30 Jun 2022 01:51:39 +0000 From: "Liu, Hongtao" To: "Jiang, Haochen" , "gcc-patches@gcc.gnu.org" Subject: RE: [PATCH] i386: Add AVX512BW to AVX512F in MASK_ISA2 Thread-Topic: [PATCH] i386: Add AVX512BW to AVX512F in MASK_ISA2 Thread-Index: AQHYjCPLcT6ccvBodUu2Yn6WCRMNl61nL4eA Date: Thu, 30 Jun 2022 01:51:39 +0000 Message-ID: References: <20220630015031.104897-1-haochen.jiang@intel.com> In-Reply-To: <20220630015031.104897-1-haochen.jiang@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: eb15c93e-f4dc-4f18-9534-08da5a3b1318 x-ms-traffictypediagnostic: DM6PR11MB4153:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YfFkwCNhkUIZQFzikXHIr6A9kinbT6hG8AN2HlvuiO7NgiC1aH7Pp7a1pvJXXpSXLLXiFsft4viqFxaflDjZhkqJaxX2u/dufTQPnDfVuV4/f2WUur+ALKdA0TaOKFPiqq7b5MVE04rB5QmLLkB87j4FO7fPbCwrIFOgqBBtyV5VXc2MIugdbMRc6hKKV9Rqo/o2+hImBJ9oSsTwK9uJ4pxGCdOGvCcDOvI2nZQJBBeJgT1aMjSrxsc/piTX7sDKCgv/I+vkQMsjJuAzUTwOpAqV4Taa9/wD9HdLjUDkgyQPiOAlCz0jWwotTkEapob+8Nz6QjUJIVQ+5owVjQV6fyJOF/EKvGBhjFdMDADpTyr+VLMVe8Pik8cxSfJ2UD3zsgrZWV8HMbInBhrMhM0u3t5SgJOaiIzYIAuM+0+lAJtYEtvW1g85DN7dfSWTyLOOEt2nKwKBY5bUwabNI+1k/WocqdZChGmBeQ8gPpRewzh7cgIJiGUsXabW9fffdWzkQCX/Z2nTa+ZJGSBW9m77pi7gE80sOI5c6Gh0fNwZe9PcFDYC6eYM/5n3CQCnQFtu9MixvNo/9izcOliQ3tsd3HmBjYmAG/5cNhFbUPIohogGGOqeDI9QwuSvIxsW7K29DaUqKxheHq6JLDAli1wJfBNVhawHw4Y/oJahOpO+Zn5b9cxGa8O3DbRj3jIj+QfS8Su4o/4GUEeBLueGmn8xHV0Iqvo4+qLpEL0aGbdLkW7SdCoSKwazSj+RYSjBs9+KxHQB1bRDyJzfY9fcXUkDFO+LrHBSIrKeSP5Se+Uq+60= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1101MB2150.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(396003)(366004)(376002)(39860400002)(136003)(346002)(122000001)(66556008)(38100700002)(66476007)(64756008)(8936002)(66446008)(41300700001)(71200400001)(26005)(66946007)(4326008)(8676002)(6506007)(76116006)(478600001)(9686003)(2906002)(53546011)(7696005)(5660300002)(86362001)(33656002)(110136005)(52536014)(55016003)(316002)(38070700005)(83380400001)(186003)(82960400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WH6mfirQ2yrnMq4vhnpONhiaUkR++36OAx4VM9jysH44PRTke+woFTL61ubo?= =?us-ascii?Q?ekac3sPU6leWVlE2xBbyO65pTl4seji+Ed42iWjT5guoJkFQdw0NKCNssVN5?= =?us-ascii?Q?DrhB6Zz9C34BErMb36jR/WFpiD9PMMGw2UlxV/LiteL75krhs1Om40BTVw3L?= =?us-ascii?Q?o1IK4b0nrBoyun5u9ttT9jOA/sGPcUb0lVBVVjsaOAz9yvBlhR3LmAMEM+y/?= =?us-ascii?Q?Fug0RSkuK6D7Q1uKoNqSPyk4w4WpkzRcpojjHx4AKdtcRbjOxYMXHBDJoTXG?= =?us-ascii?Q?Ifp3czE9scp8XbFfgsjhCF6bK+TH0ozPdUC4cI7cExxb8bfvlQ5AeLr3fBJy?= =?us-ascii?Q?YmpLAHq26EvMa71yhLzWd3RDuFtA7/ga26L3GrtW4KX4rTUGTnvrJ3gOyAIJ?= =?us-ascii?Q?ox3oAwJkgIS8ppHabuS9qT3Nzthf1w5dHeyGwpq8g3L7HJDzn0vDHFhyz8HP?= =?us-ascii?Q?FwZ7a91biwWHluY8/o/LsGf7v9aNRvZBfIgv0Bzp3sgzAvqF1f3WXO1+ZXoc?= =?us-ascii?Q?PEvNLXVu8IsMHzj5aiinibC/IHbrELHGapCz3p8pdfZr/VLCGmnrtDvR1JLk?= =?us-ascii?Q?lehKVz4+CDxZ3EEqGvkuXbdHp4zuSpJakmJtJ0tQQHYfV9H5GH+BJIEMhY5m?= =?us-ascii?Q?1qusAbc5VyFQd+JE3eCNVDB7yqp9RgevvCXiA2xGCY9bqeaYYyd9/ytur1of?= =?us-ascii?Q?COvwsdEYJnIPWEfamKbJv4fkrxilPSCuXGRNS2KFm7jGuVK6ei95F36z7eJO?= =?us-ascii?Q?le8Xg9mjypy00IzoSFZPQpRn/3JdgMw+iKA8Xo5q/VKuDymhr5dy/wAzmasP?= =?us-ascii?Q?Fyng2KLe1EdW4aAR7LhPNT7hBgVYNh/1MZ1Zczb0SlUJLe1J1QAmJqRopIcn?= =?us-ascii?Q?3UcPm8gwqvlG+pNuYO1ZjBB0Rp9BflhQYl5h2630oATH3kysixzSJlQz/dzW?= =?us-ascii?Q?rXNe0nlnD7ol5pFq0l3M1ocMBDVhcmCTwTyV7k3khGDaAz5PC9rynUFY/DAT?= =?us-ascii?Q?u/n3wUuKV1MYn74iY7xpoO4WkvAjyFT7Yj56EVxfviPEHWCcjWKxclkguC8L?= =?us-ascii?Q?Age5c5HCVfuNtVYreOu9ou0mjX91CclHs/ErHClV0bOIW+rym8ICFDYDnfdr?= =?us-ascii?Q?W1EQhu3aN4BRwLBB9tCI1pCILObHbGhS3qlNyIhBUEbZLfXMIUVGjIg+7L8S?= =?us-ascii?Q?0t7I0WFxzgPqoH+yJwEhYU4CfIaY2WVolyyRfBXnnUBXrRbRKyCWyeyS+Ire?= =?us-ascii?Q?LX9jWjaLLKjTsBLlAi2EBbbRraajVXLEGDrpYQ4gZ5qqR2R5pIZfz8+EYMa/?= =?us-ascii?Q?LDbfxvdtoV7TnMJ3Yd+znxsXoRc7h9GlwRS/A3LBnmhVm49dYgnI6dO6K9Xz?= =?us-ascii?Q?G3RD+uKVRvQQL6roYmf+fJbuGctXyRq79ehQIwS4+5ck7lglVeLuTFqHwiIA?= =?us-ascii?Q?kE9m3PY9XqmOIdCUPnTn/d5UkKO5hAGJI2/HvW6hQYhqbJF0+CvfEgOBqYDN?= =?us-ascii?Q?FHt+bRh7/oXWYXaFaPhG/1HBDxuan81zisaqdEHBxQ5VKKu3WAbMHyF5Id+z?= =?us-ascii?Q?X+wBlzJtfakaQPx1XDt7y46zcn8seEn3IKSYcFUT?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR1101MB2150.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb15c93e-f4dc-4f18-9534-08da5a3b1318 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jun 2022 01:51:39.5670 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: n5pANQdMB3g9ijZdF3kWT/seaf/mVoJRVkZRSw3l2KVbbivZyEv+8348MOYpxUNhYefNUKrUjbvJ1bshZ8/BDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4153 X-OriginatorOrg: intel.com X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SCC_BODY_URI_ONLY, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jun 2022 01:51:44 -0000 > -----Original Message----- > From: Jiang, Haochen > Sent: Thursday, June 30, 2022 9:51 AM > To: gcc-patches@gcc.gnu.org > Cc: ubizjak@gmail.com; Liu, Hongtao > Subject: [PATCH] i386: Add AVX512BW to AVX512F in MASK_ISA2 >=20 > Hi all, >=20 > I just found in MASK_ISA2_UNSET part, since AVX512BW is based on AVX512F, > we should add OPTION_MASK_ISA2_AVX512BW_UNSET to AVX512F for > maintainence convenience and logic correctness, or we will need to add al= l > future ISAs based on AVX512BW in both AVX512F and AVX512BW. This will be > easily forgot and might cause confusion. >=20 > Also remove the redundant ones in this change. >=20 > Regtested on x86_64-pc-linux-gnu. Ok for trunk? LGTM. >=20 > BRs, > Haochen >=20 > gcc/ChangeLog: >=20 > * common/config/i386/i386-common.cc > (OPTION_MASK_ISA2_AVX512F_UNSET): > Add OPTION_MASK_ISA2_AVX512BW_UNSET, remove > OPTION_MASK_ISA2_AVX512BF16_UNSET and > OPTION_MASK_ISA2_AVX512FP16_UNSET. > --- > gcc/common/config/i386/i386-common.cc | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) >=20 > diff --git a/gcc/common/config/i386/i386-common.cc > b/gcc/common/config/i386/i386-common.cc > index cb878163492..c0c2ad74d87 100644 > --- a/gcc/common/config/i386/i386-common.cc > +++ b/gcc/common/config/i386/i386-common.cc > @@ -315,11 +315,10 @@ along with GCC; see the file COPYING3. If not see > | OPTION_MASK_ISA_SSE_UNSET) >=20 > #define OPTION_MASK_ISA2_AVX512F_UNSET \ > - (OPTION_MASK_ISA2_AVX512BF16_UNSET \ > + (OPTION_MASK_ISA2_AVX512BW_UNSET \ > | OPTION_MASK_ISA2_AVX5124FMAPS_UNSET \ > | OPTION_MASK_ISA2_AVX5124VNNIW_UNSET \ > - | OPTION_MASK_ISA2_AVX512VP2INTERSECT_UNSET \ > - | OPTION_MASK_ISA2_AVX512FP16_UNSET) > + | OPTION_MASK_ISA2_AVX512VP2INTERSECT_UNSET) > #define OPTION_MASK_ISA2_GENERAL_REGS_ONLY_UNSET \ > OPTION_MASK_ISA2_SSE_UNSET > #define OPTION_MASK_ISA2_AVX_UNSET OPTION_MASK_ISA2_AVX2_UNSET > -- > 2.18.1