From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12olkn2026.outbound.protection.outlook.com [40.92.22.26]) by sourceware.org (Postfix) with ESMTPS id D84883858413 for ; Tue, 9 Aug 2022 07:47:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D84883858413 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eloQN18RsBc4/pSMff3Le4dqHIQC4eve3Vphcht5ewA+RA6JF2mfI2g+R3Ks3ab+hNbCrVUcPU4NlQkDTIhVi3YO0xH6ZNmW+5aRc7c1p82AazQEbcnMboTAM9QZK0/idcL92I6YBTu36LdeJtXmtWj607nHyxgiZIzLFZEmMfC/BtGlu9x/5+80C2KBZzX3WLJYVd024S/QW5GHhPLLbdfgw4SSZN8MmNDpMSczeZxD6XAPdRj/EikR2IGtIrCUfgxIjaxvFcUpEeVnx6yJZpSZj5aHAjkRMcROtkAJIWQ8lEyKRkKKL32bvGu1EW2Uhyc9sKCRxWqEdzY4PzQEuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pbhUOKzPuvYiLl7p7xrv780cWNjJv2PwsytB8ll3Gkw=; b=iOZ2WjcFYtvxkxhj0NS3d1FHul8wpwUeo98hOE7vr2Q6NcWDXAZuOql9EEJlgFyCyVN2sntS4Ro5N0tjOh4AW5WevTQRF6vdlFWsUfaTCFKQOTCKd8+SO9sZ5hBeb+XJoi41SAHmtc/LM6qO67U/rp4PRF/A8vRgs7UsgcMH709DLL05O0/E3VdMXWhNe75fydiuUGVAZsC4Dc+qJKlZkT2i6Qdo7DLbh5nBtcC42xdFtFGaBhl0dZuHMbCqTU0vi0E4rSC9gwczXcNx7x7HrSHIAIZeI9gI/L+ddU6FZa3vvHFEW/NyR9K83lPWc8BxG+iOJ1mNRV/pYEIQx6viag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from CY4PR1801MB1910.namprd18.prod.outlook.com (2603:10b6:910:79::14) by SA1PR18MB4808.namprd18.prod.outlook.com (2603:10b6:806:1df::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.20; Tue, 9 Aug 2022 07:47:04 +0000 Received: from CY4PR1801MB1910.namprd18.prod.outlook.com ([fe80::d1fe:5357:ddcf:a38f]) by CY4PR1801MB1910.namprd18.prod.outlook.com ([fe80::d1fe:5357:ddcf:a38f%6]) with mapi id 15.20.5504.020; Tue, 9 Aug 2022 07:47:04 +0000 From: Immad Mir To: gcc-patches@gcc.gnu.org Cc: dmalcolm@redhat.com, mirimnan017@gmail.com, Immad Mir Subject: [PATCH] analyzer: fix ICE casued by dup2 in sm-fd.cc[PR106551] Date: Tue, 9 Aug 2022 13:16:29 +0530 Message-ID: X-Mailer: git-send-email 2.25.1 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-TMN: [Y15ckKFyWCvxgeGfc0LWGQVc1KSu97wy5LQc7jMqo+YBstX+M5ZVeNeVVAxz0SlQ] X-ClientProxiedBy: PN0PR01CA0033.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:4e::23) To CY4PR1801MB1910.namprd18.prod.outlook.com (2603:10b6:910:79::14) X-Microsoft-Original-Message-ID: <20220809074629.6711-1-mirimmad@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 76796aea-6967-46e3-f470-08da79db5a0b X-MS-Exchange-SLBlob-MailProps: g0UYh8+NHeVgrCyfYE6irp5DYT6swxGAoIw9rrV2kGE6m6Ac/SdFTchgag45dIsgOwkTEFPZXuiWbJZGLR9eh56CCI8C8WsgYkt84o/XAcZFXoqIvuOoqptqZ6NFZz6JpSeGgaYuvgjENt4DsERHGK4xruI1nXWwetWxdiEkQmGlZRv4Uw+39EXK6HeVTpS+Ic1CQIppCLZuBNwC2470DGtTL8KGi0nGt6YH2oR+k27I7IwyC2zFY7DM+2rb0TadizMNXtv/zsIK+aWXR0ZWrWdCNizw5uZhej1cG41pK/jOK0hxTCXk83szlA6bgH/LIBxB7jBCzmb/ptW1Vfo5JmEKMofGtBz98/G9rARwvit0CJl5n6SAHHlhI+F37m74aeXnSKwOCAFQjVunlxuw77bqjXbpS3+MK06s+nZRFxiZHGL3JChNADkGkjrgsE5gjWZ5q/Il2s+rCq2suDhiPC8peQ+pOTfGS3YuGC7903nsOWkZHd225QQSdnp/FxvYnUh9UJCT0LqvcvAH6yOSHMfH2Mg9wn+ZwobpFe9q5ta8rAK4oKBrTBSJ6JdRFAUvMHa9dUH4l+RM15qgvhi0W2VDm7VwOyFTQoRNlLH8KZgx6EUSiAEmR0Dr8wsubQY/L+ABLYuTPkG3XMEi21cEtB4JWYY49cJZHaIa4cqLb4156lhGd2prRja6oK54+NPPAjKUwV+yI0kmHEWXF0SX/EPe+WziX0T71bzCh8c1J8JjBuZYNW9SSR22VYXmDvv/TsRuhcYK6io= X-MS-TrafficTypeDiagnostic: SA1PR18MB4808:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YTwc3USKgULmtFv1xRG9CWTTao7RImGmdiYz5B+V92BxasPwT2em8J3AxNUSOajpSyGMuuvR/viOo5hpZfmnnLFH4k/Rd8rQ1uBdh05acG/zXekJBVhnlQmJbioF7H/atR3CETs4OB6z7XJtj5d5GjWP97YWGwlkU6Qhd4kVV95EULt21oOffZzJQmJMspM+dXqPZF2ZaCQHqS0kMjxOnGLug7mD2MS17gQTPvkhWO+6uf1ilrLTTDe5M+MNz4hiGx5Mgl3Q+dUwQ7o8cEa6qi9F/E13+cIAVel8gPC9TjK/xzOyCVG0bfYfbieb5/gZ7tkrvVXCUzkV+GWHH/mO0Ad72rviTHIYU5liScXgoAJfhc+NYttqLa5hVvXOwsC63Q2V3LyPU2xq2m4B0vW4fu2zHjyldDzp0r5cYGKGo0E5CjwTtwpi7QOnx1c5eX9ZETkPqisSWIpjCjdToC/XEoF901TvUkay33bHKW6QqWPXOVLr9dtOkw+K3oeiT4hsROiNiCFWtWpaKrVhXGmfgppuaW9aE8F/F6fbs20VycrHg7KDRibXjLCxMJdsbottMqk6XTdtRv8DczHAbP7sPG3h6wZjn6t2YZdzxv51PI+KT5bbetyz3k+3Bz1ZayaS8CLqo0PKZKQ+I66gNXAu1A== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2iKzEqNzC/aAGCVI7SnRvU9D8XCwKX0HjIO4SE3BP4HFFB6vi+VYfQ1CmiWx?= =?us-ascii?Q?7ufwAVnNhJtIEq/zL8tWiyTbXAyDFTz2SiPsabQBjcT3E/x2wfybG0VKMwUA?= =?us-ascii?Q?2woKftH7y51PSWNgm7RJ60gcTHdZOb65esh1DlRUv2O6ltQGWez4XMU2A7wA?= =?us-ascii?Q?ltqFxSSkBpr64xHf0PA/JwfVznxPxhVFWFPIVoaNbWi8cEfB2RbiYVN7P9dT?= =?us-ascii?Q?gO+x5fdA9PPWxxPeIXuvS1zn+2U79M+DXV7zP6upi33GqANXj3yCqee76Atp?= =?us-ascii?Q?427UWjBgwPbNdbN1T5wbRxHKv7bahs/qKD210bC+6/imocSPKhrvJ1XbZAa6?= =?us-ascii?Q?vpWdw8RW/9JD5LrO/K8EbP2iKbesqpXY7jBlVjtYx1y+aETo9GVGva7T6Mkq?= =?us-ascii?Q?p5ijEM2Zx6LYZzHi0mv6aPDA7U33AVlGTye8Ix5i5XiP5b/SxfgfCinUHvOK?= =?us-ascii?Q?7KQ7C3du/Z6C6hvFeTmkRSezmOuJL524oEEGiXbP9sCCqzNAjWPClrQO1zOG?= =?us-ascii?Q?+DDI5CXzLwxINmP5a6knTiwlEaJyJYCHWlEI68AduR9xgVhwjTCtuQkQcb3C?= =?us-ascii?Q?i0DTkT2MP8dP55bYRd/zDWx6Q81vr0UOdyY4IvD0+FKZsQ5sHB7k+SP7xDKk?= =?us-ascii?Q?3ciHtv9dNpTGTxMMCrR7SG9/ZRSCLugf851hAG+XCTI1utIZwnnmln5n0+lU?= =?us-ascii?Q?4EwEqFeD2P8aj+9BulqWIVu/+A2lDHqo6qgcCMPAuhb48nm2M519Cg5VGkAz?= =?us-ascii?Q?PXRLsflCz43tJVOUCtOF7/9TmdheXbZvkRelgjlbWhe3TW9DyrIy4H9XywGL?= =?us-ascii?Q?v/LiU64ZP6ctlNH6hCQ7+RK2QMJmHDtqBbWpvQUQKWVaOzq4xm3wb+qSk1fE?= =?us-ascii?Q?Od9FR74aluazI3+KXq/vNrcstY1wlDwzGWFfTYZwVl6gvvExiLpbvU2qWI6E?= =?us-ascii?Q?TdgdK66WOryidZJlO3efnSP4cVRtSdPaAs0LQZyxoPt8elTRXB5jt91h0r9R?= =?us-ascii?Q?wq1SRJMnXCARlb2clxARqFQIZ/inRsqeFoSEFGKIsURkK1m63FUCb9mGtdOz?= =?us-ascii?Q?T/2elN6fQYlMpAq8jAS1rQfggWBdI9zUzMsunTT81No43FBj1Hkhl0Vam5J8?= =?us-ascii?Q?FZ0udafB92fcLdCvK/A2/5vvG6JKz8XXpSnyAvCsYeodxe1mfkLc0hhfJH+J?= =?us-ascii?Q?2mhLnSlmTO2irro7HBZOP2QzBntj1dz3K5cHbUbvXhbFgT7KgzcUPe61dX5+?= =?us-ascii?Q?IN61Km7jWH+AnieKjJeCz6hEeLkEWg1NzTz0uwsOEgKVXX4awkMiMDZJHJtF?= =?us-ascii?Q?OC1m98VO1Wb2mL3H7K6u9y/AXKmJ9KCQ3MHkVm8VR8lUaw=3D=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 76796aea-6967-46e3-f470-08da79db5a0b X-MS-Exchange-CrossTenant-AuthSource: CY4PR1801MB1910.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2022 07:47:04.6721 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR18MB4808 X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Aug 2022 07:47:07 -0000 This patch fixes the ICE caused by valid_to_unchecked_state, at analyzer/sm-fd.cc by handling the m_start state in check_for_dup. Tested lightly on x86_64. gcc/analyzer/ChangeLog: PR analyzer/106551 * sm-fd.cc (check_for_dup): handle the m_start state when transitioning the state of LHS of dup, dup2 and dup3 call. Signed-off-by: Immad Mir --- gcc/analyzer/sm-fd.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/analyzer/sm-fd.cc b/gcc/analyzer/sm-fd.cc index 8bb76d72b05..c8b9930a7b6 100644 --- a/gcc/analyzer/sm-fd.cc +++ b/gcc/analyzer/sm-fd.cc @@ -983,7 +983,7 @@ fd_state_machine::check_for_dup (sm_context *sm_ctxt, const supernode *node, case DUP_1: if (lhs) { - if (is_constant_fd_p (state_arg_1)) + if (is_constant_fd_p (state_arg_1) || state_arg_1 == m_start) sm_ctxt->set_next_state (stmt, lhs, m_unchecked_read_write); else sm_ctxt->set_next_state (stmt, lhs, @@ -1011,7 +1011,7 @@ fd_state_machine::check_for_dup (sm_context *sm_ctxt, const supernode *node, file descriptor i.e the first argument. */ if (lhs) { - if (is_constant_fd_p (state_arg_1)) + if (is_constant_fd_p (state_arg_1) || state_arg_1 == m_start) sm_ctxt->set_next_state (stmt, lhs, m_unchecked_read_write); else sm_ctxt->set_next_state (stmt, lhs, -- 2.25.1