From: Dragan Mladjenovic <dmladjenovic@wavecomp.com>
To: Jeff Law <law@redhat.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: Matthew Fortune <mfortune@gmail.com>
Subject: Re: [MIPS] Fix for the wrong argument sequence in MSA builtin for FMADD/MADDV family.
Date: Mon, 17 Jun 2019 07:44:00 -0000 [thread overview]
Message-ID: <CY4PR22MB011911DE4038D1AF1BE28CA4B3EB0@CY4PR22MB0119.namprd22.prod.outlook.com> (raw)
In-Reply-To: <4e93646a-da10-5d49-8511-7e3ae3048f60@redhat.com>
Sorry for the late response.
I've checked the patch on gcc-9 and gcc-8 branches with mips{el}-linux-gnu.
There are no new regressions, as expected.
Is this change still eligible for back-port ?
________________________________
From: Jeff Law <law@redhat.com>
Sent: Friday, May 31, 2019 11:41:35 PM
To: Dragan Mladjenovic; gcc-patches@gcc.gnu.org
Cc: Matthew Fortune
Subject: Re: [MIPS] Fix for the wrong argument sequence in MSA builtin for FMADD/MADDV family.
On 5/22/19 12:13 AM, Dragan Mladjenovic wrote:
> Hi all,
>
> This patch makes the behavior of __builtin_msa_ fmadd/fmsub/maddv match the
> expected one. While not a recent regression, it would be nice if this can
> be back-ported in order to minimize the fragmentation.
>
> Best regards,
>
> Dragan
>
> gcc/ChangeLog:
>
> 2019-05-20 Prachi Godbole <prachi.godbole@imgtec.com>
> Robert Suchanek <robert.suchanek@mips.com>
>
> * gcc/config/mips/mips.c (mips_expand_builtin_insn): Swap the 1st
> and 3rd operands of the fmadd/fmsub/maddv builtin.
>
> gcc/testsuite/ChangeLog:
>
> 2019-05-20 Dragan Mladjenovic <dmladjenovic@wavecomp.com>
>
> * gcc.target/mips/msa-fmadd.c: New.
THanks. I've installed this one the trunk.
Out of an abundance of caution I have not installed it on any of the
release branches. Feel free to ping me in a week or so and if there
haven't been any issues I'll back port it.
jeff
next prev parent reply other threads:[~2019-06-17 7:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 6:13 Dragan Mladjenovic
2019-05-31 22:06 ` Jeff Law
2019-06-17 7:44 ` Dragan Mladjenovic [this message]
2019-06-17 17:30 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR22MB011911DE4038D1AF1BE28CA4B3EB0@CY4PR22MB0119.namprd22.prod.outlook.com \
--to=dmladjenovic@wavecomp.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
--cc=mfortune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).