From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2113.outbound.protection.outlook.com [40.107.101.113]) by sourceware.org (Postfix) with ESMTPS id B449C3858D1E for ; Wed, 20 Mar 2024 09:43:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B449C3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=os.amperecomputing.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=os.amperecomputing.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B449C3858D1E Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.101.113 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1710927838; cv=pass; b=j4TTgmQYma0ko6/enYc7SbneaoNN9AcHGp2CELwW2lrv+/OtRqOx9tNpGk6ne3lp6BQDm9gAVPmuQD2YmyTOmA0H0gJUbesi6Xy4hKCEJm7om9QogiowEmOOUgS/cMGBkT41Z91Z3w7UL9kaTLOH/oWMImKfbGbX0KsGmN/JXWI= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1710927838; c=relaxed/simple; bh=exTBKhsYN21kJU9Xa7SURdKDeocXlfWphCsgdHfddU0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=aw0+AsfqP65ksqSQaEJUBhmZseKp59T+yl6fg1hM/5WRLTzIj/y0SMO3U4tLRs1cwxwmutlDv1Hs0M0SS2OTgE2/3Oa+XOJosTjKMcfdqWgc+LQzOJvGuENcWRx/QWjhtu5ccOcll4ld1uawqi8QIOYkIqU1ngGLPc0PDStl+E0= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ALrTAEV6JKy21KGsDUkpng8Nc7kXXb1NAP9uXegb1UnBFgAUwDT6jz0mkP89CkYhm2biRdtHWQM3Rwf2IUZ1vHq7R/HZosnTdxkBBCOZS9rCb443Pgu05N7pyEZ60mTWd5SR0ZaOqe5qB2olzEZ/gucNGU3OTzJZVmXgNERhuHFExoj+/0mZvg/sm70fCVkMShM7L3mufBbijV71zVxQ1933/yP4ajW2tnh1UvBRiE3H/FJemTDvakXdonCVe4cauMMt7HkDJTF6JaGHkYl4ZKoDhvLq0udR6C0jM0TH6SBvclK3ngJ240FnTJ5YBvOvoyHpwXic1wOkJZEk1bze6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bWIKaS0omo4DLWsEs8RpLqu7wca70foF29J/h6uJ6x0=; b=G1zF2zfQ+kZj7Wn7fVlKRM5rNAdwMA2qDmBOYwBhG5EPwHDZp0TrD2uxbJjVsdbmn0xjMTE/VFP9Lto1pnGCoFjxeK6SkKMVqVjeZKLg1yVx9tlEltgUgUj7N4ElHjqSG75ixMFmeBfxGzFoyS6L8z0bg6K3MJiAA7CMd03GP4NkxvjZJZu5MQtJMWXqKXUzIskhLLQLtDpJN45r5XswfpgJjP5UQ7G2wFCzqfaCFVkRIr8cwfOyTQ/GLMIEdYzFS0OTY1GXgrApeMV+WAIRRvxqb5dmCARHL3v8ZhxiYEYqYIuIFBOHcLkymbo9x15oWTOqpf4N0ILT+TagtRdfDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bWIKaS0omo4DLWsEs8RpLqu7wca70foF29J/h6uJ6x0=; b=LBf/P9NcQT44BijvoZBLceWN9yy9N8Lk/8R7YOxE5We10gae8u3lTGzCHWOUTu41nxGchK5fEELr5fTVPhMZg9ulQcOTH2VDBlv0kpuUPD2zW5f8cS6QH/ZlYxP7dS2HQgZHpg/fPd+VFAL5I14mI9+I6zQlWqjDK5JF997MiXA= Received: from CYYPR01MB8309.prod.exchangelabs.com (2603:10b6:930:c5::16) by PH0PR01MB8138.prod.exchangelabs.com (2603:10b6:510:2a0::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.28; Wed, 20 Mar 2024 09:43:50 +0000 Received: from CYYPR01MB8309.prod.exchangelabs.com ([fe80::7fb5:5f27:a47e:d539]) by CYYPR01MB8309.prod.exchangelabs.com ([fe80::7fb5:5f27:a47e:d539%7]) with mapi id 15.20.7386.031; Wed, 20 Mar 2024 09:43:50 +0000 From: Hao Liu OS To: Richard Biener CC: "GCC-patches@gcc.gnu.org" Subject: Re: [PATCH] testsuite: add the case to cover vectorization of A[(i+x)*stride] [PR114322] Thread-Topic: [PATCH] testsuite: add the case to cover vectorization of A[(i+x)*stride] [PR114322] Thread-Index: AQHaepoxdVAr/GxkXkuMkNGk/9ZdKLFAShOAgAAWZRc= Date: Wed, 20 Mar 2024 09:43:50 +0000 Message-ID: References: <7n6o2538-p829-p52r-so19-s196924o6r59@fhfr.qr> In-Reply-To: <7n6o2538-p829-p52r-so19-s196924o6r59@fhfr.qr> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_Enabled=True;MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_SiteId=3bc2b170-fd94-476d-b0ce-4229bdc904a7;MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_SetDate=2024-03-20T09:43:49.866Z;MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_Name=Confidential;MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_ContentBits=0;MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_Method=Standard; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=os.amperecomputing.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CYYPR01MB8309:EE_|PH0PR01MB8138:EE_ x-ms-office365-filtering-correlation-id: 1d13c7a7-d5f2-4706-1eca-08dc48c23f90 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yblm9hlyjrVzBrAZHasjNtCTX/whBn8Yjr5wWKXBkVc3YStqUw3Wdl5buW9GU7VMUrUsHd0EfhxKw3klZKXoPmt++DI2JUPOLVVoOn67c8BhksaTImFREyE5GnQ7cHnrYaKyQvSEUky1vMjl4Nd3IwiBiROApUNK5+lsMn0dIl5e5GAGTVKG6nBZYueKMV1gZOFf6/gRw3/Km91u20lXa7bThZslfU9mlk/KWXqT5oqwzvJf13z7eg7DMi65MD/y3VBh1hAyMymOFXk00LICXbv8x4yAuZyFMBIOh7RCFz2kaTd4c+7H4/wd7mUuxnURiGcrmNU8wbXzhhA9rZqeXjsSJtfAQc79bxrs6D6tBifORRQc7KYkm5UyN5Uqzyyfy59uPIJtSUksVbr5xdNs4S4K2zbpbLwwkY5W3GGKt6bkf5GkatlLesnlhH9EQSHmmYYb9/Ruot5A5YPR5gTvcP5HTQJIHS7t9brG+pFEe56cGanaeKgyNOJqW1PCkZwrCRgm5YyFnmIgh2vJull3kODmc1/s/yOWyHEmXB1ZsySz4TmVSjxDwNxBO2OQRvmu90c+v6zthIba2Ov5cMhJ4KLIt/5hJuAp8txw7Ebp2TVO7dELNiRatJeZ/KjThxo1FI0V/TDFZFpMjQxwS7WiKNxuKGw8URTnY5l/MwUJgVE= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CYYPR01MB8309.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(1800799015)(376005)(38070700009);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KGZSXK3NARYZrKEc5nag4DBlwsgQzaLdk/0y+3O85u3sbxxh33BVGYvoe6A1?= =?us-ascii?Q?/xe6Orlertl3AcFKTBoAixRwKnSgQOce+KJIKatdfgzdr2shpyV0i4idoMSS?= =?us-ascii?Q?LuZ+powJ39ZEnZ7bgj9gR4ucEfELGz30FA9GlyGqe7+Rwpo8nn+gNmVt/dzW?= =?us-ascii?Q?0tcl6HYO/kj1JxonsLDaizEdzFVHKpucPQdP4hCe8KOLLYrsO1a8z5isFOLl?= =?us-ascii?Q?GoeEyKP87Mv6UaBic9UlLUieLXUp4szf3C/TvfeGXIk4AWpy+6mcREESMUWl?= =?us-ascii?Q?CaSp5l2M2uAynATcBMstzpZ8OOXSrQ6gDseEnchvwJnIfbzAyIYaM/iSB2Jy?= =?us-ascii?Q?49ap38InFgL89IPPYBj8bP1jHyirMLCiaTJGLixKuzukpGxpHLqKcI38zZzo?= =?us-ascii?Q?ZwHyBQa3AWjdP9QlJScQ5beBqpLVIeOq2uOi/7Phs60fnScuoLvgfxYIbLUb?= =?us-ascii?Q?tVSnQhrVhUZmll3nNflzblj7U5rlYoxVFfk/8uas2s0c/G9PwmO4fCfxd4So?= =?us-ascii?Q?OmL6cLTYIDRttACiKHexksUlINsGwqbbgDeGQbVtb5Z09dm10ANgymvq2IlN?= =?us-ascii?Q?/k+wvgPaF7ybXaM8q4tP0vB3i0JMoMMLTydMB7NfF5UIFgXPldSGa3FhHWck?= =?us-ascii?Q?I2mpoMfID950rFn8zyuGZepZcZbV34KZDsv8ntLOlcfyLzgZI2a6EYhL1A9M?= =?us-ascii?Q?IzxX9v5xrvX/cDuafItWXHElJqg7I4ZKs/5t11ZgM08SDf353PzwhTYubXAv?= =?us-ascii?Q?HVBqJinjycRFHpdh6gTgEWLDTaJArOw3HwODfVwMK4KMDxRe+NU04yT2Chq7?= =?us-ascii?Q?EJbaxhuaim91Sm/qTp88B9fRVV/RgXqZgbKCcd4ECpR9vHJ9EBpnRD5HgRmD?= =?us-ascii?Q?JqgngN3M4FCnhTBzvz99ocyue2ZOaRH1YJqsqDMUqTqy3BjBfIDR32a1KunT?= =?us-ascii?Q?Ku1Ej2vF8YsfaKE1cqPqVo5Qd6FLYqv8XyvxLGymMVcLQsSISuM6pMVoeMGD?= =?us-ascii?Q?MMPWuRxnk9jEYjMA+7hQv6BLhWVVfomZJa69KSlQrWMG6MAVVyMjXkzeWCfV?= =?us-ascii?Q?wJjqbU+hJQCv1f6tq5OICBSQ/oI0Ts/qa3RCETmXmimFQMmXP1Ma4LVkld4D?= =?us-ascii?Q?Dxx6idgjywpXZc7OD8gqpGRUVyT5zTdcwklnN8o3Wp7KnHM2Hz53oU8tzs+u?= =?us-ascii?Q?pS849mBTysIysvhwp0BQ1qHuJAwWjfz4dFLGGlwDopUk7XSIDVAi9H972xxo?= =?us-ascii?Q?ji3TVKQITl0Dkqa6p0HzUd2c3mULIQhq4v4w3IBJjOb9RAmZRCieHJgwRfuk?= =?us-ascii?Q?t5zUGBs1hqE4KbQMHdBhN/8K225PB0k+Rx1ZpR4nsQ/eGzOtpOpboAD8ggvS?= =?us-ascii?Q?t3imo22FV4EHXP0vGiAKg1jVRfpIBqiKmWN+8y1JRtlrHwuGB4TdzrBIo2RL?= =?us-ascii?Q?D4tEpcbF9dl3dZ/AqkxulJgpIoMnfNMZ1XPN8V7PJmiWLa3W+fUtccgrIgXm?= =?us-ascii?Q?nA9P6OopJIqyV7nVqGiTRv8sJGELTY8AhwKMLez1tHKTGbwsgYiSev5VYfyv?= =?us-ascii?Q?iwxRiKXTtMK5+vUEdkv2CZ3HBr0yem9iRzU/LrMbECCmV9fA1I7JF5wj71Dh?= =?us-ascii?Q?vA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CYYPR01MB8309.prod.exchangelabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1d13c7a7-d5f2-4706-1eca-08dc48c23f90 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Mar 2024 09:43:50.7006 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PuuWigz1uYo1k37yeMJfkEX7hYcQdsL46UhyZ2pTK1mQI2Qq/Eoj1L0IeJ5ep5DgaDniDbWru+Y54U8bX/DNHRP73pFiyvxVer9uzhBmg5gW5MNblYCEI4j5ONOCzHk9 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR01MB8138 X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > So - OK with using { target vect_int } instead. Sure, it's much better to be target independent. Refactored and committed in r14-9569-g4c276896 Thanks, - Hao ________________________________________ From: Richard Biener Sent: Wednesday, March 20, 2024 16:21 To: Hao Liu OS Cc: GCC-patches@gcc.gnu.org Subject: Re: [PATCH] testsuite: add the case to cover vectorization of A[(i= +x)*stride] [PR114322] On Wed, 20 Mar 2024, Hao Liu OS wrote: > Hi Richard, > > As mentioned in the comments of PR114322 (which has been fixed by PR11415= 1 > r14-9540-ge0e9499a), this patch is to cover the case. > > Bootstrapped and regression tested on aarch64-linux-gnu, OK for trunk? > > gcc/testsuite/ChangeLog: > > PR tree-optimization/114322 > * gcc.dg/vect/pr114322.c: New testcase. > > diff --git a/gcc/testsuite/gcc.dg/vect/pr114322.c b/gcc/testsuite/gcc.dg/= vect/pr114322.c > new file mode 100644 > index 00000000000..7c3a4ffe260 > --- /dev/null > +++ b/gcc/testsuite/gcc.dg/vect/pr114322.c > @@ -0,0 +1,18 @@ > +/* PR tree-optimization/114322 */ > +/* { dg-do compile } */ > + > +int > +foo (short *A, int x, int stride) > +{ > + int sum =3D 0; > + > + if (stride > 1) > + { > + for (int i =3D 0; i < 1024; ++i) > + sum +=3D A[(i + x) * stride]; > + } > + > + return sum; > +} > + > +/* { dg-final { scan-tree-dump "LOOP VECTORIZED" "vect" { target aarch64= *-*-* } } } */ I don't like the target selector very much - if you make 'A' a 'int *', the strided access should be the important part, vect_int should match the requirements - the strided access should end up with VMAT_ELEMENTWISE at worst (possibly gather on aarch64?), and VMAT_ELEMENTWISE doesn't need any alignment. So - OK with using { target vect_int } instead. Richard.