public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Iain Sandoe <iains.gcc@gmail.com>
To: FX Coudert <fxcoudert@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, dmalcolm@redhat.com
Subject: Re: [PATCH] Testsuite: fix analyzer tests on Darwin
Date: Sat, 19 Aug 2023 23:10:07 +0100	[thread overview]
Message-ID: <D0416267-EFB9-4FE2-8812-0D3CCBBF7315@gmail.com> (raw)
In-Reply-To: <629F5631-64EE-4271-9111-208A3C8C7658@gmail.com>

Hi FX,

thanks for chasing these fails down,

> On 19 Aug 2023, at 22:28, FX Coudert <fxcoudert@gmail.com> wrote:
> 

> gcc.dg/analyzer/ currently has 80 failures on Darwin (both x86_64-apple-darwin and aarch64-apple-darwin). All those come from two issues:
> 
> 1. Many tests use memset() without including the <string.h> header. We can fix that easily.
> 
> 2. Other tests fail because of the use of macOS headers, which redefine functions like memcpy and others to “checked”/fortified versions https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104042 Instead of correcting this on a case-by-case basis, add the -D_FORTIFY_SOURCE=0 flag systematically on Darwin.
> 
> With that, all 80 failures are silenced and that part of the testsuite is now clean:
> 
> # of expected passes 5238
> # of expected failures 194
> # of unsupported tests 12

> OK to commit?

LGTM,

Iain

> FX
> 
> <0001-Testsuite-fix-analyzer-tests-on-Darwin.patch>


      reply	other threads:[~2023-08-19 22:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-19 21:28 FX Coudert
2023-08-19 22:10 ` Iain Sandoe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D0416267-EFB9-4FE2-8812-0D3CCBBF7315@gmail.com \
    --to=iains.gcc@gmail.com \
    --cc=dmalcolm@redhat.com \
    --cc=fxcoudert@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).