From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 77876 invoked by alias); 23 Aug 2015 20:14:25 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 77852 invoked by uid 89); 23 Aug 2015 20:14:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-wi0-f175.google.com Received: from mail-wi0-f175.google.com (HELO mail-wi0-f175.google.com) (209.85.212.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sun, 23 Aug 2015 20:14:23 +0000 Received: by wicja10 with SMTP id ja10so54948867wic.1; Sun, 23 Aug 2015 13:14:20 -0700 (PDT) X-Received: by 10.194.179.37 with SMTP id dd5mr32664852wjc.129.1440360860706; Sun, 23 Aug 2015 13:14:20 -0700 (PDT) Received: from [10.107.133.221] ([37.164.114.28]) by smtp.gmail.com with ESMTPSA id y13sm19960909wjq.26.2015.08.23.13.14.17 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 23 Aug 2015 13:14:18 -0700 (PDT) References: In-Reply-To: Mime-Version: 1.0 (1.0) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Message-Id: Cc: Uros Bizjak , "gcc-patches@gcc.gnu.org" , Fortran List From: FX Subject: Re: [patch,libgfortran,toplevel] Use libbacktrace in libgfortran Date: Sun, 23 Aug 2015 20:59:00 -0000 To: Janne Blomqvist X-SW-Source: 2015-08/txt/msg01378.txt.bz2 > Awesome! Looks good. I only have one small bikeshed request: Can you > make the output format match the existing code? Problem with that is that ad the new backtrace uses full path for file name= s, the one-line format easily wraps in 80 column and make the output harder= to read (in my opinion). In realize this is mostly taste an very subjective, so with this nugget of = extra input, I leave the final decision to you: let me know what you think = best, between readability and "conformance" to GDB format. Cheers, FX