public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
To: Richard Biener <rguenther@suse.de>,
	Richard Biener via Gcc-patches <gcc-patches@gcc.gnu.org>,
	gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Turn vect_create_addr_base_for_vector_ref offset into a byte offset
Date: Tue, 26 Oct 2021 12:23:18 +0200	[thread overview]
Message-ID: <D2E68199-EE67-4FFA-8C2E-EDE23D779771@gmail.com> (raw)
In-Reply-To: <5350n593-2893-84q-97p-qo6132qrq6q@fhfr.qr>

On 26 October 2021 10:58:50 CEST, Richard Biener via Gcc-patches <gcc-patches@gcc.gnu.org> wrote:

>@@ -2006,6 +2011,7 @@ get_negative_load_store_type (vec_info *vinfo,
> 	dump_printf_loc (MSG_MISSED_OPTIMIZATION, vect_location,
> 			 "negative step but alignment required.\n");
>       return VMAT_ELEMENTWISE;
>+      *poffset = 0;

Would you want to move this to before the return?
thanks,
>     }
> 
>   if (vls_type == VLS_STORE_INVARIANT)
>@@ -2014,7 +2020,6 @@ get_negative_load_store_type (vec_info *vinfo,
> 	dump_printf_loc (MSG_NOTE, vect_location,
> 			 "negative step with invariant source;"
> 			 " no permute needed.\n");
>-      *poffset = -TYPE_VECTOR_SUBPARTS (vectype) + 1;
>       return VMAT_CONTIGUOUS_DOWN;
>     }


  reply	other threads:[~2021-10-26 10:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-26  8:58 Richard Biener
2021-10-26 10:23 ` Bernhard Reutner-Fischer [this message]
2021-10-26 10:24   ` Richard Biener

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D2E68199-EE67-4FFA-8C2E-EDE23D779771@gmail.com \
    --to=rep.dot.nop@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).