Remove duplicated GOMP SIMD LANE code

Remove duplicated GOMP SIMD LANE code

[Alan Hayward]

[-- Attachment #1: Type: text/plain, Size: 585 bytes --]

The IFN_GOMP_SIMD_LANE code in vectorizable_call is essentially a
duplicate of
the code in vectorizable_live_operation. They both replace all uses
outside the
loop with the constant VF - 1.

Note that my patch to vectorize inductions that are live after the loop
will
also remove the IFN_GOMP_SIMD_LANE code in vectorizable_live_operation.

This patch is required in order for the follow on optimisation (No need to
Vectorise simple only-live stmts) to work.

Tested with libgomp on x86 and aarch64

gcc/
    * tree-vect-stmts.c (vectorizable_call) Remove GOMP_SIMD_LANE code.

Alan.


[-- Attachment #2: duplicatedGOMP.patch --]
[-- Type: application/octet-stream, Size: 1245 bytes --]

diff --git a/gcc/tree-vect-stmts.c b/gcc/tree-vect-stmts.c
index 1ef924a4aa07aa626a603f5fb59bf991a89c1d9a..373ecd7278d2c4edbd1191349bee389b97f0c321 100644
--- a/gcc/tree-vect-stmts.c
+++ b/gcc/tree-vect-stmts.c
@@ -2654,29 +2654,6 @@ vectorizable_call (gimple *gs, gimple_stmt_iterator *gsi, gimple **vec_stmt,
   else
     lhs = gimple_call_lhs (stmt);
 
-  if (gimple_call_internal_p (stmt)
-      && gimple_call_internal_fn (stmt) == IFN_GOMP_SIMD_LANE)
-    {
-      /* Replace uses of the lhs of GOMP_SIMD_LANE call outside the loop
-	 with vf - 1 rather than 0, that is the last iteration of the
-	 vectorized loop.  */
-      imm_use_iterator iter;
-      use_operand_p use_p;
-      gimple *use_stmt;
-      FOR_EACH_IMM_USE_STMT (use_stmt, iter, lhs)
-	{
-	  basic_block use_bb = gimple_bb (use_stmt);
-	  if (use_bb
-	      && !flow_bb_inside_loop_p (LOOP_VINFO_LOOP (loop_vinfo), use_bb))
-	    {
-	      FOR_EACH_IMM_USE_ON_STMT (use_p, iter)
-		SET_USE (use_p, build_int_cst (TREE_TYPE (lhs),
-					       ncopies * nunits_out - 1));
-	      update_stmt (use_stmt);
-	    }
-	}
-    }
-
   new_stmt = gimple_build_assign (lhs, build_zero_cst (type));
   set_vinfo_for_stmt (new_stmt, stmt_info);
   set_vinfo_for_stmt (stmt, NULL);

Re: Remove duplicated GOMP SIMD LANE code

[Richard Biener]

On Thu, Jun 2, 2016 at 6:03 PM, Alan Hayward <alan.hayward@arm.com> wrote:
> The IFN_GOMP_SIMD_LANE code in vectorizable_call is essentially a
> duplicate of
> the code in vectorizable_live_operation. They both replace all uses
> outside the
> loop with the constant VF - 1.
>
> Note that my patch to vectorize inductions that are live after the loop
> will
> also remove the IFN_GOMP_SIMD_LANE code in vectorizable_live_operation.
>
> This patch is required in order for the follow on optimisation (No need to
> Vectorise simple only-live stmts) to work.
>
> Tested with libgomp on x86 and aarch64

Ok.

Thanks,
Richard.

> gcc/
>     * tree-vect-stmts.c (vectorizable_call) Remove GOMP_SIMD_LANE code.
>
> Alan.
>