From: Alan Hayward <alan.hayward@arm.com>
To: Jeff Law <law@redhat.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH][vectorizer] Remove blank debug lines after dump_gimple_stmt
Date: Tue, 07 Jun 2016 12:21:00 -0000 [thread overview]
Message-ID: <D37C5F17.FAEA%alan.hayward@arm.com> (raw)
In-Reply-To: <557dd68a-eb64-a798-2ac4-2a3596a3c951@redhat.com>
On 06/06/2016 18:56, "Jeff Law" <law@redhat.com> wrote:
>On 06/06/2016 06:46 AM, Alan Hayward wrote:
>> Lots of code calls dump_gimple_stmt then print a newline, however
>> dump_gimple_stmt will print a newline itself. This makes the vectorizer
>> debug
>> file messy. I think the confusion is because dump_generic_expr does NOT
>> print a
>> newline. This patch removes all prints of a newline direcly after a
>> dump_gimple_stmt.
>>
>> Tested by examining a selection of vect dump files.
>>
>> gcc/
>> \* tree-vect-data-refs.c (vect_analyze_data_refs): Remove debug
>>newline.
>> \* tree-vect-loop-manip.c (slpeel_make_loop_iterate_ntimes): likewise.
>> (vect_can_advance_ivs_p): likewise.
>> (vect_update_ivs_after_vectorizer): likewise.
>> \* tree-vect-loop.c (vect_determine_vectorization_factor): likewise.
>> (vect_analyze_scalar_cycles_1): likewise.
>> (vect_analyze_loop_operations): likewise.
>> (report_vect_op): likewise.
>> (vect_is_slp_reduction): likewise.
>> (vect_is_simple_reduction): likewise.
>> (get_initial_def_for_induction): likewise.
>> (vect_transform_loop): likewise.
>> \* tree-vect-patterns.c (vect_recog_dot_prod_pattern): likewise.
>> (vect_recog_sad_pattern): likewise.
>> (vect_recog_widen_sum_pattern): likewise.
>> (vect_recog_widening_pattern): likewise.
>> (vect_recog_divmod_pattern): likewise.
>> \* tree-vect-slp.c (vect-build-slp_tree_1): likewise.
>> (vect_analyze_slp_instance): likewise.
>> (vect_transform_slp_perm_load): likewise.
>> (vect_schedule_slp_instance): likewise.
>Wouldn't you also need to verify that the testsuite passes since it
>could potentially have tests which assume the extra newlines in the
>test's regexps?
>
>So I'm fine with this patch once the testsuite has been verified to run
>without regressions on a target which exercises the vectorizer.
>
Sorry, I should have said that I have done a check run on x86 and aarch64,
and there were no regressions.
Alan.
prev parent reply other threads:[~2016-06-07 12:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 12:46 Alan Hayward
2016-06-06 17:57 ` Jeff Law
2016-06-07 12:21 ` Alan Hayward [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D37C5F17.FAEA%alan.hayward@arm.com \
--to=alan.hayward@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).