public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] [ADA] Make install-gnatlib use the correct ranlib for cross-builds
@ 2018-06-30 12:01 Bernd Edlinger
  2018-06-30 13:38 ` Arnaud Charlet
  0 siblings, 1 reply; 2+ messages in thread
From: Bernd Edlinger @ 2018-06-30 12:01 UTC (permalink / raw)
  To: GCC Patches, Eric Botcazou, Arnaud Charlet

[-- Attachment #1: Type: text/plain, Size: 1169 bytes --]

Hi,

there is a minor glitch in the make install for TARGET!=HOST cross-builds,
which affects only Ada AFAICT.

That is "make install" tries to use the wrong ranlib command here:

cd rts; for file in *.a;do \
    /usr/bin/install -c -m 644 $file /home/ed/gnu/arm-linux-gnueabihf-linux64/lib/gcc/arm-linux-gnueabihf/9.0.0/adalib; \
    arm-linux-gnueabihf-ranlib /home/ed/gnu/arm-linux-gnueabihf-linux64/lib/gcc/arm-linux-gnueabihf/9.0.0/adalib/$file; \
done
/bin/bash: line 2: arm-linux-gnueabihf-ranlib: command not found
/bin/bash: line 2: arm-linux-gnueabihf-ranlib: command not found
/bin/bash: line 2: arm-linux-gnueabihf-ranlib: command not found
/bin/bash: line 2: arm-linux-gnueabihf-ranlib: command not found
/bin/bash: line 2: arm-linux-gnueabihf-ranlib: command not found
gcc-interface/Makefile:527: recipe for target 'install-gnatlib' failed
make[4]: [install-gnatlib] Error 127 (ignored)
true


The installed toolchain is nevertheless fully operational, but...


This small correction fixes this glitch.

Boot-strapped and reg-tested on x86_64-pc-linux-gnu and arm-linux-gnueabihf cross.
Is it OK for trunk?


Thanks
Bernd.

[-- Attachment #2: patch-ada-install.diff --]
[-- Type: application/octet-stream, Size: 450 bytes --]

2018-06-30  Bernd Edlinger  <bernd.edlinger@hotmail.de>

	* Makefile.in (FLAGS_TO_PASS): Add RANLIB_FOR_TARGET.

--- gcc/Makefile.in	2018-06-08 09:53:31.000000000 +0200
+++ gcc/Makefile.in	2018-06-30 11:12:39.307438445 +0200
@@ -1154,6 +1154,7 @@
 	"INSTALL_SCRIPT=$(INSTALL_SCRIPT)" \
 	"LN=$(LN)" \
 	"LN_S=$(LN_S)" \
+	"RANLIB_FOR_TARGET=$(RANLIB_FOR_TARGET)" \
 	"MAKEINFO=$(MAKEINFO)" \
 	"MAKEINFOFLAGS=$(MAKEINFOFLAGS)" \
 	"MAKEOVERRIDES=" \

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] [ADA] Make install-gnatlib use the correct ranlib for cross-builds
  2018-06-30 12:01 [PATCH] [ADA] Make install-gnatlib use the correct ranlib for cross-builds Bernd Edlinger
@ 2018-06-30 13:38 ` Arnaud Charlet
  0 siblings, 0 replies; 2+ messages in thread
From: Arnaud Charlet @ 2018-06-30 13:38 UTC (permalink / raw)
  To: Bernd Edlinger; +Cc: GCC Patches, Eric Botcazou


> there is a minor glitch in the make install for TARGET!=HOST cross-builds,
> which affects only Ada AFAICT.
> 
> That is "make install" tries to use the wrong ranlib command here:
> 
> cd rts; for file in *.a;do \
>    /usr/bin/install -c -m 644 $file /home/ed/gnu/arm-linux-gnueabihf-linux64/lib/gcc/arm-linux-gnueabihf/9.0.0/adalib; \
>    arm-linux-gnueabihf-ranlib /home/ed/gnu/arm-linux-gnueabihf-linux64/lib/gcc/arm-linux-gnueabihf/9.0.0/adalib/$file; \
> done
> /bin/bash: line 2: arm-linux-gnueabihf-ranlib: command not found
> /bin/bash: line 2: arm-linux-gnueabihf-ranlib: command not found
> /bin/bash: line 2: arm-linux-gnueabihf-ranlib: command not found
> /bin/bash: line 2: arm-linux-gnueabihf-ranlib: command not found
> /bin/bash: line 2: arm-linux-gnueabihf-ranlib: command not found
> gcc-interface/Makefile:527: recipe for target 'install-gnatlib' failed
> make[4]: [install-gnatlib] Error 127 (ignored)
> true
> 
> 
> The installed toolchain is nevertheless fully operational, but...
> 
> This small correction fixes this glitch.
> 
> Boot-strapped and reg-tested on x86_64-pc-linux-gnu and arm-linux-gnueabihf cross.
> Is it OK for trunk?

Ok, thanks.

Arno

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-06-30 12:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-30 12:01 [PATCH] [ADA] Make install-gnatlib use the correct ranlib for cross-builds Bernd Edlinger
2018-06-30 13:38 ` Arnaud Charlet

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).