From: Mike Stump <mikestump@comcast.net>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org, Jack Howarth <howarth@bromo.med.uc.edu>
Subject: Re: Turn on -pie on darwin11 and later
Date: Thu, 16 Jun 2011 19:40:00 -0000 [thread overview]
Message-ID: <D4EDAB57-D4EA-49C4-B95D-8903918F4550@comcast.net> (raw)
In-Reply-To: <201106161301.03627.pedro@codesourcery.com>
On Jun 16, 2011, at 5:01 AM, Pedro Alves wrote:
> On Thursday 16 June 2011 02:33:50, Mike Stump wrote:
>> BOOT_CFLAGS += -mdynamic-no-pic
>> +
>> +# Ensure we don't try and use -pie, as it is incompatible with pch.
>> +BOOT_LDFLAGS=`case ${host} in *-*-darwin[1][1-9]*) echo -Wl,-no_pie ;; esac;`
>
> Shouldn't this use += like BOOT_CFLAGS?
Yes, fixed. Thanks for the review.
Index: config/mh-darwin
===================================================================
--- config/mh-darwin (revision 175089)
+++ config/mh-darwin (working copy)
@@ -4,4 +4,4 @@
BOOT_CFLAGS += -mdynamic-no-pic
# Ensure we don't try and use -pie, as it is incompatible with pch.
-BOOT_LDFLAGS=`case ${host} in *-*-darwin[1][1-9]*) echo -Wl,-no_pie ;; esac;`
+BOOT_LDFLAGS += `case ${host} in *-*-darwin[1][1-9]*) echo -Wl,-no_pie ;; esac;`
next prev parent reply other threads:[~2011-06-16 19:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-16 5:51 Mike Stump
2011-06-16 12:11 ` Pedro Alves
2011-06-16 19:40 ` Mike Stump [this message]
2011-06-19 19:43 ` Mike Stump
2011-06-19 18:39 ` Mike Stump
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D4EDAB57-D4EA-49C4-B95D-8903918F4550@comcast.net \
--to=mikestump@comcast.net \
--cc=gcc-patches@gcc.gnu.org \
--cc=howarth@bromo.med.uc.edu \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).