From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14393 invoked by alias); 16 Jun 2011 19:23:00 -0000 Received: (qmail 14385 invoked by uid 22791); 16 Jun 2011 19:23:00 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RFC_ABUSE_POST,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from qmta02.emeryville.ca.mail.comcast.net (HELO qmta02.emeryville.ca.mail.comcast.net) (76.96.30.24) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 16 Jun 2011 19:22:46 +0000 Received: from omta23.emeryville.ca.mail.comcast.net ([76.96.30.90]) by qmta02.emeryville.ca.mail.comcast.net with comcast id wiWj1g0061wfjNsA2jNktm; Thu, 16 Jun 2011 19:22:44 +0000 Received: from up.mrs.kithrup.com ([24.4.193.8]) by omta23.emeryville.ca.mail.comcast.net with comcast id wjNs1g00K0BKwT48jjNtVM; Thu, 16 Jun 2011 19:22:54 +0000 Subject: Re: Turn on -pie on darwin11 and later Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Mike Stump In-Reply-To: <201106161301.03627.pedro@codesourcery.com> Date: Thu, 16 Jun 2011 19:40:00 -0000 Cc: gcc-patches@gcc.gnu.org, Jack Howarth Content-Transfer-Encoding: quoted-printable Message-Id: References: <201106161301.03627.pedro@codesourcery.com> To: Pedro Alves X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg01289.txt.bz2 On Jun 16, 2011, at 5:01 AM, Pedro Alves wrote: > On Thursday 16 June 2011 02:33:50, Mike Stump wrote: >> BOOT_CFLAGS +=3D -mdynamic-no-pic >> + >> +# Ensure we don't try and use -pie, as it is incompatible with pch. >> +BOOT_LDFLAGS=3D`case ${host} in *-*-darwin[1][1-9]*) echo -Wl,-no_pie ;= ; esac;` >=20 > Shouldn't this use +=3D like BOOT_CFLAGS? Yes, fixed. Thanks for the review. Index: config/mh-darwin =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- config/mh-darwin (revision 175089) +++ config/mh-darwin (working copy) @@ -4,4 +4,4 @@ BOOT_CFLAGS +=3D -mdynamic-no-pic =20 # Ensure we don't try and use -pie, as it is incompatible with pch. -BOOT_LDFLAGS=3D`case ${host} in *-*-darwin[1][1-9]*) echo -Wl,-no_pie ;; e= sac;` +BOOT_LDFLAGS +=3D `case ${host} in *-*-darwin[1][1-9]*) echo -Wl,-no_pie ;= ; esac;`