* [PATCH 16/22] Enable building libssp with Intel CET
@ 2017-10-12 20:34 Tsimbalist, Igor V
2017-10-18 1:42 ` Jeff Law
0 siblings, 1 reply; 4+ messages in thread
From: Tsimbalist, Igor V @ 2017-10-12 20:34 UTC (permalink / raw)
To: gcc-patches; +Cc: Jeff Law, Tsimbalist, Igor V
[-- Attachment #1: Type: text/plain, Size: 225 bytes --]
Enable building libssp with Intel CET options.
libssp/
* Makefile.am: Update AM_CFLAGS.
* Makefile.in: Regenerate.
* configure: Likewise.
* aclocal.m4: Likewise.
* configure.ac: Set CET_FLAGS. Update XCFLAGS.
[-- Attachment #2: 0016-Enable-building-libssp-with-Intel-CET.PATCH --]
[-- Type: application/octet-stream, Size: 7512 bytes --]
From 70332ad1227b71ffa45722ccce11a9be0d75764d Mon Sep 17 00:00:00 2001
From: Igor Tsimbalist <igor.v.tsimbalist@intel.com>
Date: Tue, 15 Aug 2017 19:55:42 +0300
Subject: [PATCH 16/22] Enable building libssp with Intel CET
libssp/
* Makefile.am: Update AM_CFLAGS.
* Makefile.in: Regenerate.
* configure: Likewise.
* aclocal.m4: Likewise.
* configure.ac: Set CET_FLAGS. Update XCFLAGS.
---
libssp/Makefile.am | 3 ++-
libssp/Makefile.in | 9 ++++---
libssp/aclocal.m4 | 2 ++
libssp/configure | 78 +++++++++++++++++++++++++++++++++++++++++++++++++++--
libssp/configure.ac | 5 ++++
5 files changed, 91 insertions(+), 6 deletions(-)
---
libssp/Makefile.am | 3 ++-
libssp/Makefile.in | 9 ++++---
libssp/aclocal.m4 | 2 ++
libssp/configure | 78 +++++++++++++++++++++++++++++++++++++++++++++++++++--
libssp/configure.ac | 5 ++++
5 files changed, 91 insertions(+), 6 deletions(-)
diff --git a/libssp/Makefile.am b/libssp/Makefile.am
index 72df8e7..9134f96 100644
--- a/libssp/Makefile.am
+++ b/libssp/Makefile.am
@@ -34,6 +34,7 @@ version_dep =
endif
AM_CFLAGS = -Wall
+AM_CFLAGS += $(XCFLAGS)
toolexeclib_LTLIBRARIES = libssp.la libssp_nonshared.la
@@ -53,7 +54,7 @@ libssp_la_LDFLAGS = -version-info `grep -v '^\#' $(srcdir)/libtool-version` \
libssp_nonshared_la_SOURCES = \
ssp-local.c
-libssp_nonshared_la_CFLAGS = -prefer-pic
+libssp_nonshared_la_CFLAGS = -prefer-pic $(XCFLAGS)
libssp_nonshared_la_LIBADD =
libssp_nonshared_la_DEPENDENCIES = $(libssp_nonshared_la_LIBADD)
libssp_nonshared_la_LDFLAGS = -static
diff --git a/libssp/Makefile.in b/libssp/Makefile.in
index 96b03ae..e2a7540 100644
--- a/libssp/Makefile.in
+++ b/libssp/Makefile.in
@@ -69,7 +69,9 @@ am__aclocal_m4_deps = $(top_srcdir)/../config/acx.m4 \
$(top_srcdir)/../config/override.m4 \
$(top_srcdir)/../libtool.m4 $(top_srcdir)/../ltoptions.m4 \
$(top_srcdir)/../ltsugar.m4 $(top_srcdir)/../ltversion.m4 \
- $(top_srcdir)/../lt~obsolete.m4 $(top_srcdir)/configure.ac
+ $(top_srcdir)/../lt~obsolete.m4 \
+ $(top_srcdir)/../config/enable.m4 \
+ $(top_srcdir)/../config/cet.m4 $(top_srcdir)/configure.ac
am__configure_deps = $(am__aclocal_m4_deps) $(CONFIGURE_DEPENDENCIES) \
$(ACLOCAL_M4)
am__CONFIG_DISTCLEAN_FILES = config.status config.cache config.log \
@@ -210,6 +212,7 @@ SET_MAKE = @SET_MAKE@
SHELL = @SHELL@
STRIP = @STRIP@
VERSION = @VERSION@
+XCFLAGS = @XCFLAGS@
abs_builddir = @abs_builddir@
abs_srcdir = @abs_srcdir@
abs_top_builddir = @abs_top_builddir@
@@ -286,7 +289,7 @@ gcc_version := $(shell @get_gcc_base_ver@ $(top_srcdir)/../gcc/BASE-VER)
@LIBSSP_USE_SYMVER_FALSE@version_dep =
@LIBSSP_USE_SYMVER_GNU_TRUE@@LIBSSP_USE_SYMVER_TRUE@version_dep = $(srcdir)/ssp.map
@LIBSSP_USE_SYMVER_SUN_TRUE@@LIBSSP_USE_SYMVER_TRUE@version_dep = ssp.map-sun
-AM_CFLAGS = -Wall
+AM_CFLAGS = -Wall $(XCFLAGS)
toolexeclib_LTLIBRARIES = libssp.la libssp_nonshared.la
libsubincludedir = $(libdir)/gcc/$(target_noncanonical)/$(gcc_version)/include
nobase_libsubinclude_HEADERS = ssp/ssp.h ssp/string.h ssp/stdio.h ssp/unistd.h
@@ -304,7 +307,7 @@ libssp_la_LDFLAGS = -version-info `grep -v '^\#' $(srcdir)/libtool-version` \
libssp_nonshared_la_SOURCES = \
ssp-local.c
-libssp_nonshared_la_CFLAGS = -prefer-pic
+libssp_nonshared_la_CFLAGS = -prefer-pic $(XCFLAGS)
libssp_nonshared_la_LIBADD =
libssp_nonshared_la_DEPENDENCIES = $(libssp_nonshared_la_LIBADD)
libssp_nonshared_la_LDFLAGS = -static
diff --git a/libssp/aclocal.m4 b/libssp/aclocal.m4
index 927988e..7eeae0c 100644
--- a/libssp/aclocal.m4
+++ b/libssp/aclocal.m4
@@ -1000,3 +1000,5 @@ m4_include([../ltoptions.m4])
m4_include([../ltsugar.m4])
m4_include([../ltversion.m4])
m4_include([../lt~obsolete.m4])
+m4_include([../config/enable.m4])
+m4_include([../config/cet.m4])
diff --git a/libssp/configure b/libssp/configure
index b14e922..ff254ba 100755
--- a/libssp/configure
+++ b/libssp/configure
@@ -633,6 +633,7 @@ LIBSSP_USE_SYMVER_GNU_FALSE
LIBSSP_USE_SYMVER_GNU_TRUE
LIBSSP_USE_SYMVER_FALSE
LIBSSP_USE_SYMVER_TRUE
+XCFLAGS
CPP
am__fastdepCC_FALSE
am__fastdepCC_TRUE
@@ -736,6 +737,7 @@ enable_version_specific_runtime_libs
enable_maintainer_mode
enable_multilib
enable_dependency_tracking
+enable_cet
enable_symvers
enable_shared
enable_static
@@ -1376,6 +1378,8 @@ Optional Features:
--enable-multilib build many library versions (default)
--disable-dependency-tracking speeds up one-time build
--enable-dependency-tracking do not reject slow dependency extractors
+ --enable-cet enable Intel CET in target libraries
+ [default=default]
--disable-symvers disable symbol versioning for libssp
--enable-shared[=PKGS] build shared libraries [default=yes]
--enable-static[=PKGS] build static libraries [default=yes]
@@ -4077,6 +4081,76 @@ fi
rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext
CFLAGS="$save_CFLAGS"
+# Add CET specific flags if CET is enabled
+ # Check whether --enable-cet was given.
+if test "${enable_cet+set}" = set; then :
+ enableval=$enable_cet;
+ case "$enableval" in
+ yes|no|default) ;;
+ *) as_fn_error "Unknown argument to enable/disable cet" "$LINENO" 5 ;;
+ esac
+
+else
+ enable_cet=default
+fi
+
+
+case "$target" in
+ i3456786-*-linux* | x86_64-*-linux*)
+ case "$enable_cet" in
+ default)
+ # Check if assembler supports CET.
+ cat confdefs.h - <<_ACEOF >conftest.$ac_ext
+/* end confdefs.h. */
+
+int
+main ()
+{
+asm ("setssbsy");
+ ;
+ return 0;
+}
+_ACEOF
+if ac_fn_c_try_compile "$LINENO"; then :
+ enable_cet=yes
+else
+ enable_cet=no
+fi
+rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext
+ ;;
+ yes)
+ # Check if assembler supports CET.
+ cat confdefs.h - <<_ACEOF >conftest.$ac_ext
+/* end confdefs.h. */
+
+int
+main ()
+{
+asm ("setssbsy");
+ ;
+ return 0;
+}
+_ACEOF
+if ac_fn_c_try_compile "$LINENO"; then :
+
+else
+ as_fn_error "assembler with CET support is required for --enable-cet" "$LINENO" 5
+fi
+rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext
+ ;;
+ esac
+ ;;
+ *)
+ enable_cet=no
+ ;;
+esac
+if test x$enable_cet = xyes; then
+ CET_FLAGS="-fcf-protection -mcet -include cet.h"
+fi
+
+XCFLAGS="$XCFLAGS $CET_FLAGS"
+
+
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether hidden visibility is supported" >&5
$as_echo_n "checking whether hidden visibility is supported... " >&6; }
cat confdefs.h - <<_ACEOF >conftest.$ac_ext
@@ -10671,7 +10745,7 @@ else
lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
lt_status=$lt_dlunknown
cat > conftest.$ac_ext <<_LT_EOF
-#line 10674 "configure"
+#line 10748 "configure"
#include "confdefs.h"
#if HAVE_DLFCN_H
@@ -10777,7 +10851,7 @@ else
lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
lt_status=$lt_dlunknown
cat > conftest.$ac_ext <<_LT_EOF
-#line 10780 "configure"
+#line 10854 "configure"
#include "confdefs.h"
#if HAVE_DLFCN_H
diff --git a/libssp/configure.ac b/libssp/configure.ac
index 9e4a22a..0d228c1 100644
--- a/libssp/configure.ac
+++ b/libssp/configure.ac
@@ -62,6 +62,11 @@ void __attribute__((noinline)) bar (char *x)
[AC_MSG_RESULT(no)])
CFLAGS="$save_CFLAGS"
+# Add CET specific flags if CET is enabled
+GCC_CET_FLAGS(CET_FLAGS)
+XCFLAGS="$XCFLAGS $CET_FLAGS"
+AC_SUBST(XCFLAGS)
+
AC_MSG_CHECKING([whether hidden visibility is supported])
AC_TRY_COMPILE([
void __attribute__((visibility ("hidden"))) bar (void) {}],,
--
1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 16/22] Enable building libssp with Intel CET
2017-10-12 20:34 [PATCH 16/22] Enable building libssp with Intel CET Tsimbalist, Igor V
@ 2017-10-18 1:42 ` Jeff Law
2017-10-31 12:13 ` Tsimbalist, Igor V
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Law @ 2017-10-18 1:42 UTC (permalink / raw)
To: Tsimbalist, Igor V, gcc-patches
On 10/12/2017 02:31 PM, Tsimbalist, Igor V wrote:
> Enable building libssp with Intel CET options.
>
> libssp/
> * Makefile.am: Update AM_CFLAGS.
> * Makefile.in: Regenerate.
> * configure: Likewise.
> * aclocal.m4: Likewise.
> * configure.ac: Set CET_FLAGS. Update XCFLAGS.
>
Same comments as with libcilkrts.
Jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH 16/22] Enable building libssp with Intel CET
2017-10-18 1:42 ` Jeff Law
@ 2017-10-31 12:13 ` Tsimbalist, Igor V
2017-11-08 17:33 ` Jeff Law
0 siblings, 1 reply; 4+ messages in thread
From: Tsimbalist, Igor V @ 2017-10-31 12:13 UTC (permalink / raw)
To: Jeff Law, gcc-patches; +Cc: Tsimbalist, Igor V
[-- Attachment #1: Type: text/plain, Size: 790 bytes --]
The revised patch is attached. The differences are in what options are defined and propagated to Makefile for CET enabling.
Ok for trunk?
Igor
> -----Original Message-----
> From: Jeff Law [mailto:law@redhat.com]
> Sent: Wednesday, October 18, 2017 1:38 AM
> To: Tsimbalist, Igor V <igor.v.tsimbalist@intel.com>; gcc-
> patches@gcc.gnu.org
> Subject: Re: [PATCH 16/22] Enable building libssp with Intel CET
>
> On 10/12/2017 02:31 PM, Tsimbalist, Igor V wrote:
> > Enable building libssp with Intel CET options.
> >
> > libssp/
> > * Makefile.am: Update AM_CFLAGS.
> > * Makefile.in: Regenerate.
> > * configure: Likewise.
> > * aclocal.m4: Likewise.
> > * configure.ac: Set CET_FLAGS. Update XCFLAGS.
> >
>
> Same comments as with libcilkrts.
> Jeff
[-- Attachment #2: 0016-Enable-building-libssp-with-Intel-CET.PATCH --]
[-- Type: application/octet-stream, Size: 7337 bytes --]
From f60e80874cab302d11d877a2d362f65714612bc8 Mon Sep 17 00:00:00 2001
From: Igor Tsimbalist <igor.v.tsimbalist@intel.com>
Date: Tue, 15 Aug 2017 19:55:42 +0300
Subject: [PATCH 16/21] Enable building libssp with Intel CET
libssp/
* Makefile.am: Update AM_CFLAGS, update
libssp_nonshared_la_CFLAGS.
* Makefile.in: Regenerate.
* configure: Likewise.
* aclocal.m4: Likewise.
* configure.ac: Set CET_FLAGS. Update XCFLAGS.
---
libssp/Makefile.am | 3 +-
libssp/Makefile.in | 9 ++++--
libssp/aclocal.m4 | 2 ++
libssp/configure | 80 +++++++++++++++++++++++++++++++++++++++++++++++++++--
libssp/configure.ac | 5 ++++
5 files changed, 93 insertions(+), 6 deletions(-)
diff --git a/libssp/Makefile.am b/libssp/Makefile.am
index 72df8e7..9134f96 100644
--- a/libssp/Makefile.am
+++ b/libssp/Makefile.am
@@ -34,6 +34,7 @@ version_dep =
endif
AM_CFLAGS = -Wall
+AM_CFLAGS += $(XCFLAGS)
toolexeclib_LTLIBRARIES = libssp.la libssp_nonshared.la
@@ -53,7 +54,7 @@ libssp_la_LDFLAGS = -version-info `grep -v '^\#' $(srcdir)/libtool-version` \
libssp_nonshared_la_SOURCES = \
ssp-local.c
-libssp_nonshared_la_CFLAGS = -prefer-pic
+libssp_nonshared_la_CFLAGS = -prefer-pic $(XCFLAGS)
libssp_nonshared_la_LIBADD =
libssp_nonshared_la_DEPENDENCIES = $(libssp_nonshared_la_LIBADD)
libssp_nonshared_la_LDFLAGS = -static
diff --git a/libssp/Makefile.in b/libssp/Makefile.in
index 96b03ae..e2a7540 100644
--- a/libssp/Makefile.in
+++ b/libssp/Makefile.in
@@ -69,7 +69,9 @@ am__aclocal_m4_deps = $(top_srcdir)/../config/acx.m4 \
$(top_srcdir)/../config/override.m4 \
$(top_srcdir)/../libtool.m4 $(top_srcdir)/../ltoptions.m4 \
$(top_srcdir)/../ltsugar.m4 $(top_srcdir)/../ltversion.m4 \
- $(top_srcdir)/../lt~obsolete.m4 $(top_srcdir)/configure.ac
+ $(top_srcdir)/../lt~obsolete.m4 \
+ $(top_srcdir)/../config/enable.m4 \
+ $(top_srcdir)/../config/cet.m4 $(top_srcdir)/configure.ac
am__configure_deps = $(am__aclocal_m4_deps) $(CONFIGURE_DEPENDENCIES) \
$(ACLOCAL_M4)
am__CONFIG_DISTCLEAN_FILES = config.status config.cache config.log \
@@ -210,6 +212,7 @@ SET_MAKE = @SET_MAKE@
SHELL = @SHELL@
STRIP = @STRIP@
VERSION = @VERSION@
+XCFLAGS = @XCFLAGS@
abs_builddir = @abs_builddir@
abs_srcdir = @abs_srcdir@
abs_top_builddir = @abs_top_builddir@
@@ -286,7 +289,7 @@ gcc_version := $(shell @get_gcc_base_ver@ $(top_srcdir)/../gcc/BASE-VER)
@LIBSSP_USE_SYMVER_FALSE@version_dep =
@LIBSSP_USE_SYMVER_GNU_TRUE@@LIBSSP_USE_SYMVER_TRUE@version_dep = $(srcdir)/ssp.map
@LIBSSP_USE_SYMVER_SUN_TRUE@@LIBSSP_USE_SYMVER_TRUE@version_dep = ssp.map-sun
-AM_CFLAGS = -Wall
+AM_CFLAGS = -Wall $(XCFLAGS)
toolexeclib_LTLIBRARIES = libssp.la libssp_nonshared.la
libsubincludedir = $(libdir)/gcc/$(target_noncanonical)/$(gcc_version)/include
nobase_libsubinclude_HEADERS = ssp/ssp.h ssp/string.h ssp/stdio.h ssp/unistd.h
@@ -304,7 +307,7 @@ libssp_la_LDFLAGS = -version-info `grep -v '^\#' $(srcdir)/libtool-version` \
libssp_nonshared_la_SOURCES = \
ssp-local.c
-libssp_nonshared_la_CFLAGS = -prefer-pic
+libssp_nonshared_la_CFLAGS = -prefer-pic $(XCFLAGS)
libssp_nonshared_la_LIBADD =
libssp_nonshared_la_DEPENDENCIES = $(libssp_nonshared_la_LIBADD)
libssp_nonshared_la_LDFLAGS = -static
diff --git a/libssp/aclocal.m4 b/libssp/aclocal.m4
index 927988e..7eeae0c 100644
--- a/libssp/aclocal.m4
+++ b/libssp/aclocal.m4
@@ -1000,3 +1000,5 @@ m4_include([../ltoptions.m4])
m4_include([../ltsugar.m4])
m4_include([../ltversion.m4])
m4_include([../lt~obsolete.m4])
+m4_include([../config/enable.m4])
+m4_include([../config/cet.m4])
diff --git a/libssp/configure b/libssp/configure
index b14e922..d255594 100755
--- a/libssp/configure
+++ b/libssp/configure
@@ -633,6 +633,7 @@ LIBSSP_USE_SYMVER_GNU_FALSE
LIBSSP_USE_SYMVER_GNU_TRUE
LIBSSP_USE_SYMVER_FALSE
LIBSSP_USE_SYMVER_TRUE
+XCFLAGS
CPP
am__fastdepCC_FALSE
am__fastdepCC_TRUE
@@ -736,6 +737,7 @@ enable_version_specific_runtime_libs
enable_maintainer_mode
enable_multilib
enable_dependency_tracking
+enable_cet
enable_symvers
enable_shared
enable_static
@@ -1376,6 +1378,8 @@ Optional Features:
--enable-multilib build many library versions (default)
--disable-dependency-tracking speeds up one-time build
--enable-dependency-tracking do not reject slow dependency extractors
+ --enable-cet enable Intel CET in target libraries
+ [default=default]
--disable-symvers disable symbol versioning for libssp
--enable-shared[=PKGS] build shared libraries [default=yes]
--enable-static[=PKGS] build static libraries [default=yes]
@@ -4077,6 +4081,78 @@ fi
rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext
CFLAGS="$save_CFLAGS"
+# Add CET specific flags if CET is enabled
+ # Check whether --enable-cet was given.
+if test "${enable_cet+set}" = set; then :
+ enableval=$enable_cet;
+ case "$enableval" in
+ yes|no|default) ;;
+ *) as_fn_error "Unknown argument to enable/disable cet" "$LINENO" 5 ;;
+ esac
+
+else
+ enable_cet=default
+fi
+
+
+case "$host" in
+ i3456786-*-linux* | x86_64-*-linux*)
+ enable_cet_compatibility=yes
+ case "$enable_cet" in
+ default)
+ # Check if assembler supports CET.
+ cat confdefs.h - <<_ACEOF >conftest.$ac_ext
+/* end confdefs.h. */
+
+int
+main ()
+{
+asm ("setssbsy");
+ ;
+ return 0;
+}
+_ACEOF
+if ac_fn_c_try_compile "$LINENO"; then :
+ enable_cet=yes
+else
+ enable_cet=no
+fi
+rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext
+ ;;
+ yes)
+ # Check if assembler supports CET.
+ cat confdefs.h - <<_ACEOF >conftest.$ac_ext
+/* end confdefs.h. */
+
+int
+main ()
+{
+asm ("setssbsy");
+ ;
+ return 0;
+}
+_ACEOF
+if ac_fn_c_try_compile "$LINENO"; then :
+
+else
+ as_fn_error "assembler with CET support is required for --enable-cet" "$LINENO" 5
+fi
+rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext
+ ;;
+ esac
+ ;;
+ *)
+ enable_cet=no
+ enable_cet_compatibility=no
+ ;;
+esac
+if test x$enable_cet = xyes; then
+ CET_FLAGS="-fcf-protection -mcet"
+fi
+
+XCFLAGS="$XCFLAGS $CET_FLAGS"
+
+
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether hidden visibility is supported" >&5
$as_echo_n "checking whether hidden visibility is supported... " >&6; }
cat confdefs.h - <<_ACEOF >conftest.$ac_ext
@@ -10671,7 +10747,7 @@ else
lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
lt_status=$lt_dlunknown
cat > conftest.$ac_ext <<_LT_EOF
-#line 10674 "configure"
+#line 10750 "configure"
#include "confdefs.h"
#if HAVE_DLFCN_H
@@ -10777,7 +10853,7 @@ else
lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
lt_status=$lt_dlunknown
cat > conftest.$ac_ext <<_LT_EOF
-#line 10780 "configure"
+#line 10856 "configure"
#include "confdefs.h"
#if HAVE_DLFCN_H
diff --git a/libssp/configure.ac b/libssp/configure.ac
index 9e4a22a..0d228c1 100644
--- a/libssp/configure.ac
+++ b/libssp/configure.ac
@@ -62,6 +62,11 @@ void __attribute__((noinline)) bar (char *x)
[AC_MSG_RESULT(no)])
CFLAGS="$save_CFLAGS"
+# Add CET specific flags if CET is enabled
+GCC_CET_FLAGS(CET_FLAGS)
+XCFLAGS="$XCFLAGS $CET_FLAGS"
+AC_SUBST(XCFLAGS)
+
AC_MSG_CHECKING([whether hidden visibility is supported])
AC_TRY_COMPILE([
void __attribute__((visibility ("hidden"))) bar (void) {}],,
--
1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 16/22] Enable building libssp with Intel CET
2017-10-31 12:13 ` Tsimbalist, Igor V
@ 2017-11-08 17:33 ` Jeff Law
0 siblings, 0 replies; 4+ messages in thread
From: Jeff Law @ 2017-11-08 17:33 UTC (permalink / raw)
To: Tsimbalist, Igor V, gcc-patches
On 10/31/2017 06:12 AM, Tsimbalist, Igor V wrote:
> The revised patch is attached. The differences are in what options are defined and propagated to Makefile for CET enabling.
> Â
> Ok for trunk?
>
> Igor
>
>
>> -----Original Message-----
>> From: Jeff Law [mailto:law@redhat.com]
>> Sent: Wednesday, October 18, 2017 1:38 AM
>> To: Tsimbalist, Igor V <igor.v.tsimbalist@intel.com>; gcc-
>> patches@gcc.gnu.org
>> Subject: Re: [PATCH 16/22] Enable building libssp with Intel CET
>>
>> On 10/12/2017 02:31 PM, Tsimbalist, Igor V wrote:
>>> Enable building libssp with Intel CET options.
>>>
>>> libssp/
>>> * Makefile.am: Update AM_CFLAGS.
>>> * Makefile.in: Regenerate.
>>> * configure: Likewise.
>>> * aclocal.m4: Likewise.
>>> * configure.ac: Set CET_FLAGS. Update XCFLAGS.
>>>
>> Same comments as with libcilkrts.
>> Jeff
>
> 0016-Enable-building-libssp-with-Intel-CET.PATCH
>
>
> From f60e80874cab302d11d877a2d362f65714612bc8 Mon Sep 17 00:00:00 2001
> From: Igor Tsimbalist <igor.v.tsimbalist@intel.com>
> Date: Tue, 15 Aug 2017 19:55:42 +0300
> Subject: [PATCH 16/21] Enable building libssp with Intel CET
>
> libssp/
> * Makefile.am: Update AM_CFLAGS, update
> libssp_nonshared_la_CFLAGS.
> * Makefile.in: Regenerate.
> * configure: Likewise.
> * aclocal.m4: Likewise.
> * configure.ac: Set CET_FLAGS. Update XCFLAGS.
OK. Please wait to commit until entire set is ACK'd.
Jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-08 17:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-12 20:34 [PATCH 16/22] Enable building libssp with Intel CET Tsimbalist, Igor V
2017-10-18 1:42 ` Jeff Law
2017-10-31 12:13 ` Tsimbalist, Igor V
2017-11-08 17:33 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).