From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from resqmta-c1p-023463.sys.comcast.net (resqmta-c1p-023463.sys.comcast.net [IPv6:2001:558:fd00:56::4]) by sourceware.org (Postfix) with ESMTPS id 05D0D3858D37 for ; Sun, 11 Feb 2024 19:12:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 05D0D3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=comcast.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=comcast.net ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 05D0D3858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:558:fd00:56::4 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707678734; cv=none; b=Up4FG0IH6cOOkdG9jvAbdAt58RlukXy9Y+491jwehfmZxNqzfdophpdxoEEimOb5auiTLlhO953RUrGSiob0Yz9ywSe6o3KSIetLHCH0pRNY17Y4AUihx2MoA7WqTvBi82iQDdMifhh34bXFzcHeI9D8bR2VNuYjLTdWxxdt1ts= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707678734; c=relaxed/simple; bh=B6V6JeLgY8Hn9zEj6ktorYz3OvhUDRTd8feSVUTTtzc=; h=DKIM-Signature:Mime-Version:Subject:From:Date:Message-Id:To; b=loh98l967wVvVHzcoTHURl1umAy3RJfu2MWoLjzduAX5f6R4vspehw6QTujDt/wQ1hHTgmCc5P27HgVTDvP2No10ZhAv9KNahzdAKWOVMiAOPh3e6UxPgAVgdVOAzBtLf4gQEhVjSon+PZnWB1TDIBz2GvkQXbk2rLMBwZwimHY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from resomta-c1p-022589.sys.comcast.net ([96.102.18.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 256/256 bits) (Client did not present a certificate) by resqmta-c1p-023463.sys.comcast.net with ESMTP id ZEuMrO5siS1GfZFFMrVhfs; Sun, 11 Feb 2024 19:12:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=20190202a; t=1707678732; bh=TiK9XbUE+rt+H64Z9APWKctFYbkfELnEwbMVgIi1WXM=; h=Received:Received:Content-Type:Mime-Version:Subject:From:Date: Message-Id:To:Xfinity-Spam-Result; b=uESsTOghASOCgftu5VYPggFMQ10kR6RwlHCsVJwRD7w5agQWtH3MqFwZlMlO5ZwhG aiGlQ+xuBoZftzqE/f+HPEmklsvY8hjma4+cTuNNxxZRIpjyK+Y+oSS6DVvrIS2K9p X497ZtbwfD/Wi28NPgjKoe1isszyCVdS8YVw05ZdqThOq5gHPCB/DuvklGcN45AzMK 6BnCKrrgc9Hd9Z9iTQzyUROpk83EB/mBn0bkfUq7Fl8pEvPWTzChMIpqvy4KyJOfxo G1ArAgtJ3P5h7NJo1HbfONMUy+sOKeuyntSvng+/+gUAQ6pABNlWSNXJ+5nZAR+T5R 4mDJ4YJEL95Sw== Received: from smtpclient.apple ([IPv6:2601:644:907e:710:adc5:cc2f:23e1:edd2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 256/256 bits) (Client did not present a certificate) by resomta-c1p-022589.sys.comcast.net with ESMTPSA id ZFFJruURzsJyuZFFKryEyx; Sun, 11 Feb 2024 19:12:11 +0000 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.4\)) Subject: Re: [PATCH] i386, testsuite: adjust asm patterns From: Mike Stump In-Reply-To: Date: Sun, 11 Feb 2024 11:12:09 -0800 Cc: GCC Patches , Fangrui Song , Iain Sandoe Content-Transfer-Encoding: quoted-printable Message-Id: References: To: FX Coudert X-Mailer: Apple Mail (2.3696.120.41.1.4) X-CMAE-Envelope: MS4xfNFUwJUF0rJ2uToEWNuCZ4MfhjY/s92lVf/0Hkas6PDcE2R4JoNxK4FPP1+Vbtlw82oqMJYLGzVCyRkyUOJzXc7M2B9IOMLxGXXT0hhjZx5s6DC0cTyn JJ9MObnP4HiykAKqw5lOCgcD/QrLpCagVAajdq4lYjchhGgbd+rh1elvX4hlkA8jq/0JNx+4Y/ySNVT7Og0lFtrjcOySZB6K401YKWmCAmZw3agB6GnKHVzw bUu30rxlfq7am/qkCfZj9DpbPm9GHFCK848OwjZcj4QaKZsoEUiTmiK3ikbE8FB4BYel1D5X+Uuv/KgJaiLBPPYn3H17kFfOtg4aWUhxfNtXGMqwX56ChXY+ wRkYiTLi X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Feb 10, 2024, at 10:07 AM, FX Coudert wrote: >=20 > The new testcase gcc.target/i386/asm-raw-symbol.c fails on darwin. = This is partly because symbols are prefixed with underscore, and also = because the order of operands in the addition is reversed (but I think = it=E2=80=99s valid still). The code generated is this: >=20 > _func: > LFB0: > pushq %rbp > LCFI0: > movq %rsp, %rbp > LCFI1: > # 8 = "/Users/fx/gcc-upstream/gcc/testsuite/gcc.target/i386/asm-raw-symbol.c" = 1 > @ _func > # 0 "" 2 > # 9 = "/Users/fx/gcc-upstream/gcc/testsuite/gcc.target/i386/asm-raw-symbol.c" = 1 > @ 4+_var > # 0 "" 2 > nop > popq %rbp > LCFI2: > ret >=20 >=20 >=20 > I=E2=80=99m adjusting the pattern accordingly. > OK to push? Ok.=