From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30088.outbound.protection.outlook.com [40.107.3.88]) by sourceware.org (Postfix) with ESMTPS id C4704385840D for ; Sat, 18 Sep 2021 19:13:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C4704385840D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sandoe-acoustics.co.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=sandoe-acoustics.co.uk ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HFXVG0CmrXwWSNL439xhD8+ZKHg0gtBai6PE9cIFuqYNlfik9CUQn00PasaxflW72C+1d3lHuIHRpIVDoBfsQc3dnkt4G5+gLuX47QJi+8lUYbUBoR05dYkdvjGydRmGE2kpek/C8grgsnwyOlX3FZl+ofucnmEwylmL7RzixV7NDGX7SCHTK/Oa8mIJHOLk1QAg5rd+jPmU5EfE08H8tBmTPjKBPE/EkctXVAdcaR+HXYBGBESRqG+UivW0ZpMqwPQgRq+XUWnCA584X4Ac6nireTNr/7o6ugDzYrNHGhxVaImBmhtvSag/SYmMnkHvg6jR95V68Ik/rh06QbbmKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Igv8wC7LTz1dTcXuvEJUmHUKOQNIYXj5E6nXOltggWg=; b=Ylj9G9l7nHWrU6abAtS039fo2g07nDqnC0QzfpZ6xr75/zmdrURE3jP8jrBbVt5ev3PXrJqrnKo7uj5oLSzGrt/2XP2R5m0DBCouFNyIOYaRXUrbvODnPyjY34UT84VeOiBxLLZPk9wGtNitekZx62D30dpGnRpPlaBvFr+Vr4HEuP3CGaS+MY00echiAEvKc56CQ026JopntnzOU/m/XhMXTQsJi42ofGNR7+ZDHlKvo/xYjM7wnYxZLbSgAgzuI520Q+6Hi0EhDFFxwqU9LI2UTDi0fayLCeoaL20u0/mLTC3IOgZ6Es/uLv3oXXc6Bz5B2sXdEf514HWrtp2Tmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=sandoe-acoustics.co.uk; dmarc=pass action=none header.from=sandoe-acoustics.co.uk; dkim=pass header.d=sandoe-acoustics.co.uk; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bt1383820pop.onmicrosoft.com; s=selector2-bt1383820pop-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Igv8wC7LTz1dTcXuvEJUmHUKOQNIYXj5E6nXOltggWg=; b=dEqhDEEPicsTfxJqH8IadtYiIkAU/hq0GbhS4w1I4GW5tuaSEx1uDVCOxPK4MA1qwG/+csSoFvegnZ1EGvnl/gS1XaDIzXYET5LyGN28S9zblG2eXy+vj1EKap/fFxwV724obTXw0gpqS5VCIzpOWEQmrryIMZlQEBUTCrn2QWE= Authentication-Results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=sandoe-acoustics.co.uk; Received: from AM6PR02MB3702.eurprd02.prod.outlook.com (2603:10a6:209:2c::15) by AM7PR02MB6049.eurprd02.prod.outlook.com (2603:10a6:20b:1ac::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.16; Sat, 18 Sep 2021 19:13:53 +0000 Received: from AM6PR02MB3702.eurprd02.prod.outlook.com ([fe80::48d9:2446:cdec:a8dd]) by AM6PR02MB3702.eurprd02.prod.outlook.com ([fe80::48d9:2446:cdec:a8dd%4]) with mapi id 15.20.4523.018; Sat, 18 Sep 2021 19:13:53 +0000 Content-Type: text/plain; charset=utf-8 Subject: Re: [PATCH] libgcc, i386: Export *hf* and *hc* from libgcc_s.so.1 From: Iain Sandoe In-Reply-To: Date: Sat, 18 Sep 2021 20:13:51 +0100 Cc: GCC Patches Content-Transfer-Encoding: quoted-printable Message-Id: References: <20210903074113.39461-1-hongtao.liu@intel.com> <20210903090036.GX920497@tucnak> <20210906070855.GL920497@tucnak> <92E99F52-C804-4F37-870F-C559A46A8C38@googlemail.com> <20210906085853.GP920497@tucnak> <20210907122829.GJ920497@tucnak> <20210908090936.GQ920497@tucnak> To: Hongtao Liu , Jakub Jelinek X-Mailer: Apple Mail (2.3445.104.21) X-ClientProxiedBy: LO4P265CA0028.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ae::20) To AM6PR02MB3702.eurprd02.prod.outlook.com (2603:10a6:209:2c::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.214] (81.138.1.83) by LO4P265CA0028.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ae::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Sat, 18 Sep 2021 19:13:52 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0df0494a-d764-4c10-e8e5-08d97ad8741b X-MS-TrafficTypeDiagnostic: AM7PR02MB6049: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:44; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: B/0Cd45woFmRoEubKa0x0k1T8ER7Z7Kpyz9D7sMo4v3meiYd6ayC222CIQ8+wb6KPIEMvth3amk9HLSdpWb1uC3vcXpi2BecM5QfwPNNamjDwlrflQwdUCeFVTlTznBw3D535Fv1m0PZJmH8FTZbNv56OSGnBHXbPfqHh9vc0vWFrb92EZFdBGGUWzAwVBo0XNQdPhYirfHoOfzav3LC0Vv2d7DmpKOwtUapFkarNKBRyYQcPQfWdBPh8AbwWLXngnoK3oKiozMy2LIDwJGSyo9IzNFo0tD7E3bcYdQ0lv8U3FFqajBbJywJ4cXZwTHrvnVk0nQKvVDqDvilTlCG8NiK/XX8+UC23h9UPLkQ7AL2O2A6+NxuP8oizsPiNIqvzE3Uj4sLtjk6gD91SKejC78kZxxB2qB5Pdi3AxMhCWjnBEED0S+R30P2EffxOBBG37/XAwxEpIELGy6ygC1i+bxWr72z1JhSh5VtdAtfbM1jwIyFtd8FmTXzSHbRtUvrB6I6XEPjuMBiamSuOoLrfIofTBVQ38Ooc3Z7xCnfzv8FsTjkCiLzEHsW93hVSXgnGIdS07pW9tCJtyLsVWCt+fVaF4TSttHE4bKuQ40DU4C7NhetEiABEbN7DZGwesQCKSPLH7o/kcT3neOgvDE68kIPdr8GwKSZaz855jQL/kC1TTd2PsN7H4dChZUVaGeOKUWFJOsxXe6AkZEvXkC6vs/XgupBKCi3SPP7DSdW4VbB5BZ1bP1TIi0BGwgu5cAzKHXSYyZaxA26J4DLQjbCjKJjm7NYR3p1g3WW9DeP8e+V0vhX46l/OhExeRmN2Ptl X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR02MB3702.eurprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(396003)(376002)(136003)(39830400003)(366004)(5660300002)(53546011)(16576012)(26005)(38100700002)(6486002)(38350700002)(52116002)(2906002)(8676002)(2616005)(4326008)(8936002)(66476007)(36756003)(83380400001)(956004)(186003)(66556008)(966005)(110136005)(66946007)(33656002)(316002)(508600001)(86362001)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UWlVK3hHeHkrZkZrSEVncTJUWk0yOUsyb1hvOTVFUG15UkpoSzhvY0JQSWJY?= =?utf-8?B?YVJLeTQ4aWRsNXZ2TDc5V3J6NEhNbkhZZGpTWWMwY0NQb0lzREJiYjZocWtM?= =?utf-8?B?VG95VVlYYTVwV0tWd1BYb3oxS3Y2V1pqR3lQOUJUYlI5ZXBRSE1Ic0xnZmZB?= =?utf-8?B?bnJ4ZWQ4UTdkanNXMEt2UWI2bElmZ3hiUG5Nbng3clQwZUpQRUlPcTgwdERq?= =?utf-8?B?S0h1TVlKcXpIWmNKT1daY0VBbEtCakV6NmhpQkpOY09TUUdyTVp6VENMa1VQ?= =?utf-8?B?aDN1YzEwMEU5RjNNZDNITFlBNjQ4TDViZGZDZnB6VlRDS3psc2lQbnY0aEVE?= =?utf-8?B?SXd3V3F2SkVCV3hhWkc4SWoycitPWFVnSE9pajFVd1lZV041cWprQXRuTXg1?= =?utf-8?B?bVVtcTZlOGFaSUhuOHFtWUdZSC8xdU52T0hnTHloeGhLVFNRUGRxUmh1SDR0?= =?utf-8?B?bVlxZ3FqRG5kYUdWRVEzM0lDbTVVZ0lIR01LQS9VNkdRZkN0dkRDZGRzaVFR?= =?utf-8?B?SFN0eW5LdExXd0NGbm15MXZIZjlKQm5rT014bm5zRkdkbnV0cEYwd1JXYnFH?= =?utf-8?B?UHlLcnhlVkNZdi9oTnFmL3hqVHU1NjBOZzdGTzVKZlRFWHBtZE1zVGo0UWZX?= =?utf-8?B?UlBJN3hGVW05VUJnWThBOGMrNG51UkxXZHh6NGUyK1VQOE15VmdNMkUwU3pH?= =?utf-8?B?a3VEbkZzbW0zeUJGZnkvK3BZNmhPeTBQV0laaUJ4YXFRblRxb090RCs0a2dK?= =?utf-8?B?RDRtYklLOVQ1SXhtSzdXQndQcUFqTzF2OTFpVXVLUFp0Z1AwczVvdHZ0ZWs1?= =?utf-8?B?T3hxUHNjQXdMVG55ZlErdm1DYXFHbXh5cytKb0NlT25VeUFiUVhPRnFGWmhQ?= =?utf-8?B?ZVNUbzArU0ZmeHNFY0tlUzVXaEhQSENMc0dSRzI1QVU3NGFpTkYxVDFMRUo0?= =?utf-8?B?WWdrTXBFZEdHWm1zUm9xM2ZNVk5RWW5oTUQxNngxSmlpa085eDVGYmp5ZFRu?= =?utf-8?B?R0lzQW9yRERuTGZnTGQ5RGZzdStsTGx0WlBwZEo5T3VGb08zKzJONFNmVkRx?= =?utf-8?B?TTJTU1VhZllqZkRnMy9kaHd1MGdqVTNJT2w0a2lyUU81bTNCaXNFMnZtV29J?= =?utf-8?B?Mk4vamsrNEtUM2Z3VDRTMjNaa3czM0pVRXpiK2FpdExVVTFvV09jUS9JNi9N?= =?utf-8?B?aGdUTHZzaXFhbFVzTnFVVExaeEVoYzVaZUVyOVI5OWpWRnNvalVSNEpxUWxB?= =?utf-8?B?dXJITGUzOXFBa040S2kzaEUxZXlPTUNkY2ZJOXNqdzJGOEI4cm9XLzVUYVJM?= =?utf-8?B?bkdad3hUeVhxTzdGRnhYUk45d3hxSkhwczF0WTBFVDJNVU5XcTBWNlY2azJm?= =?utf-8?B?WGR1aUVRM0tENEx0b2xvbHNCaW52emtTNmVwbURUODFaNytlbVBtTytLd1ZE?= =?utf-8?B?OURZWEtxVWdJRk10Tm1FL0g3SFJCOGQrdTJNN1Vla1lzcVZjeC8vMHF4clJj?= =?utf-8?B?ck5idGdhdC9RN0ZMMTlLV09kK3pEcVlrMHRoeUhJc2FrQVVaM0ZUQ1VPZFZM?= =?utf-8?B?SnJ0Vk1jQzl5ZktaTGIyYzVQV2QxTU05b1BWREFjelJ4b0ttbnZxektzSzBI?= =?utf-8?B?ZG1ZejBXWTA2WmJoL2FUNXRrQ0pZaFh5RFJTY1o1bXpRdmthUnJ2VHVkL016?= =?utf-8?B?dEMra3FNdVZvVEVIYUhFVDNhM201TnRCek5jbzFwM1NXUW10aGVYa0Q4RUJN?= =?utf-8?Q?28gsm7T3X620sAa3ZxhnhuVPIta6TlUXnlAybpc?= X-OriginatorOrg: sandoe-acoustics.co.uk X-MS-Exchange-CrossTenant-Network-Message-Id: 0df0494a-d764-4c10-e8e5-08d97ad8741b X-MS-Exchange-CrossTenant-AuthSource: AM6PR02MB3702.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2021 19:13:53.4663 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: eddbedf4-c37d-4645-97d5-2380a349ca88 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qllEqgJaPBVPCs5aNh7XgkXdUAq3jk7WksUvZ9fTiHZ2Mwze26IsHbTr4jd5pCWHphnWt9gK0F5437hJzaFAPxWPEpH61V3sxlFbDknvLGk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR02MB6049 X-Spam-Status: No, score=-8.9 required=5.0 tests=BAYES_00, DKIM_INVALID, DKIM_SIGNED, FORGED_SPF_HELO, GIT_PATCH_0, KAM_COUK, KAM_DMARC_STATUS, KAM_NUMSUBJECT, KAM_SHORT, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Sep 2021 19:13:57 -0000 Hi Hongtao, > On 8 Sep 2021, at 10:31, Hongtao Liu wrote: >=20 > On Wed, Sep 8, 2021 at 5:09 PM Jakub Jelinek wrote: >>=20 >> On Wed, Sep 08, 2021 at 10:37:17AM +0800, Hongtao Liu wrote: >>> Bootstrapped and regtested on x86_64-linux-gnu{-m32,}. >>> Ok for trunk? >>>=20 >>> libgcc/ChangeLog: >>>=20 >>> * config/i386/t-softfp: Compile __{mul,div}hc3 into >>> libgcc_s.so.1. this was applied as=20 https://gcc.gnu.org/pipermail/gcc-cvs/2021-September/353114.html but it seems that (at least on Linux and Darwin) we now see a lot of: /src-local/gcc-master-patched/libgcc/shared-object.mk:14: warning: overridi= ng commands for target `_divhc3.o' Makefile:501: warning: ignoring old commands for target `_divhc3.o' /src-local/gcc-master-patched/libgcc/shared-object.mk:17: warning: overridi= ng commands for target `_divhc3_s.o=E2=80=99 and I think this is because we need to exclude the libgcc2 version of the = functions before adding teh replacements, like the patch below. tested on x86_64-linux, darwin observing that the __divhc3 and __mulh3 symb= ols are present and that the metadata for the source files indicates that t= hey are the replacement sources. OK for master? Iain =E2=80=94=E2=80=94 [PATCH] libgcc, X86: Exclude rules for libgcc2 __{div,mul}hc3. We want to override the libgcc2 generic version of these functions for X86. First exclude the original and the add in the replacements. Signed-off-by: Iain Sandoe libgcc/ChangeLog: * config/i386/t-softfp: Exclude libgcc2 versions of __divhc3 and __mulhc3. --- libgcc/config/i386/t-softfp | 1 + 1 file changed, 1 insertion(+) diff --git a/libgcc/config/i386/t-softfp b/libgcc/config/i386/t-softfp index 7620cc0cec5..fe2ad8a3c08 100644 --- a/libgcc/config/i386/t-softfp +++ b/libgcc/config/i386/t-softfp @@ -2,6 +2,7 @@ LIB2ADD +=3D $(srcdir)/config/i386/sfp-exceptions.c =20 # Replace _divhc3 and _mulhc3. libgcc2-hf-functions =3D _divhc3 _mulhc3 +LIB2FUNCS_EXCLUDE +=3D $(libgcc2-hf-functions) libgcc2-hf-extras =3D $(addsuffix .c, $(libgcc2-hf-functions)) LIB2ADD +=3D $(addprefix $(srcdir)/config/i386/, $(libgcc2-hf-extras)) =20 --=20