From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp006.apm-internet.net (smtp006.apm-internet.net [85.119.248.207]) by sourceware.org (Postfix) with ESMTPS id D2A583858402 for ; Tue, 23 Apr 2024 09:14:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D2A583858402 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sandoe.co.uk Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sandoe.co.uk ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D2A583858402 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=85.119.248.207 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713863648; cv=none; b=JarHt0cCCwwCk59XuSS2+C0doYdhevNHPmC9BWdh5H4zy+hbANkxUPyMhiZzhKBUpzo/VE6oQfeZSjdtUddeON3+qtUkB3Z/ZgLsZ67ivWxmrTCffIiCn3zQMMf+MHN6f1vv9uVYtgcJ3dF12cpJ0lg9x8L4QVPJDMryujvEKio= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713863648; c=relaxed/simple; bh=fm2kLJNLWmCTFpwBbrs5Fm9VyykT5eDYrWvvWmAvqTY=; h=Mime-Version:Subject:From:Date:Message-Id:To; b=RqQ18L3YANBwN9RROp4YlHD3TGcfc7Ig1VGGapm+dA4feL0BIZOblkEKENfWqSOsY+02aZVGHZZLr+UV4BWb/lzvRWwg1Yh8PX81m2BL5DyEZilha0E7EzFMGns4IHYQruhIzSTrTLrFcWQDxX/Ymef7F1Zai1sTITCmWobl2Uw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: (qmail 43057 invoked from network); 23 Apr 2024 09:13:36 -0000 X-APM-Out-ID: 17138636154305 X-APM-Authkey: 257869/1(257869/1) 10 Received: from unknown (HELO smtpclient.apple) (81.138.1.83) by smtp006.apm-internet.net with SMTP; 23 Apr 2024 09:13:36 -0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.8\)) Subject: Re: [PATCH v2] [testsuite] require sqrt_insn effective target where needed From: Iain Sandoe In-Reply-To: <6de1dd9d-de60-6a0c-7a25-67533957e62b@linux.ibm.com> Date: Tue, 23 Apr 2024 10:14:04 +0100 Cc: Rainer Orth , Mike Stump , David Edelsohn , Segher Boessenkool , Kewen Lin , Hans-Peter Nilsson , GCC Patches , Richard Biener Content-Transfer-Encoding: quoted-printable Message-Id: References: <6de1dd9d-de60-6a0c-7a25-67533957e62b@linux.ibm.com> To: Alexandre Oliva , "Kewen.Lin" X-Mailer: Apple Mail (2.3696.120.41.1.8) X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_COUK,KAM_DMARC_STATUS,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Folks, > On 23 Apr 2024, at 09:59, Kewen.Lin wrote: >=20 > Hi, >=20 > on 2024/4/22 17:56, Alexandre Oliva wrote: >> This patch takes feedback received for 3 earlier patches, and adopts = a >> simpler approach to skip the still-failing tests, that I believe to = be >> in line with ppc maintainers' expressed preferences. >> https://gcc.gnu.org/pipermail/gcc-patches/2021-February/565939.html >> https://gcc.gnu.org/pipermail/gcc-patches/2021-March/566617.html >> https://gcc.gnu.org/pipermail/gcc-patches/2021-March/566521.html >> Ping?-ish :-) >>=20 >>=20 >> Some tests fail on ppc and ppc64 when testing a compiler [with = options >> for] for a CPU [emulator] that doesn't support the sqrt insn. >>=20 >> The gcc.dg/cdce3.c is one in which the expected shrink-wrap >> optimization only takes place when the target CPU supports a sqrt >> insn. >>=20 >> The gcc.target/powerpc/pr46728-1[0-4].c tests use -mpowerpc-gpopt and >> call sqrt(), which involves the sqrt insn that the target CPU under >> test may not support. >>=20 >> Require a sqrt_insn effective target for all the affected tests. >>=20 >> Regstrapped on x86_64-linux-gnu and ppc64el-linux-gnu. Also testing >> with gcc-13 on ppc64-vx7r2 and ppc-vx7r2. Ok to install? >>=20 >>=20 >> for gcc/testsuite/ChangeLog >>=20 >> * gcc.dg/cdce3.c: Require sqrt_insn effective target. >> * gcc.target/powerpc/pr46728-10.c: Likewise. >> * gcc.target/powerpc/pr46728-11.c: Likewise. >> * gcc.target/powerpc/pr46728-13.c: Likewise. >> * gcc.target/powerpc/pr46728-14.c: Likewise. >> --- >> gcc/testsuite/gcc.dg/cdce3.c | 3 ++- >> gcc/testsuite/gcc.target/powerpc/pr46728-10.c | 1 + >> gcc/testsuite/gcc.target/powerpc/pr46728-11.c | 1 + >> gcc/testsuite/gcc.target/powerpc/pr46728-13.c | 1 + >> gcc/testsuite/gcc.target/powerpc/pr46728-14.c | 1 + >> 5 files changed, 6 insertions(+), 1 deletion(-) >>=20 >> diff --git a/gcc/testsuite/gcc.dg/cdce3.c = b/gcc/testsuite/gcc.dg/cdce3.c >> index 601ddf055fd71..f759a95972e8b 100644 >> --- a/gcc/testsuite/gcc.dg/cdce3.c >> +++ b/gcc/testsuite/gcc.dg/cdce3.c >> @@ -1,7 +1,8 @@ >> /* { dg-do compile } */ >> /* { dg-require-effective-target hard_float } */ >> +/* { dg-require-effective-target sqrt_insn } */ >> /* { dg-options "-O2 -fmath-errno -fdump-tree-cdce-details = -fdump-tree-optimized" } */ >> -/* { dg-final { scan-tree-dump "cdce3.c:11: \[^\n\r]* function call = is shrink-wrapped into error conditions\." "cdce" } } */ >> +/* { dg-final { scan-tree-dump "cdce3.c:12: \[^\n\r]* function call = is shrink-wrapped into error conditions\." "cdce" } } */ >> /* { dg-final { scan-tree-dump "sqrtf \\(\[^\n\r]*\\); \\\[tail = call\\\]" "optimized" } } */ >> /* { dg-skip-if "doesn't have a sqrtf insn" { mmix-*-* } } */ >>=20 >=20 > This change needs an approval from global maintainer as it touches a = generic test case? >=20 >> diff --git a/gcc/testsuite/gcc.target/powerpc/pr46728-10.c = b/gcc/testsuite/gcc.target/powerpc/pr46728-10.c >> index 3be4728d333a4..7e9bb638106c2 100644 >> --- a/gcc/testsuite/gcc.target/powerpc/pr46728-10.c >> +++ b/gcc/testsuite/gcc.target/powerpc/pr46728-10.c >> @@ -1,6 +1,7 @@ >> /* { dg-do run } */ >> /* { dg-skip-if "-mpowerpc-gpopt not supported" { powerpc*-*-darwin* = } } */ >> /* { dg-options "-O2 -ffast-math -fno-inline -fno-unroll-loops -lm = -mpowerpc-gpopt" } */ >> +/* { dg-require-effective-target sqrt_insn } */ >=20 > This change looks sensible to me. >=20 > Nit: With the proposed change, I'd expect that we can remove the line = for powerpc*-*-darwin*. >=20 > CC Iain to confirm. Indeed, the check for sqrt_insn fails and so the test is unsupported = without needing the separate powerpc*-*-darwin* line, thanks, Iain >=20 > BR, > Kewen >=20 >>=20 >> #include >>=20 >> diff --git a/gcc/testsuite/gcc.target/powerpc/pr46728-11.c = b/gcc/testsuite/gcc.target/powerpc/pr46728-11.c >> index 43b6728a4b812..5bfa25925675a 100644 >> --- a/gcc/testsuite/gcc.target/powerpc/pr46728-11.c >> +++ b/gcc/testsuite/gcc.target/powerpc/pr46728-11.c >> @@ -1,6 +1,7 @@ >> /* { dg-do run } */ >> /* { dg-skip-if "-mpowerpc-gpopt not supported" { powerpc*-*-darwin* = } } */ >> /* { dg-options "-O2 -ffast-math -fno-inline -fno-unroll-loops -lm = -mpowerpc-gpopt" } */ >> +/* { dg-require-effective-target sqrt_insn } */ >>=20 >> #include >>=20 >> diff --git a/gcc/testsuite/gcc.target/powerpc/pr46728-13.c = b/gcc/testsuite/gcc.target/powerpc/pr46728-13.c >> index b9fd63973b728..b66d0209a5e54 100644 >> --- a/gcc/testsuite/gcc.target/powerpc/pr46728-13.c >> +++ b/gcc/testsuite/gcc.target/powerpc/pr46728-13.c >> @@ -1,6 +1,7 @@ >> /* { dg-do run } */ >> /* { dg-skip-if "-mpowerpc-gpopt not supported" { powerpc*-*-darwin* = } } */ >> /* { dg-options "-O2 -ffast-math -fno-inline -fno-unroll-loops -lm = -mpowerpc-gpopt" } */ >> +/* { dg-require-effective-target sqrt_insn } */ >>=20 >> #include >>=20 >> diff --git a/gcc/testsuite/gcc.target/powerpc/pr46728-14.c = b/gcc/testsuite/gcc.target/powerpc/pr46728-14.c >> index 5affff13bdb6c..71a1a70c4e7a2 100644 >> --- a/gcc/testsuite/gcc.target/powerpc/pr46728-14.c >> +++ b/gcc/testsuite/gcc.target/powerpc/pr46728-14.c >> @@ -1,6 +1,7 @@ >> /* { dg-do run } */ >> /* { dg-skip-if "-mpowerpc-gpopt not supported" { powerpc*-*-darwin* = } } */ >> /* { dg-options "-O2 -ffast-math -fno-inline -fno-unroll-loops -lm = -mpowerpc-gpopt" } */ >> +/* { dg-require-effective-target sqrt_insn } */ >>=20 >> #include