From: Mike Stump <mikestump@comcast.net>
To: Steven Bosscher <stevenb.gcc@gmail.com>
Cc: gcc-patches Patches <gcc-patches@gcc.gnu.org>
Subject: Re: remove wrong code in immed_double_const
Date: Sat, 17 Mar 2012 01:03:00 -0000 [thread overview]
Message-ID: <D660DFD8-18D0-49EB-A065-9CDD246DFF7A@comcast.net> (raw)
In-Reply-To: <CABu31nP8nHMCWOsfC1Up7RCoj4q3YdYB6n67ZYRQzzfEdZZgKA@mail.gmail.com>
On Mar 16, 2012, at 3:03 PM, Steven Bosscher wrote:
> On Fri, Mar 16, 2012 at 10:54 PM, Mike Stump <mikestump@comcast.net> wrote:
>> This removes some wrong code.
>>
>> Ok?
>
> ChangeLog is missing.
* emit-rtl.c (immed_double_const): Remove bogus assert.
> Tested how?
Compiles a user program for my port.
> And why is this wrong anyway?
It is wrong because it can assert. The code can generate a constant for every inbound value that it asserts for, so trivially, it is wrong. If it were correct, it would not assert for values it can handle. For it to be correct, there would have to exist a value for which the code fails. The value that failed for me was 0, not a terribly uncommon value.
next prev parent reply other threads:[~2012-03-17 1:03 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 21:54 Mike Stump
2012-03-16 22:04 ` Steven Bosscher
2012-03-17 1:03 ` Mike Stump [this message]
2012-03-17 7:37 ` Richard Sandiford
2012-03-18 0:29 ` Mike Stump
2012-03-18 10:16 ` Richard Sandiford
2012-03-18 16:35 ` Mike Stump
2012-03-19 21:44 ` Richard Sandiford
2012-03-19 23:31 ` Mike Stump
2012-03-20 10:32 ` Richard Guenther
2012-03-20 10:50 ` Richard Sandiford
2012-03-20 11:38 ` Richard Guenther
2012-03-20 12:27 ` Richard Sandiford
2012-03-20 12:47 ` Richard Guenther
2012-03-20 13:55 ` Michael Matz
2012-03-20 20:44 ` Mike Stump
2012-03-21 13:47 ` Michael Matz
2012-03-21 17:01 ` Mike Stump
2012-03-22 13:16 ` Michael Matz
2012-03-22 18:37 ` Mike Stump
2012-03-20 19:41 ` Mike Stump
2012-03-21 1:01 ` Mike Stump
2012-03-21 13:17 ` Richard Sandiford
2012-03-21 21:36 ` Mike Stump
2012-03-22 10:16 ` Richard Sandiford
2012-03-22 10:25 ` Richard Sandiford
2012-03-22 20:28 ` Mike Stump
2012-03-23 10:02 ` Richard Sandiford
2012-03-26 19:14 ` Mike Stump
2012-03-26 20:04 ` Richard Sandiford
2012-03-26 23:57 ` Mike Stump
2012-04-04 21:07 ` Mike Stump
2012-03-22 14:12 ` Michael Matz
2012-03-22 18:55 ` Mike Stump
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D660DFD8-18D0-49EB-A065-9CDD246DFF7A@comcast.net \
--to=mikestump@comcast.net \
--cc=gcc-patches@gcc.gnu.org \
--cc=stevenb.gcc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).