From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5490 invoked by alias); 17 Mar 2012 01:03:11 -0000 Received: (qmail 5481 invoked by uid 22791); 17 Mar 2012 01:03:11 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from qmta11.emeryville.ca.mail.comcast.net (HELO qmta11.emeryville.ca.mail.comcast.net) (76.96.27.211) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 17 Mar 2012 01:02:58 +0000 Received: from omta10.emeryville.ca.mail.comcast.net ([76.96.30.28]) by qmta11.emeryville.ca.mail.comcast.net with comcast id mR0P1i0020cQ2SLABR2xgJ; Sat, 17 Mar 2012 01:02:57 +0000 Received: from up.mrs.kithrup.com ([24.4.193.8]) by omta10.emeryville.ca.mail.comcast.net with comcast id mR2x1i0020BKwT48WR2xDe; Sat, 17 Mar 2012 01:02:57 +0000 Subject: Re: remove wrong code in immed_double_const Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Mike Stump In-Reply-To: Date: Sat, 17 Mar 2012 01:03:00 -0000 Cc: gcc-patches Patches Content-Transfer-Encoding: quoted-printable Message-Id: References: <5FF5A724-3FE1-4E97-8124-542A0B8259FE@comcast.net> To: Steven Bosscher X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-03/txt/msg01196.txt.bz2 On Mar 16, 2012, at 3:03 PM, Steven Bosscher wrote: > On Fri, Mar 16, 2012 at 10:54 PM, Mike Stump wrot= e: >> This removes some wrong code. >>=20 >> Ok? >=20 > ChangeLog is missing. * emit-rtl.c (immed_double_const): Remove bogus assert. > Tested how? Compiles a user program for my port. > And why is this wrong anyway? It is wrong because it can assert. The code can generate a constant for ev= ery inbound value that it asserts for, so trivially, it is wrong. If it we= re correct, it would not assert for values it can handle. For it to be cor= rect, there would have to exist a value for which the code fails. The valu= e that failed for me was 0, not a terribly uncommon value.