public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Olivier Hainque <hainque@adacore.com>
To: Nathan Sidwell <nathan@acm.org>
Cc: Olivier Hainque <hainque@adacore.com>, gcc-patches@gcc.gnu.org
Subject: Re: fix libcc1 dependencies in toplevel Makefile
Date: Wed, 14 Jun 2017 21:11:00 -0000	[thread overview]
Message-ID: <D6D4A5F8-4C3C-411A-8A52-86CE078BD3F8@adacore.com> (raw)
In-Reply-To: <0818f951-0166-5cbb-1b08-3ec7db2b8969@acm.org>


> On Jun 14, 2017, at 13:39 , Nathan Sidwell <nathan@acm.org> wrote:
> 
> Olivier,
>> During highly parallel builds on fast hosts, we have experienced
>> sporadic bootstrap failures on libquadmath like
> 
> I have encountered such a bootstrap problem too.  I guessed dependency race condition, but -j21 was a simpler fix :)

I see :)

> I'm happy to try the patch.

That would bring useful extra datapoints, Thanks!

The patch might be more complex than it needs to be. 

The logic is very simple: I wasn't sure whether I could
add 

 @if gcc-no-bootstrap
 all-[+prefix+][+module+]: maybe-all-gcc
 @endif gcc-no-bootstrap

to all "all" targets after the dependency to stage_current
@if gcc-bootstrap (in Makefile.tpl).

The "depgcc" boolean is simply a mechanism to do that
only for cases where we were adding a extra explicit dependency
to maybe-all-gcc before, that is, only for libcc1.

Olivier



  reply	other threads:[~2017-06-14 21:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-13 12:58 Olivier Hainque
2017-06-14 11:39 ` Nathan Sidwell
2017-06-14 21:11   ` Olivier Hainque [this message]
2017-06-15 12:03     ` Nathan Sidwell
2017-06-15 12:29       ` Olivier Hainque
2017-06-22 12:13 ` Alexandre Oliva
2017-06-26  7:41   ` Olivier Hainque
2017-06-27 16:32     ` Olivier Hainque
2017-06-27 19:53     ` Alexandre Oliva
2017-07-03 21:05       ` Olivier Hainque
2018-06-03 19:13       ` Alexandre Oliva
2018-06-12  2:50         ` Alexandre Oliva
2018-06-12  8:57           ` Olivier Hainque
2018-06-12 15:31           ` Jeff Law
2018-06-26  5:39           ` Alexandre Oliva
2018-06-27 19:53             ` Olivier Hainque

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D6D4A5F8-4C3C-411A-8A52-86CE078BD3F8@adacore.com \
    --to=hainque@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=nathan@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).