From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id 0382E3858431 for ; Mon, 22 Jan 2024 08:25:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0382E3858431 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0382E3858431 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::333 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705911911; cv=none; b=lziWSVXEEqa4cRG/fsuVUL7YRl4+Ayfi+usAM+H7EvldtWWRYtqHXfzckI5FQdhftEQPF75DhJa4yZjdd+CB2Nce2GZOkQzOX9nKwgL6x1VzBVAxGjWC6qc6CMiMQqUfdIDAoAz7pUU6D/5EiGwkppx0ECisc/sCYsaR9pIGgL4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705911911; c=relaxed/simple; bh=Oj+p/TV0U88bIt9lYwEeJSBwewiNk1CF0EVO5reeUlI=; h=DKIM-Signature:Mime-Version:Subject:From:Date:Message-Id:To; b=gioTiXBW59PoQHIrCQHByR8k5GeH34wqcf5Y2w7A/99vfJjD+i0D1q8vss+6J6Laz/PcbYHoKCu/e4vGBNLn/8Wl2oacXncO4YDtcPwldTdMr26E/4Qt0Z6DVtdnwzjF7Qgu0NmlnD3whbDRGwnxvJoAHe95W4Y6VwnwR67IN8A= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-40eaf973eb4so3164575e9.0 for ; Mon, 22 Jan 2024 00:25:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705911900; x=1706516700; darn=gcc.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NZ+Sn/y4bnXiHKOj3xrpk3wjg4GrWG84O6r50D33AaU=; b=ATvP/AyS/n242uVrXCOUqt5PajrYrupxG/iHSFMv4dxABEU+TaAH4+U/WNkvAWm/6m 7W7/7DfCNUaeo0jApjG4yaJws4UMPUR9vOxlIj6uZG4o1/DB4Vyii7+tZM/I/z7y4TRW Aly74ZTRG6jfX+AmlqDP243dtqOXqFChkw82+umK/AibZk81b05vumLKIzIMIoVSf1nK FhNov866LLMvqKnf+u1VR5Ckt3bUC0bhsDZVrbFjivexuQx4EFMmX21rA8IBmtYEpXz9 U0GjHzR0a4gqzdrY75Cew/wKIAoZLWGp9/fRVrpQZoqpqmkohaS5CBbHyE2b4KDtAk0g Kp4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705911900; x=1706516700; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NZ+Sn/y4bnXiHKOj3xrpk3wjg4GrWG84O6r50D33AaU=; b=L7Q4NMxEu/N5AHiWRLZXmc1De37sSoxJXrt0Qn4ipt7Go7FCkKAcPYNlS9a9Lve6Za BI/oC6uxZg8I48AcaGUd4zFzIYJFBqCCoxDKqblKtNGksAhPTvRcGrOBx1oLAKSR8zn+ tpJhCHEV2Z35Yzc4mi2/nWrH0IWJQ1SKS/8VEHjdpThX64ht5qeEOKQZgxthfnC0uA5G POrCpsyO8mA+B7quzpgE9UYuD7vFBvHFvGaM5Yzgy1+8BDrn/V3YrljJdOdVvbh4euhQ yXnmW+lByhms3Uq2z1xnN7vVnrHJ41KhysSqVqgzhLLXB3wOLeiw/Noy02jnAX9GUmHT 6/8Q== X-Gm-Message-State: AOJu0YysWH4GaNqVCuySKrQMjXWxmXd/K2qlQ5FJQ7oTJLFlaWYiqn9J ESpu8ugmQCFC8Q6yqwKKDLpdrIO9VR/AihKLbjB9CfxirtTb6txsTpbXxWSA X-Google-Smtp-Source: AGHT+IGocwJiiGvUP/YV0/o15jFtwF3fZ6skN+G//wBbNb/fTvl2nk81KxRFBKP3RZsdG9WGqsP8CQ== X-Received: by 2002:a7b:c40e:0:b0:40e:8a59:c3b4 with SMTP id k14-20020a7bc40e000000b0040e8a59c3b4mr2002031wmi.189.1705911899424; Mon, 22 Jan 2024 00:24:59 -0800 (PST) Received: from smtpclient.apple (host81-138-1-83.in-addr.btopenworld.com. [81.138.1.83]) by smtp.gmail.com with ESMTPSA id fl6-20020a05600c0b8600b0040ea9ba9d58sm5187040wmb.37.2024.01.22.00.24.58 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jan 2024 00:24:59 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.4\)) Subject: Re: [PATCH] testsuite, jit: Stabilize error output. From: Iain Sandoe In-Reply-To: <20240116111213.42899-1-iain@sandoe.co.uk> Date: Mon, 22 Jan 2024 08:24:58 +0000 Cc: GCC Patches Content-Transfer-Encoding: quoted-printable Message-Id: References: <20240116111213.42899-1-iain@sandoe.co.uk> To: dmalcolm@redhat.com X-Mailer: Apple Mail (2.3696.120.41.1.4) X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: gentle ping, with the increasing use of CI, it seems an idea to tackle this sooner = rather than later. thanks Iain > On 16 Jan 2024, at 11:12, Iain Sandoe wrote: >=20 > Tested on x86_64, i686 Darwin, x86_64 Linux, > OK for trunk? When? > thanks > Iain >=20 > --- 8< --- >=20 > Currently when a test fails, we print out a lot of information, > this includes items that are not stable between invocations (e.g. > the PID for the executable). That makes automated comparisons > between test runs flag any persistent fails as new ones each time > which is not usually what is wanted. >=20 > This patch amends the error output to drop the variable portion > of the message and retain items that should only change if the > failure mode changes. >=20 > gcc/testsuite/ChangeLog: >=20 > * jit.dg/jit.exp: Filter error output to remove per-run > variable content. >=20 > Signed-off-by: Iain Sandoe > --- > gcc/testsuite/jit.dg/jit.exp | 21 +++++++++++++++------ > 1 file changed, 15 insertions(+), 6 deletions(-) >=20 > diff --git a/gcc/testsuite/jit.dg/jit.exp = b/gcc/testsuite/jit.dg/jit.exp > index 286cfa8192a..893ff5f6dd0 100644 > --- a/gcc/testsuite/jit.dg/jit.exp > +++ b/gcc/testsuite/jit.dg/jit.exp > @@ -94,25 +94,34 @@ proc parse_valgrind_logfile {name logfile} { > # unexpected exits. >=20 > proc verify_exit_status { executable wres } { > - lassign $wres pid spawnid os_error_flag value > + set extra [lassign $wres pid spawnid os_error_flag value] > verbose "pid: $pid" 3 > verbose "spawnid: $spawnid" 3 > verbose "os_error_flag: $os_error_flag" 3 > verbose "value: $value" 3 >=20 > # Detect segfaults etc: > - if { [llength $wres] > 4 } { > - if { [lindex $wres 4] =3D=3D "CHILDKILLED" } { > - fail "$executable killed: $wres" > + set len [llength $extra] > + if { $len >=3D 1 } { > + if { [lindex $extra 0] =3D=3D "CHILDKILLED" } { > + set reason "Unknown Reason" > + set detail "No Details" > + if { $len >=3D 2 } { > + set reason [lindex $extra 1] > + if { $len >=3D 3 } { > + set detail [lindex $extra 2] > + } > + } > + fail "$executable killed: $reason $detail" > return > } > } > if { $os_error_flag !=3D 0 } { > - fail "$executable: OS error: $wres" > + fail "$executable: OS error: $os_error_flag $extra" > return > } > if { $value !=3D 0 } { > - fail "$executable: non-zero exit code: $wres" > + fail "$executable: non-zero exit code: $value $extra" > return > } > pass "$executable exited cleanly" > --=20 > 2.39.2 (Apple Git-143) >=20