public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: FX <fxcoudert@gmail.com>
To: Louis Krupp <louis.krupp@zoho.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, fortran <fortran@gcc.gnu.org>
Subject: Re: Possible patch for PR fortran/66056
Date: Mon, 26 Oct 2015 08:55:00 -0000	[thread overview]
Message-ID: <D7F48FA5-C073-4418-B370-4023C106D448@gmail.com> (raw)
In-Reply-To: <150a1e6a0b7.cab0bdc164391.7983815013798427754@zoho.com>

> The problem:  Statement labels within a type declaration are put in the statement label tree belonging to the type declaration's namespace's (instead of the current namespace).  When the line is otherwise empty and an error is issued, gfc_free_st_label tries to delete the label from the label tree belonging to the current namespace and then frees the label structure, leaving an invalid statement label pointer in the type declaration's namespace's label tree.  When that namespace is cleaned up, bad things can happen.

Seems OK.
Please post patches with full ChangeLog entry, stating how they were tested (“bootstraped and regtested on x86_64-linux”, for example). And of course, do an actual full regression-test :)

If that was done, then OK to commit.

Thanks,
FX

  reply	other threads:[~2015-10-26  8:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-26  2:38 Louis Krupp
2015-10-26  8:55 ` FX [this message]
2015-10-26  9:22   ` Louis Krupp
2015-10-26  9:35     ` FX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D7F48FA5-C073-4418-B370-4023C106D448@gmail.com \
    --to=fxcoudert@gmail.com \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=louis.krupp@zoho.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).