public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Andrew Pinski <pinskia@physics.uc.edu>
To: law@redhat.com
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fix PRs middle-end/15014 and middle-end/16973, removing labels with their address taken
Date: Mon, 18 Oct 2004 20:19:00 -0000	[thread overview]
Message-ID: <D8FE15B4-2142-11D9-B4B8-000A95D692F4@physics.uc.edu> (raw)
In-Reply-To: <1098127576.2915.29.camel@localhost.localdomain>

[-- Attachment #1: Type: text/plain, Size: 482 bytes --]


On Oct 18, 2004, at 3:26 PM, Jeffrey A Law wrote:
> It appears that you move the label to the start of the previous
> block, which is probably OK.  I would have moved the label to
> the start of the next block which would probably have been less
> disruptive in terms of the location of the label.  However, given
> the label is not reachable in the flow sense that's probably OK.
>
> Approved.

Thanks.

I also applied the following testcase for PR 16973.

Thanks,
Andrew Pinski


[-- Attachment #2: temp.diff.txt --]
[-- Type: text/plain, Size: 492 bytes --]

Index: testsuite/gcc.dg/pr16973.c
===================================================================
RCS file: testsuite/gcc.dg/pr16973.c
diff -N testsuite/gcc.dg/pr16973.c
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ testsuite/gcc.dg/pr16973.c	18 Oct 2004 19:35:26 -0000
@@ -0,0 +1,10 @@
+/* We were removing the label "a" because
+   we were removing the BB for it but forgot
+   to add back the label.   */
+
+void
+f (void)
+{
+  static __SIZE_TYPE__ x = &&a - &&b;
+  a : b : return;
+}

  reply	other threads:[~2004-10-18 20:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-04 15:06 Andrew Pinski
2004-10-05 22:40 ` Jeffrey A Law
2004-10-05 23:12   ` Joseph S. Myers
2004-10-06  2:35   ` Andrew Pinski
2004-10-06 17:03     ` Jeffrey A Law
2004-10-10 18:01   ` Andrew Pinski
2004-10-18 19:27     ` Jeffrey A Law
2004-10-18 20:19       ` Andrew Pinski [this message]
2004-10-18 21:37 Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D8FE15B4-2142-11D9-B4B8-000A95D692F4@physics.uc.edu \
    --to=pinskia@physics.uc.edu \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=law@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).