From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11382 invoked by alias); 18 Oct 2004 20:18:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 11349 invoked from network); 18 Oct 2004 20:18:32 -0000 Received: from unknown (HELO physunc.phy.uc.edu) (129.137.4.6) by sourceware.org with SMTP; 18 Oct 2004 20:18:32 -0000 Received: from bethe.phy.uc.edu (bethe.geop.uc.edu [10.44.6.245]) by physunc.phy.uc.edu (8.9.3p2/8.9.3) with ESMTP id QAA01872; Mon, 18 Oct 2004 16:18:17 -0400 (EDT) Received: from [10.44.106.140] ([10.44.106.140]) by bethe.phy.uc.edu (8.9.3p2/8.9.3) with ESMTP id QAA06188; Mon, 18 Oct 2004 16:18:18 -0400 (EDT) In-Reply-To: <1098127576.2915.29.camel@localhost.localdomain> References: <2852718A-1614-11D9-81C0-000A95D692F4@physics.uc.edu> <1097015702.22266.583.camel@localhost.localdomain> <1CCD860A-1AE5-11D9-B778-000A95D692F4@physics.uc.edu> <1098127576.2915.29.camel@localhost.localdomain> Mime-Version: 1.0 (Apple Message framework v618) Content-Type: multipart/mixed; boundary=Apple-Mail-16--435586608 Message-Id: Cc: GCC Patches From: Andrew Pinski Subject: Re: [PATCH] Fix PRs middle-end/15014 and middle-end/16973, removing labels with their address taken Date: Mon, 18 Oct 2004 20:19:00 -0000 To: law@redhat.com X-SW-Source: 2004-10/txt/msg01540.txt.bz2 --Apple-Mail-16--435586608 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Content-length: 482 On Oct 18, 2004, at 3:26 PM, Jeffrey A Law wrote: > It appears that you move the label to the start of the previous > block, which is probably OK. I would have moved the label to > the start of the next block which would probably have been less > disruptive in terms of the location of the label. However, given > the label is not reachable in the flow sense that's probably OK. > > Approved. Thanks. I also applied the following testcase for PR 16973. Thanks, Andrew Pinski --Apple-Mail-16--435586608 Content-Transfer-Encoding: 7bit Content-Type: text/plain; x-unix-mode=0644; name="temp.diff.txt" Content-Disposition: attachment; filename=temp.diff.txt Content-length: 492 Index: testsuite/gcc.dg/pr16973.c =================================================================== RCS file: testsuite/gcc.dg/pr16973.c diff -N testsuite/gcc.dg/pr16973.c --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ testsuite/gcc.dg/pr16973.c 18 Oct 2004 19:35:26 -0000 @@ -0,0 +1,10 @@ +/* We were removing the label "a" because + we were removing the BB for it but forgot + to add back the label. */ + +void +f (void) +{ + static __SIZE_TYPE__ x = &&a - &&b; + a : b : return; +} --Apple-Mail-16--435586608--