public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [testsuite patch] don't add ARM options for a thumb1 multilib
@ 2014-08-11 22:00 Janis Johnson
  2014-08-11 23:50 ` Mike Stump
  0 siblings, 1 reply; 2+ messages in thread
From: Janis Johnson @ 2014-08-11 22:00 UTC (permalink / raw)
  To: gcc-patches

[-- Attachment #1: Type: text/plain, Size: 313 bytes --]

Test gcc.dg/pr59418.c adds ARM-specific options for an ARM target, but
those options conflict with flags for a thumb1 multilib.  Don't add
the extra ARM flags for a thumb1 multilib.  Tested with arm-none-linux-gnu
for mainline and 4.9 with a variety of multilib flags.

OK for mainline and the 4.9 branch?

Janis

[-- Attachment #2: gcc-20140811-3 --]
[-- Type: text/plain, Size: 647 bytes --]

2014-08-11  Janis Johnson  <janisjo@codesourcery.com>

	* gcc.dg/pr59418.c: Don't add ARM options for a Thumb1 multilib.

Index: gcc/testsuite/gcc.dg/pr59418.c
===================================================================
--- gcc/testsuite/gcc.dg/pr59418.c	(revision 437379)
+++ gcc/testsuite/gcc.dg/pr59418.c	(working copy)
@@ -3,7 +3,7 @@
 
 /* { dg-do compile } */
 /* { dg-options "-Os -g" } */
-/* { dg-options "-march=armv7-a -mfloat-abi=hard -Os -g" { target arm*-*-* } } */
+/* { dg-options "-march=armv7-a -mfloat-abi=hard -Os -g" { target { arm*-*-* && { ! arm_thumb1 } } } } */
 
 extern int printf (const char *__format, ...);
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [testsuite patch] don't add ARM options for a thumb1 multilib
  2014-08-11 22:00 [testsuite patch] don't add ARM options for a thumb1 multilib Janis Johnson
@ 2014-08-11 23:50 ` Mike Stump
  0 siblings, 0 replies; 2+ messages in thread
From: Mike Stump @ 2014-08-11 23:50 UTC (permalink / raw)
  To: janisjo; +Cc: gcc-patches

On Aug 11, 2014, at 3:00 PM, Janis Johnson <janis_johnson@mentor.com> wrote:
> Test gcc.dg/pr59418.c adds ARM-specific options for an ARM target, but
> those options conflict with flags for a thumb1 multilib.  Don't add
> the extra ARM flags for a thumb1 multilib.  Tested with arm-none-linux-gnu
> for mainline and 4.9 with a variety of multilib flags.
> 
> OK for mainline and the 4.9 branch?

Ok.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-08-11 23:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-11 22:00 [testsuite patch] don't add ARM options for a thumb1 multilib Janis Johnson
2014-08-11 23:50 ` Mike Stump

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).