From: FX Coudert <fxcoudert@gmail.com>
To: Janne Blomqvist <blomqvist.janne@gmail.com>
Cc: gfortran <fortran@gcc.gnu.org>, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch, fortran] Use correct type for transferring array descriptor info to library
Date: Fri, 27 Jul 2007 07:21:00 -0000 [thread overview]
Message-ID: <DA8B3E55-BD19-4F35-9A7D-9E4F4FC09946@gmail.com> (raw)
In-Reply-To: <46A8ACDC.8090608@gmail.com>
> I plan to commit the following obvious patch in 24 hours unless
> someone objects. The problem is that the array descriptor triplets
> for each dimension (ubound, stride, lbound) are transferred as
> GFC_INTEGER_4 rather than as the correct array index type
> (typedeffed to ssize_t). It's a rather obscure bug, surfacing only
> when doing namelist I/O on big arrays on 64-bit platforms. But it's
> the right thing to do, so it should be done.
Do you have any ways to write a testcase that doesn't need gigabytes
of disk space?
The patch is otherwise OK.
FX
prev parent reply other threads:[~2007-07-27 6:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 14:26 Janne Blomqvist
2007-07-27 7:21 ` FX Coudert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DA8B3E55-BD19-4F35-9A7D-9E4F4FC09946@gmail.com \
--to=fxcoudert@gmail.com \
--cc=blomqvist.janne@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).