From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19175 invoked by alias); 27 Jun 2018 11:22:42 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 19155 invoked by uid 89); 27 Jun 2018 11:22:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR01-HE1-obe.outbound.protection.outlook.com Received: from mail-he1eur01on0081.outbound.protection.outlook.com (HELO EUR01-HE1-obe.outbound.protection.outlook.com) (104.47.0.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Jun 2018 11:22:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TZBB2RXqkSlUFRTIqA/Nz8zSlZqLPc+AwLzOObp5mSQ=; b=ljbx7y7GnuhKxbYp9xtj1/TVn6eGtKxZRvNBq3z5+CF2gCkOtV427LfpQ30svo945HSDG/C4Ys30N5uczxtrtjh6PNFYdY5xgnsvCKEbctjb4tYd8TjjOwx0WfsifUM9wnoDTxAWDwbso2Jh7JkY9H9AAUgHGDOvAS+pAi/S3mE= Received: from DB5PR08MB1030.eurprd08.prod.outlook.com (10.166.14.15) by DB5PR08MB0357.eurprd08.prod.outlook.com (10.161.241.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.884.23; Wed, 27 Jun 2018 11:22:35 +0000 Received: from DB5PR08MB1030.eurprd08.prod.outlook.com ([fe80::91bf:53e7:a639:a183]) by DB5PR08MB1030.eurprd08.prod.outlook.com ([fe80::91bf:53e7:a639:a183%2]) with mapi id 15.20.0884.025; Wed, 27 Jun 2018 11:22:35 +0000 From: Wilco Dijkstra To: Eric Botcazou CC: James Greenhalgh , "gcc-patches@gcc.gnu.org" , Sudakshina Das , Jeff Law , nd , Marcus Shawcroft , Richard Earnshaw Subject: Re: [PATCH][AARCH64] PR target/84521 Fix frame pointer corruption with -fomit-frame-pointer with __builtin_setjmp Date: Wed, 27 Jun 2018 11:22:00 -0000 Message-ID: References: <4ee92fe8-3070-0129-59ad-40cbe0207822@arm.com> <16280160.Nx4lr6RsWP@polaris> ,<3672268.4e9OnHKVQs@polaris> In-Reply-To: <3672268.4e9OnHKVQs@polaris> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Wilco.Dijkstra@arm.com; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-SW-Source: 2018-06/txt/msg01671.txt.bz2 Eric Botcazou wrote: >> This test can easily be changed not to use optimize since it doesn't look >> like it needs it. We really need to tests these builtins properly, >> otherwise they will continue to fail on most targets. > > As far as I can see PR target/84521 has been reported only for Aarch64 so= I'd=20 > just leave the other targets alone (and avoid propagating FUD if possible= ). It's quite obvious from PR84521 that this is an issue affecting all targets. Adding better generic tests for __builtin_setjmp can only be a good thing. Wilco