From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44759 invoked by alias); 5 Sep 2017 15:02:31 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 44562 invoked by uid 89); 5 Sep 2017 15:02:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR02-AM5-obe.outbound.protection.outlook.com Received: from mail-eopbgr00074.outbound.protection.outlook.com (HELO EUR02-AM5-obe.outbound.protection.outlook.com) (40.107.0.74) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Sep 2017 15:02:25 +0000 Received: from DB6PR0801MB2053.eurprd08.prod.outlook.com (10.168.86.22) by DB6PR0801MB1656.eurprd08.prod.outlook.com (10.169.226.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10; Tue, 5 Sep 2017 15:02:22 +0000 Received: from DB6PR0801MB2053.eurprd08.prod.outlook.com ([fe80::2d78:6ac0:142:cc9a]) by DB6PR0801MB2053.eurprd08.prod.outlook.com ([fe80::2d78:6ac0:142:cc9a%18]) with mapi id 15.20.0013.018; Tue, 5 Sep 2017 15:02:22 +0000 From: Wilco Dijkstra To: Bernd Edlinger , Christophe Lyon , Kyrill Tkachov CC: Ramana Radhakrishnan , GCC Patches , Richard Earnshaw , nd Subject: Re: [PING**2] [PATCH, ARM] Further improve stack usage on sha512 (PR 77308) Date: Tue, 05 Sep 2017 15:02:00 -0000 Message-ID: References: <59AD6894.7010605@foss.arm.com> , In-Reply-To: x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DB6PR0801MB1656;6:d4ORgcFMyDfoVuT57KzPDag2wWVGmPpcA5Z+c3SA62gCGsy2wrghg1KnPebLRguJeoziFNkh/RDzQCG2uoJ1hEnWZhwGlC0DOTsgXgMkiXe6SK+3BDRQrrrYXJAYgWRcfHdvpc4aYZli2K0cl2C4kS9IipbTZAWIExRRuHahCu6qzsUC+jLUO69fISia+Z8UxWaDbBwyyYHv6d4PTs/8GL/xS4G4NNkVdF6D29lf823/KBjupOCf/zaVy2N0M6opVn8D/5LrqVgGEN18m4+iifi2+NvEXbxeHRDeK6Kpoz8FbvZGTF+XTHZolAqGvvbyXcfCnCJgBLryMjG0CdaS+w==;5:jUWSxeaF6ymqSrlbroqGL1RPgqBGrcmdFWpzN0zoyNxjnMSwY4nKQvb0yImBahDOsOS4LEc7Qa91h5lnFu70Jh3HXpKW7YgoDxmuK6HXq2dlY+jD363zUYcp3q3F+24cc23SIRiLgjLp5eHfk+6tZQ==;24:sGWgLIs273SJzR+QXur0Ek/NHJrB+4R3Un1eexqTFakcucGmc8e7dY/XMh9H1liHtCcQsFLt6i54x/4AdUPFYxdRah26KgKSjTAWrKDQFSA=;7:ruRkcxdYAVY066JeyUaHGk9fyKppFo7hDZw3QEgBYvX+PnIQzBmaJUUD3lw8ynbHGnEhJSjVeZyZbM0SXafja/3ojNL0HKiV/qqdOZVzNSxK31a/1cYqiQHL18HbfCO1a6JnNlZScD+ecfWA0k1+PpetIq+hf6XVaeKELyJ1e/dxoMTeaoB58dMIYcZq4h/Yx45ejPu50meTZo1olUfclOKgvWTBQHg7ijuMSUQfAnE= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 20a3a9f0-506a-40c5-b7a9-08d4f46f1c6a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:DB6PR0801MB1656; x-ms-traffictypediagnostic: DB6PR0801MB1656: nodisclaimer: True x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(6055026)(6041248)(20161123555025)(20161123562025)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DB6PR0801MB1656;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DB6PR0801MB1656; x-forefront-prvs: 0421BF7135 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39860400002)(189002)(199003)(24454002)(6506006)(50986999)(5660300001)(2900100001)(68736007)(54356999)(305945005)(54906002)(8936002)(9686003)(53936002)(101416001)(4326008)(74316002)(6246003)(7696004)(76176999)(6436002)(33656002)(2906002)(3280700002)(14454004)(97736004)(25786009)(2950100002)(66066001)(93886005)(8676002)(3660700001)(5250100002)(55016002)(99286003)(81156014)(229853002)(189998001)(81166006)(106356001)(102836003)(6116002)(105586002)(86362001)(72206003)(3846002)(478600001)(7736002);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0801MB1656;H:DB6PR0801MB2053.eurprd08.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Wilco.Dijkstra@arm.com; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Sep 2017 15:02:22.0604 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1656 X-SW-Source: 2017-09/txt/msg00277.txt.bz2 Bernd Edlinger wrote: > Combine creates an invalid insn out of these two insns: Yes it looks like a latent bug. We need to use arm_general_register_operand as arm_adddi3/subdi3 only allow integer registers. You don't need a new pre= dicate s_register_operand_nv. Also I'd prefer something like arm_general_adddi_ope= rand. + "TARGET_32BIT && ((!TARGET_NEON && !TARGET_IWMMXT) || reload_completed)" The split condition for adddi3 now looks more accurate indeed, although we = could remove the !TARGET_NEON from the split condition as this is always true giv= en arm_adddi3 uses "TARGET_32BIT && !TARGET_NEON". Also there are more cases, a quick grep suggests *anddi_notdi_di has the sa= me issue. Wilco