From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76917 invoked by alias); 31 Jan 2018 13:33:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 76905 invoked by uid 89); 31 Jan 2018 13:33:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-7.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR03-VE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr50070.outbound.protection.outlook.com (HELO EUR03-VE1-obe.outbound.protection.outlook.com) (40.107.5.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 31 Jan 2018 13:33:09 +0000 Received: from DB6PR0801MB2053.eurprd08.prod.outlook.com (10.168.86.22) by DB6PR0801MB1864.eurprd08.prod.outlook.com (10.168.85.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Wed, 31 Jan 2018 13:33:05 +0000 Received: from DB6PR0801MB2053.eurprd08.prod.outlook.com ([fe80::3cba:f6a6:c08c:8f0e]) by DB6PR0801MB2053.eurprd08.prod.outlook.com ([fe80::3cba:f6a6:c08c:8f0e%18]) with mapi id 15.20.0444.016; Wed, 31 Jan 2018 13:33:05 +0000 From: Wilco Dijkstra To: Richard Sandiford CC: GCC Patches , nd , "maxim.kuvyrkov@linaro.org" Subject: Re: [PATCH] PR84068: Fix sort order of SCHED_PRESSURE_MODEL Date: Wed, 31 Jan 2018 14:43:00 -0000 Message-ID: References: ,<87k1vy5gdy.fsf@linaro.org> In-Reply-To: <87k1vy5gdy.fsf@linaro.org> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Wilco.Dijkstra@arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DB6PR0801MB1864;7:6dc4wudoJeWy8K3j6kpV8f6f5w2suM9YPTLjj1itnKOsuGrKYHJsKmFq1G2QnFnMn/SQhaoXmdLpdAy3IUjE+RNDdOQK1KEXrFvBNl/3Q/rV83kf/S+yqgiAELePmG2MjnobQp9MIDU+gf/U+rkMqlzHK/nxyLhS7dsghv2uwFg187r2wSQpBkSbAMTZUKaNw+bC+uTVSv43M2gYAtBfqIU1Bm7PcE9ZLxEKqhR+Bec716F7uF5tz4ZGIHYF9U2M x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: ede98c66-024e-4213-f9f9-08d568af28c9 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020);SRVR:DB6PR0801MB1864; x-ms-traffictypediagnostic: DB6PR0801MB1864: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(22074186197030)(183786458502308); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231101)(2400082)(944501161)(10201501046)(3002001)(6055026)(6041288)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(6072148)(201708071742011);SRVR:DB6PR0801MB1864;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0801MB1864; x-forefront-prvs: 056929CBB8 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(346002)(376002)(366004)(39860400002)(39380400002)(396003)(199004)(189003)(7696005)(6506007)(14454004)(229853002)(59450400001)(8676002)(4326008)(54906003)(81156014)(478600001)(33656002)(81166006)(6436002)(26005)(6916009)(316002)(97736004)(76176011)(5660300001)(5250100002)(102836004)(2950100002)(2900100001)(72206003)(55016002)(74316002)(53936002)(3660700001)(99286004)(966005)(186003)(2906002)(106356001)(68736007)(6246003)(8936002)(66066001)(25786009)(305945005)(3280700002)(7736002)(6306002)(105586002)(86362001)(9686003)(6116002)(3846002);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0801MB1864;H:DB6PR0801MB2053.eurprd08.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: TcEGzA8EF/4H+N2AI3djtahPguFXiGg4aetDIWsjGvqcjJ2zpu/lGJWYnfnZRg6BfPr+LNsjKy+Sn2V/mnySOQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: ede98c66-024e-4213-f9f9-08d568af28c9 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2018 13:33:05.5059 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1864 X-SW-Source: 2018-01/txt/msg02445.txt.bz2 Richard Sandiford wrote: > This was the original intent, but was changed in r213708.=A0 TBH I'm not > sure what the second hunk in that revision fixed, since model_index is > supposed to return an index greater than all valid indices when passed > an instruction outside the current block.=A0 Maxim, do you remember? See https://gcc.gnu.org/ml/gcc-patches/2014-07/msg00932.html, it says: "The second one is to account for the fact that model_index() of two instru= ctions is meaningful only when both instructions are in the current basic block." Unless something has changed, I'm assuming that's still true today. Maybe the underlying idea was to allow interleaving of instructions outside the current block, but that isn't feasible if you want a well-defined sort orde= ring. Wilco