From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12993 invoked by alias); 11 Feb 2020 10:05:45 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 12984 invoked by uid 89); 11 Feb 2020 10:05:45 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 spammy= X-HELO: EUR04-VI1-obe.outbound.protection.outlook.com Received: from mail-eopbgr80040.outbound.protection.outlook.com (HELO EUR04-VI1-obe.outbound.protection.outlook.com) (40.107.8.40) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 11 Feb 2020 10:05:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jalKt1zowlfxHw8uRbKnjW708m6NWGe07ERLdW1OtRA=; b=qafBJfkn0VDYb3lyef+i2n9K1oY0+35ginJ9UuuoDqHFHLCY8Xuym6uQWLkv3qadotQkUrtgW+7PvKnH/FEX8NxpA4m2fISDPxXFPU35Tatm8bKcMDC+yZAwEB0p0ldOc7x94cNRqd7nqDkEF7/n0JeGfDaVrWHX+kKJOrEKFps= Received: from VI1PR08CA0267.eurprd08.prod.outlook.com (2603:10a6:803:dc::40) by AM0PR08MB3361.eurprd08.prod.outlook.com (2603:10a6:208:db::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2707.21; Tue, 11 Feb 2020 10:05:36 +0000 Received: from DB5EUR03FT012.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e0a::206) by VI1PR08CA0267.outlook.office365.com (2603:10a6:803:dc::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2707.21 via Frontend Transport; Tue, 11 Feb 2020 10:05:36 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;gcc.gnu.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT012.mail.protection.outlook.com (10.152.20.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2665.18 via Frontend Transport; Tue, 11 Feb 2020 10:05:35 +0000 Received: ("Tessian outbound 846b976b3941:v42"); Tue, 11 Feb 2020 10:05:35 +0000 X-CR-MTA-TID: 64aa7808 Received: from c1556518b062.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B77EC295-B7A7-4A82-9FA0-4C3D03E00B9D.1; Tue, 11 Feb 2020 10:05:30 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c1556518b062.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 11 Feb 2020 10:05:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RsBDaazScIasUo8IOl+rHLEtgcZMYje76A0nyxjfsyJBuZxTduuNXthy3Rfz3l5YpN/qJetvDVOCTcCnRAzKEHcZ23pBWJYaKRqB1DIQ1rt5obdZpxD2/TIFZZaYZo6fq6YtPCE+SjptL+scD37oHoR2LZKxpUh17XseEdXb4E4lxVSlsZze91Sr0aG95MobZDk1d7eePWI5f2mG6tpaMKTzYFDLGHUoCr25oXQRPd0MfNkqjNprknjuCSSbLvq2u7Q13JHNY06dd3XE4IAqPMAoZfaXwhZTMRPsh8toUD/HQKulyCaCgZA/FWjpwHq7GDN7u27oo8I8eOSzyKJi6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jalKt1zowlfxHw8uRbKnjW708m6NWGe07ERLdW1OtRA=; b=V+2rhz6i9Nq8t6oMDqnRIrD+6Sy0Mcp+qRkSU3sBfHguMvwWWWXuKSZc2avprfaM+66r1bNDyaotJZwLhisrxvTwORzzjGjxAMu/ItzL1f5K4AKiO49Nf5fYB6pyA6zAlUcTxihpfWT/6ROEC8QvKlW5uBme4hNDtXVSPZQhgIFDmS7fvWIOc6fWezXKdMjH89tvW9VtGuM8bNd2SyICwX53eaSPuWGbgsADUpL/DJd957TTdHiCKjTtd7mJ5YqeRj+PtIiutcWZR7bGdfRMKM4xNIrXnOyk847yH+g/uCLQzdvZSvcEuDATzjUm3C7XMvqhPsMExPIKVW3SZfsqzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jalKt1zowlfxHw8uRbKnjW708m6NWGe07ERLdW1OtRA=; b=qafBJfkn0VDYb3lyef+i2n9K1oY0+35ginJ9UuuoDqHFHLCY8Xuym6uQWLkv3qadotQkUrtgW+7PvKnH/FEX8NxpA4m2fISDPxXFPU35Tatm8bKcMDC+yZAwEB0p0ldOc7x94cNRqd7nqDkEF7/n0JeGfDaVrWHX+kKJOrEKFps= Received: from DB6PR0802MB2245.eurprd08.prod.outlook.com (10.172.227.8) by DB6PR0802MB2533.eurprd08.prod.outlook.com (10.172.251.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2707.21; Tue, 11 Feb 2020 10:05:28 +0000 Received: from DB6PR0802MB2245.eurprd08.prod.outlook.com ([fe80::34ae:7bde:592f:ddf6]) by DB6PR0802MB2245.eurprd08.prod.outlook.com ([fe80::34ae:7bde:592f:ddf6%10]) with mapi id 15.20.2707.030; Tue, 11 Feb 2020 10:05:28 +0000 From: Tamar Christina To: Feng Xue OS , Martin Jambor , Jan Hubicka , "gcc-patches@gcc.gnu.org" CC: nd Subject: RE: [PATCH V2] Generalized value pass-through for self-recursive function (ipa/pr93203) Date: Tue, 11 Feb 2020 10:05:00 -0000 Message-ID: References: , In-Reply-To: x-ts-tracking-id: 3981286f-126e-49c6-b006-59586cb01bd2.1 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Tamar.Christina@arm.com; x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(396003)(39860400002)(136003)(376002)(346002)(366004)(189003)(199004)(4326008)(86362001)(110136005)(64756008)(66446008)(66556008)(66476007)(66946007)(33656002)(53546011)(71200400001)(6506007)(478600001)(316002)(7696005)(52536014)(8676002)(76116006)(9686003)(55016002)(2906002)(81156014)(186003)(8936002)(26005)(5660300002)(81166006);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2533;H:DB6PR0802MB2245.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: oQrgBQN7HXfkn8LBdkJbLj2e4KIDbM6VGqShqB5fikog0VTQt3sNf1EYNzS55U+/r1IlD8TF1dod1H9S2JyHfIkqJl+cNQUgeiyI/ZcYZn6si1wgi/mvjErMiPNlQCGWWuC+Ei/v1qQBlvsYG28YuiW147sUvoVCbaoZVrjOj9fO6IHcj/OSfvpJZmYYkuIxuthluQ4oVB/aiWjw59+CbpyxIbmOqPeuDeIu2Ut2NWgdhvNjDbJ38ckFfzPKITTY6wiZ3NUfj7SdEvG5v4e6Nee6T+uJcInZ0phIEvMMwlRmP10U3V2zghO1jzDLisEQ1SboWwEskCpyeZ7T7mHSRD8TLT3Nsn4kuFW09UYNI478M31nlEk73PAubUT1VYAoJvlDbMCugb0PXmFWHZ/3whvhaMphDXvt+UstjlERRIta0TXmY1e1ykQe3j9z/9ZO x-ms-exchange-antispam-messagedata: HBmTyt5bxqwa3ohPSmljJjTTE/V/bq6vugNu0n3KpureYJ33DbveV44wQLrIhuWV1dlLEsQmMU2tiUXCG+GMdTHcwrE3a3/eTXvL2saFR5nZHPJ0XqK/TiNamHq9PRIIzi8TmMcbB3Ffd8NR/Q5YDA== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Tamar.Christina@arm.com; Return-Path: Tamar.Christina@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 91830b47-87e4-4c7f-6fda-08d7aed9ec03 X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg00636.txt.bz2 Hi Feng, This patch (commit a0f6a8cb414b687f22c9011a894d5e8e398c4be0) is causing ICE= s in the GCC and perlbench benchmark in Spec2017. during IPA pass: cp lto1: internal compiler error: in find_more_scalar_values_for_callers_subse= t, at ipa-cp.c:4709 0x1698187 find_more_scalar_values_for_callers_subset ../.././gcc/ipa-cp.c:4709 0x169f7d3 decide_about_value ../.././gcc/ipa-cp.c:5490 0x169fdc3 decide_whether_version_node ../.././gcc/ipa-cp.c:5537 0x169fdc3 ipcp_decision_stage ../.././gcc/ipa-cp.c:5718 0x169fdc3 ipcp_driver ../.././gcc/ipa-cp.c:5901 Please submit a full bug report, Thanks, Tamar > -----Original Message----- > From: gcc-patches-owner@gcc.gnu.org > On Behalf Of Feng Xue OS > Sent: Monday, February 10, 2020 03:29 > To: Martin Jambor ; Jan Hubicka ; > gcc-patches@gcc.gnu.org > Subject: Re: [PATCH V2] Generalized value pass-through for self-recursive > function (ipa/pr93203) >=20 > >> - gcc_checking_assert (item->value); >=20 > > I've been staring at this for quite a while, trying to figure out how > > your patch can put NULL here before I realized it was just a clean-up > > :-) Sending such changes independently or pointing them out in the > > email/ChangeLog makes review easier. >=20 > Ok. I'll add some description on this cleanup on ChangeLog. >=20 > >> @@ -5564,7 +5610,6 @@ decide_whether_version_node (struct > cgraph_node *node) > >> } > >> clone =3D create_specialized_node (node, known_csts, known_cont= exts, > >> aggvals, callers); > >> - info =3D IPA_NODE_REF (node); >=20 > > please either drop this change or change it to: > > > > gcc_checking_assert (info =3D=3D IPA_NODE_REF (node)); >=20 > > this line of code was actually necessary when adding nodes possibly > > invalidated addresses of all summaries - like fast_function_summary > > classes still do. So if we ever decide to use fast summaries we need > > a test to remind us that info address must be obtained again. > Ok. I'm not aware that, will keep the line as original. >=20 > Thanks, > Feng