public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Tamar Christina <Tamar.Christina@arm.com>
To: Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>,
	"gcc-patches@gcc.gnu.org"	<gcc-patches@gcc.gnu.org>
Cc: nd <nd@arm.com>,
	Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>,
	Richard Earnshaw <Richard.Earnshaw@arm.com>,
	"nickc@redhat.com"	<nickc@redhat.com>
Subject: RE: [PATCH 7/9][GCC][Arm] Enable autovectorization of Half float values
Date: Wed, 02 Jan 2019 11:35:00 -0000	[thread overview]
Message-ID: <DB6PR0802MB23099A4C1672AC64D26521F1FF8C0@DB6PR0802MB2309.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <5C1CC821.6040509@foss.arm.com>

Hi Kyrill,

> >
> > Bootstrap and Regtest on aarch64-none-linux-gnu, arm-none-gnueabihf
> > and x86_64-pc-linux-gnu are still on going but previous patch showed no
> regressions.
> >
> 
> Did the testing go okay in the end?

Yes it was clean.

> This looks ok to me but can you provide an example, or better yet, add a test
> that demonstrates this changes?

I've tried, but without the rest of the patch series I can't seem to come with an example that enters the given path.
The failure only happens when the vectorizer tries to vectorize to an unknown size. 

Most simple math operations would have a known size based on the vectorization factor, in any case, I'll hold off this patch then
Until the rest of the series is retried in stage 1.

Thanks,
Tamar

> 
> Thanks,
> Kyrill
> 
> > Ok for trunk?
> >
> > Thanks,
> > Tamar
> >
> > gcc/ChangeLog:
> >
> > 2018-11-11  Tamar Christina  <tamar.christina@arm.com>
> >
> >         * config/arm/arm.c (arm_preferred_simd_mode): Add V4HF and V8HF.
> >
> > --


      reply	other threads:[~2019-01-02 11:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-11 10:27 Tamar Christina
2018-12-21 10:57 ` Tamar Christina
2018-12-21 11:10 ` Kyrill Tkachov
2019-01-02 11:35   ` Tamar Christina [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB6PR0802MB23099A4C1672AC64D26521F1FF8C0@DB6PR0802MB2309.eurprd08.prod.outlook.com \
    --to=tamar.christina@arm.com \
    --cc=Ramana.Radhakrishnan@arm.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=kyrylo.tkachov@foss.arm.com \
    --cc=nd@arm.com \
    --cc=nickc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).