public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Tamar Christina <Tamar.Christina@arm.com>
To: Christophe Lyon <christophe.lyon@linaro.org>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
	nd <nd@arm.com>,	James Greenhalgh <James.Greenhalgh@arm.com>,
	Richard Earnshaw	<Richard.Earnshaw@arm.com>,
	Marcus Shawcroft <Marcus.Shawcroft@arm.com>
Subject: RE: [PATCH][GCC][ARM][AArch64] Testsuite framework changes and execution tests [Patch (8/8)]
Date: Mon, 04 Sep 2017 13:01:00 -0000	[thread overview]
Message-ID: <DB6PR0802MB2309D83DBD83726D7C7E1BE8FF910@DB6PR0802MB2309.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <CAKdteOaqFa=E4uPLosFWJOLaZec5uo=NWHB9Cz8FLcst-0_uJA@mail.gmail.com>

Hi Christophe,

> >
> > gcc/testsuite
> > 2017-09-01  Tamar Christina  <tamar.christina@arm.com>
> >
> >         * lib/target-supports.exp
> >         (check_effective_target_arm_v8_2a_dotprod_neon_ok_nocache):
> New.
> >         (check_effective_target_arm_v8_2a_dotprod_neon_ok): New.
> >         (add_options_for_arm_v8_2a_dotprod_neon): New.
> >         (check_effective_target_arm_v8_2a_dotprod_neon_hw): New.
> >         (check_effective_target_vect_sdot_qi): New.
> >         (check_effective_target_vect_udot_qi): New.
> >         * gcc.target/arm/simd/vdot-exec.c: New.
> 
> Aren't you defining twice P() and ARR() in vdot-exec.c ?
> I'd expect a preprocessor error, did I read too quickly?
>

Yes they are defined twice but they're not redefined, all the definitions
are exactly the same so the pre-processor doesn't care. I can leave only
one if this is confusing.
 
> 
> Thanks,
> 
> Christophe
> 
> >         * gcc.target/aarch64/advsimd-intrinsics/vdot-exec.c: New.
> >         * gcc/doc/sourcebuild.texi: Document arm_v8_2a_dotprod_neon.
> >
> > --

  reply	other threads:[~2017-09-04 13:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-01 13:24 Tamar Christina
2017-09-04 12:40 ` Christophe Lyon
2017-09-04 13:01   ` Tamar Christina [this message]
2017-10-06 12:45     ` Tamar Christina
2017-10-23  9:38       ` Tamar Christina
2017-10-24 15:28       ` James Greenhalgh
2017-10-26  7:21         ` Tamar Christina
2017-10-26  8:12           ` James Greenhalgh
2017-10-26  9:05       ` Kyrill Tkachov
2017-11-15 11:11       ` Kyrill Tkachov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB6PR0802MB2309D83DBD83726D7C7E1BE8FF910@DB6PR0802MB2309.eurprd08.prod.outlook.com \
    --to=tamar.christina@arm.com \
    --cc=James.Greenhalgh@arm.com \
    --cc=Marcus.Shawcroft@arm.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=christophe.lyon@linaro.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).