public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Bin Cheng <Bin.Cheng@arm.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: nd <nd@arm.com>
Subject: [PATCH AArch64]Fix test failure for pr84682-2.c
Date: Fri, 16 Mar 2018 11:43:00 -0000	[thread overview]
Message-ID: <DB6PR0802MB2504BCFAD63BCAA484B5EE8FE7D70@DB6PR0802MB2504.eurprd08.prod.outlook.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]

Hi,
This simple patch fixes test case failure for pr84682-2.c by returning
false on wrong mode rtx in aarch64_classify_address, rather than assert.

Bootstrap and test on aarch64.  Is it OK?

Thanks,
bin

2018-03-16  Bin Cheng  <bin.cheng@arm.com>

	* config/aarch64/aarch64.c (aarch64_classify_address): Return false
	on wrong mode rtx, rather than assert.

[-- Attachment #2: patch-pr84682-2.txt --]
[-- Type: text/plain, Size: 585 bytes --]

diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c
index 07c55b1..8790902 100644
--- a/gcc/config/aarch64/aarch64.c
+++ b/gcc/config/aarch64/aarch64.c
@@ -5674,8 +5674,10 @@ aarch64_classify_address (struct aarch64_address_info *info,
       && (code != POST_INC && code != REG))
     return false;
 
-  gcc_checking_assert (GET_MODE (x) == VOIDmode
-		       || SCALAR_INT_MODE_P (GET_MODE (x)));
+  /* Wrong mode for an address expr.  */
+  if (GET_MODE (x) != VOIDmode
+      && ! SCALAR_INT_MODE_P (GET_MODE (x)))
+    return false;
 
   switch (code)
     {

             reply	other threads:[~2018-03-16 11:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-16 11:43 Bin Cheng [this message]
2018-03-16 11:53 ` Kyrill Tkachov
2018-03-17  9:20   ` Richard Sandiford
2018-03-22 11:11     ` Bin.Cheng
2018-04-24 15:14       ` Bin.Cheng
2018-05-16  8:37       ` Kyrill Tkachov
2018-08-29 15:50         ` Joey Ye
2018-08-29 18:47           ` Richard Sandiford
2018-08-30  1:02             ` Bin.Cheng
2018-08-30 10:21               ` Joey Ye
2018-08-30 10:28                 ` Joey Ye
2018-08-30 12:24                 ` Richard Sandiford
2018-12-12 11:29                   ` Richard Earnshaw (lists)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB6PR0802MB2504BCFAD63BCAA484B5EE8FE7D70@DB6PR0802MB2504.eurprd08.prod.outlook.com \
    --to=bin.cheng@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).