[PATCH][OBVIOUS] Close file on return from verify-intermediate

[PATCH][OBVIOUS] Close file on return from verify-intermediate

[Joey Ye]

[-- Attachment #1: Type: text/plain, Size: 878 bytes --]

This is a fix to an obvious issue in gcov.exp, where proc verify-intermediate returns without closing the open file.

This can be a possible fix to PR85871. gcov-8.C diffs to other gcov testcases that it invokes verify-intermediate. Not closing an open file may result in random failure quietly.

It is only a possible fix as I failed to reproduce the PR85871 random failure in my local machine despite continuous testing of multiple days. So I cannot verify if this patch fixes the regression either.

To verify, https://gcc.gnu.org/ml/gcc-testresults/ need to be watched whether gcov-8 regression will disappear completely one month after this patch committed to trunk.

Tested with make check with no new regressions.

OK to trunk?

testsuite/ChangeLog:
2018-09-05  Joey Ye  <joey.ye@arm.com>

        * lib/gcov.exp (verify-intermediate): Add missing close.

[-- Attachment #2: gcov-20180905.patch --]
[-- Type: application/octet-stream, Size: 360 bytes --]

diff --git a/gcc/testsuite/lib/gcov.exp b/gcc/testsuite/lib/gcov.exp
index 03eb14a3f4f..f35ca59fbe3 100644
--- a/gcc/testsuite/lib/gcov.exp
+++ b/gcc/testsuite/lib/gcov.exp
@@ -133,6 +133,7 @@ proc verify-intermediate { testname testcase file } {
 	fail "$testname expected 'branch:' tag not found"
 	incr failed
     }
+    close $fd
     return $failed
 }
 

Re: [PATCH][OBVIOUS] Close file on return from verify-intermediate

[Mike Stump]

On Sep 5, 2018, at 6:29 AM, Joey Ye <joey.ye@arm.com> wrote:
> This is a fix to an obvious issue in gcov.exp, where proc verify-intermediate returns without closing the open file.
> 
> This can be a possible fix to PR85871. gcov-8.C diffs to other gcov testcases that it invokes verify-intermediate. Not closing an open file may result in random failure quietly.
> 
> It is only a possible fix as I failed to reproduce the PR85871 random failure in my local machine despite continuous testing of multiple days. So I cannot verify if this patch fixes the regression either.
> 
> To verify, https://gcc.gnu.org/ml/gcc-testresults/ need to be watched whether gcov-8 regression will disappear completely one month after this patch committed to trunk.
> 
> Tested with make check with no new regressions.
> 
> OK to trunk?

Ok.

I'm hoping that this doesn't fix that issue, as this change should not cause any change to correctly written code.  if it does fix it, there is at least one more unfortunate thing that should be fixed that remains unidentified.

Re: [PATCH][OBVIOUS] Close file on return from verify-intermediate

[Martin Liška]

On 09/05/2018 03:29 PM, Joey Ye wrote:
> This is a fix to an obvious issue in gcov.exp, where proc verify-intermediate returns without closing the open file.
> 
> This can be a possible fix to PR85871. gcov-8.C diffs to other gcov testcases that it invokes verify-intermediate. Not closing an open file may result in random failure quietly.
> 
> It is only a possible fix as I failed to reproduce the PR85871 random failure in my local machine despite continuous testing of multiple days. So I cannot verify if this patch fixes the regression either.
> 
> To verify, https://gcc.gnu.org/ml/gcc-testresults/ need to be watched whether gcov-8 regression will disappear completely one month after this patch committed to trunk.
> 
> Tested with make check with no new regressions.
> 
> OK to trunk?
> 
> testsuite/ChangeLog:
> 2018-09-05  Joey Ye  <joey.ye@arm.com>
> 
>         * lib/gcov.exp (verify-intermediate): Add missing close.
> 

Hi.

Thanks for the fix, it's obvious. Please install the patch.

Note that gcov-8.C is built multiple times with different -std=* options:

PASS: g++.dg/gcov/gcov-8.C  -std=gnu++98 (test for excess errors)
PASS: g++.dg/gcov/gcov-8.C  -std=gnu++98 execution test
PASS: g++.dg/gcov/gcov-8.C  -std=gnu++98  gcov
PASS: g++.dg/gcov/gcov-8.C  -std=gnu++11 (test for excess errors)
PASS: g++.dg/gcov/gcov-8.C  -std=gnu++11 execution test
PASS: g++.dg/gcov/gcov-8.C  -std=gnu++11  gcov
PASS: g++.dg/gcov/gcov-8.C  -std=gnu++14 (test for excess errors)
PASS: g++.dg/gcov/gcov-8.C  -std=gnu++14 execution test
PASS: g++.dg/gcov/gcov-8.C  -std=gnu++14  gcov

That can cause the collisions seen in the PR.

Martin

Re: [PATCH][OBVIOUS] Close file on return from verify-intermediate

[Joey Ye]

Committed as r264202.

gcov-8 still fails at r264226 according to
https://gcc.gnu.org/ml/gcc-testresults/2018-09/msg01478.html

So it is confirmed that this patch doesn't resolve PR85871, as Mike hoped.

Thanks,
Joey
On Mon, Sep 10, 2018 at 3:04 PM Martin Liška <mliska@suse.cz> wrote:
>
> On 09/05/2018 03:29 PM, Joey Ye wrote:
> > This is a fix to an obvious issue in gcov.exp, where proc verify-intermediate returns without closing the open file.
> >
> > This can be a possible fix to PR85871. gcov-8.C diffs to other gcov testcases that it invokes verify-intermediate. Not closing an open file may result in random failure quietly.
> >
> > It is only a possible fix as I failed to reproduce the PR85871 random failure in my local machine despite continuous testing of multiple days. So I cannot verify if this patch fixes the regression either.
> >
> > To verify, https://gcc.gnu.org/ml/gcc-testresults/ need to be watched whether gcov-8 regression will disappear completely one month after this patch committed to trunk.
> >
> > Tested with make check with no new regressions.
> >
> > OK to trunk?
> >
> > testsuite/ChangeLog:
> > 2018-09-05  Joey Ye  <joey.ye@arm.com>
> >
> >         * lib/gcov.exp (verify-intermediate): Add missing close.
> >
>
> Hi.
>
> Thanks for the fix, it's obvious. Please install the patch.
>
> Note that gcov-8.C is built multiple times with different -std=* options:
>
> PASS: g++.dg/gcov/gcov-8.C  -std=gnu++98 (test for excess errors)
> PASS: g++.dg/gcov/gcov-8.C  -std=gnu++98 execution test
> PASS: g++.dg/gcov/gcov-8.C  -std=gnu++98  gcov
> PASS: g++.dg/gcov/gcov-8.C  -std=gnu++11 (test for excess errors)
> PASS: g++.dg/gcov/gcov-8.C  -std=gnu++11 execution test
> PASS: g++.dg/gcov/gcov-8.C  -std=gnu++11  gcov
> PASS: g++.dg/gcov/gcov-8.C  -std=gnu++14 (test for excess errors)
> PASS: g++.dg/gcov/gcov-8.C  -std=gnu++14 execution test
> PASS: g++.dg/gcov/gcov-8.C  -std=gnu++14  gcov
>
> That can cause the collisions seen in the PR.
>
> Martin