From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61693 invoked by alias); 5 Sep 2018 13:29:52 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 61683 invoked by uid 89); 5 Sep 2018 13:29:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:917, gcov-8.C, UD:gcov-8.C X-HELO: EUR03-DB5-obe.outbound.protection.outlook.com Received: from mail-eopbgr40071.outbound.protection.outlook.com (HELO EUR03-DB5-obe.outbound.protection.outlook.com) (40.107.4.71) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Sep 2018 13:29:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kHEk8HLZomoHsMQc8wMRZThIt0fTwS+Ek4al3m5jMIM=; b=AfQknoJbUfoS4S6WqbOxP/0qQ2HJkWzuayj0fu/U9oIL+THpw6mQxUv7fm5Ns1QZSUGvxbNSjBFRNkR3WLAD2XwFt2NLmh4PLXh3J24fO/75i/XsEujclcerYVarc0Q8EXPxsUCfNXjLuvJroAEFAg4zpdX0KgBOBxRBAE8QTV0= Received: from DB6PR08MB2886.eurprd08.prod.outlook.com (10.175.235.19) by DB6PR08MB2901.eurprd08.prod.outlook.com (10.175.235.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1080.17; Wed, 5 Sep 2018 13:29:46 +0000 Received: from DB6PR08MB2886.eurprd08.prod.outlook.com ([fe80::a578:8279:e012:b25]) by DB6PR08MB2886.eurprd08.prod.outlook.com ([fe80::a578:8279:e012:b25%2]) with mapi id 15.20.1080.020; Wed, 5 Sep 2018 13:29:45 +0000 From: Joey Ye To: "'gcc-patches@gcc.gnu.org'" , "mliska@suse.cz" CC: nd Subject: [PATCH][OBVIOUS] Close file on return from verify-intermediate Date: Wed, 05 Sep 2018 13:29:00 -0000 Message-ID: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Joey.Ye@arm.com; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) Content-Type: multipart/mixed; boundary="_002_DB6PR08MB28860A0AB69E4730F6CEDAD3E0020DB6PR08MB2886eurp_" MIME-Version: 1.0 X-SW-Source: 2018-09/txt/msg00303.txt.bz2 --_002_DB6PR08MB28860A0AB69E4730F6CEDAD3E0020DB6PR08MB2886eurp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 896 This is a fix to an obvious issue in gcov.exp, where proc verify-intermedia= te returns without closing the open file. This can be a possible fix to PR85871. gcov-8.C diffs to other gcov testcas= es that it invokes verify-intermediate. Not closing an open file may result= in random failure quietly. It is only a possible fix as I failed to reproduce the PR85871 random failu= re in my local machine despite continuous testing of multiple days. So I ca= nnot verify if this patch fixes the regression either. To verify, https://gcc.gnu.org/ml/gcc-testresults/ need to be watched wheth= er gcov-8 regression will disappear completely one month after this patch c= ommitted to trunk. Tested with make check with no new regressions. OK to trunk? testsuite/ChangeLog: 2018-09-05=A0 Joey Ye=A0 =A0=A0=A0=A0=A0=A0=A0 * lib/gcov.exp (verify-intermediate): Add missing clo= se. --_002_DB6PR08MB28860A0AB69E4730F6CEDAD3E0020DB6PR08MB2886eurp_ Content-Type: application/octet-stream; name="gcov-20180905.patch" Content-Description: gcov-20180905.patch Content-Disposition: attachment; filename="gcov-20180905.patch"; size=360; creation-date="Wed, 05 Sep 2018 11:20:35 GMT"; modification-date="Wed, 05 Sep 2018 11:26:43 GMT" Content-Transfer-Encoding: base64 Content-length: 488 ZGlmZiAtLWdpdCBhL2djYy90ZXN0c3VpdGUvbGliL2djb3YuZXhwIGIvZ2Nj L3Rlc3RzdWl0ZS9saWIvZ2Nvdi5leHAKaW5kZXggMDNlYjE0YTNmNGYuLmYz NWNhNTlmYmUzIDEwMDY0NAotLS0gYS9nY2MvdGVzdHN1aXRlL2xpYi9nY292 LmV4cAorKysgYi9nY2MvdGVzdHN1aXRlL2xpYi9nY292LmV4cApAQCAtMTMz LDYgKzEzMyw3IEBAIHByb2MgdmVyaWZ5LWludGVybWVkaWF0ZSB7IHRlc3Ru YW1lIHRlc3RjYXNlIGZpbGUgfSB7CiAJZmFpbCAiJHRlc3RuYW1lIGV4cGVj dGVkICdicmFuY2g6JyB0YWcgbm90IGZvdW5kIgogCWluY3IgZmFpbGVkCiAg ICAgfQorICAgIGNsb3NlICRmZAogICAgIHJldHVybiAkZmFpbGVkCiB9CiAK --_002_DB6PR08MB28860A0AB69E4730F6CEDAD3E0020DB6PR08MB2886eurp_--