From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2043.outbound.protection.outlook.com [40.107.21.43]) by sourceware.org (Postfix) with ESMTPS id D18ED3857C54 for ; Mon, 21 Sep 2020 11:00:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D18ED3857C54 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Kyrylo.Tkachov@arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bJDoYH9G5RTxgkK0CXw5nVFAUhLvMaoXQnkaZaQ/BCg=; b=VwT6qsFCFb8/TbxHEv5613BgP9AMcXU3jeJTRrtGGiLQleQp0/mtW/6UpqiDvaVwd4EFovZiCefvOsSMj8SfoNz0U4ww6yv3TJYzQc1em4PkYdvv5c5JL4qVv/NBini5ND5hhgJmTVc1XKz07LFDTZSmd1SxbB+TP/gSbtCswc4= Received: from DB8P191CA0020.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::30) by VI1PR08MB3695.eurprd08.prod.outlook.com (2603:10a6:803:c4::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.17; Mon, 21 Sep 2020 11:00:41 +0000 Received: from DB5EUR03FT064.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:130:cafe::97) by DB8P191CA0020.outlook.office365.com (2603:10a6:10:130::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.11 via Frontend Transport; Mon, 21 Sep 2020 11:00:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;gcc.gnu.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT064.mail.protection.outlook.com (10.152.21.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.15 via Frontend Transport; Mon, 21 Sep 2020 11:00:40 +0000 Received: ("Tessian outbound e8cdb8c6f386:v64"); Mon, 21 Sep 2020 11:00:40 +0000 X-CR-MTA-TID: 64aa7808 Received: from 4a88a917ff64.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4D7EF4B1-4BD9-4DF0-AE5A-67005B2C0AA9.1; Mon, 21 Sep 2020 11:00:35 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4a88a917ff64.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 21 Sep 2020 11:00:35 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cAjed9hijhJg/POETr3Vo7rsgJxA09eJeGmQI2C84Z1bqmiloKqi7HxJ6T8gHKIdYJn/h0Ts9Sq6SpRu2nTGmd9Yo3d7aZDRDId84xYjkzpaQUersMwaq37Q61QGZK4g4q/2mgwmivipz1KwlvNe0z15sn7jTFZcwxr5j5CYNMyi8FeZ3ooeap2oFCZ6GL5S/hJHXCQAY0vm0ipW4EPzi1qZabwwRvK1ETqOPdpXwJgQ+5Ate7iueRLgK1I4I5eiD+1UQjvP1Ya+RPypf8fnq8YQDAUUFkudbissSXEdpB+Xn1cyI20Ah69fDc/1xlq/T3AnQxuhjNeQRcJ9YyR7pQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bJDoYH9G5RTxgkK0CXw5nVFAUhLvMaoXQnkaZaQ/BCg=; b=AFyU8v0+gceo3/Dg5nVwCJDPcx0WuQXDbp7ou2pGIWIEuZKxJxPEp6C0l9w3+7msf8A0FeGXF9seQt35lbiSI9u42s9hSikLIvEBpxbZLUwsv41tQPVltfXhMarlzCigtFxzAuudF4ca7hLWZvk8rAxKLWh1Okf6jNal+/11o2VMODGOl8OqN96fOKmt/jDWPza41VTkAKDrlacdLCyXMtPLpoSWwk0BgCzy+rHHLbbUwHpu9MMe96+Uh+yIhiAspYDsieh+p2Ju1OUMnl9x6FvsuySL+hqGn3B9QHWx0KlLOhGmaQl8jZ9AIq6RytDwsXDNX13aC8UbKcO4TRDJng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bJDoYH9G5RTxgkK0CXw5nVFAUhLvMaoXQnkaZaQ/BCg=; b=VwT6qsFCFb8/TbxHEv5613BgP9AMcXU3jeJTRrtGGiLQleQp0/mtW/6UpqiDvaVwd4EFovZiCefvOsSMj8SfoNz0U4ww6yv3TJYzQc1em4PkYdvv5c5JL4qVv/NBini5ND5hhgJmTVc1XKz07LFDTZSmd1SxbB+TP/gSbtCswc4= Received: from DB7PR08MB3002.eurprd08.prod.outlook.com (2603:10a6:5:20::25) by DB6PR0801MB1733.eurprd08.prod.outlook.com (2603:10a6:4:37::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.19; Mon, 21 Sep 2020 11:00:33 +0000 Received: from DB7PR08MB3002.eurprd08.prod.outlook.com ([fe80::9ce1:1ded:d7a5:af85]) by DB7PR08MB3002.eurprd08.prod.outlook.com ([fe80::9ce1:1ded:d7a5:af85%7]) with mapi id 15.20.3391.024; Mon, 21 Sep 2020 11:00:32 +0000 From: Kyrylo Tkachov To: Richard Sandiford , Andrea Corallo CC: Richard Earnshaw , nd , "gcc-patches@gcc.gnu.org" Subject: RE: [PATCH] aarch64: Do not alter value on a force_reg returned rtx expanding __jcvt Thread-Topic: [PATCH] aarch64: Do not alter value on a force_reg returned rtx expanding __jcvt Thread-Index: AQHWkAJoEGcnJdPQP02RuL4+YP37bKly7HRsgAAAMAA= Date: Mon, 21 Sep 2020 11:00:32 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: FC8EAA2874EBD2419A3E7E951AECCC49.0 x-checkrecipientchecked: true Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [217.140.99.251] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: febec55e-0c8d-47cd-ad53-08d85e1d945f x-ms-traffictypediagnostic: DB6PR0801MB1733:|VI1PR08MB3695: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: xDErFXGZdyAvfI2Oq0RBShtvYAXgUWUO3UX4Ammrj8X8o3VmdOikgpyQDPjmF3cVWdo7QjdfKIpQSRdB8456vdfZD7CaEq5VXL/gfjRyM6B9mnlxmiePzoZOXUBGW0JoGYNafn+LsFn489tkEu8Fm5Ugdycj9c0ocujMH33ihOktOGdxnTmFoT+AjaUmV4sxOQj/KgRBPDR/zSg0W5Wf31UlA40kJSUat9BEBrvRF9zZ70Xq5w4jVbeJSRv/1+2IG58lch0B3MSfQTXQvdBzkCjxMMtygpWDekmPbquxcKJW5X0jKw3I967Ddx7hjfqNeu9sruxIjTEDz6eevCWJVg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR08MB3002.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(376002)(346002)(136003)(39860400002)(396003)(8676002)(4326008)(83380400001)(54906003)(64756008)(316002)(110136005)(86362001)(52536014)(76116006)(66556008)(66446008)(66946007)(71200400001)(66476007)(5660300002)(186003)(26005)(6636002)(6506007)(7696005)(53546011)(478600001)(33656002)(2906002)(55016002)(8936002)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: MURsgyc7aWGS5Cb2wL7rrMglrQYx46p+emphutcfckCxSNVlWKmrpjrfbqxt819bUvsg7cs42Og/5J8zpKcPsxcTZ58+qVe0E0vsBOvmFo0PylGg+PGqakBs4tzlASGmE7UAjhKv4XKCL+JadwAhjiAqMe13yOaJt9vhy5bbFJXLHQHlIXeU8opBg26oGRWiMngFdwCd6bnV97ucf5kxmrl13nJzOf28sOhoLdxaOhfa+BbKuucDeKAWjU9UAzY7a7htexmtn401rDlyGLBIvIXzVVGbDASrKTmV7XPo34NYEQnT8svAp6XLaAGlmxwWps5B5vMJcV8xvO7Fr7Dm+ssy6lOb0fe5uv7WIiFL38beaV39r/uolsBOs5q0G/FXWAxvxBSAd1v6FhgNSJqBDLStBr0uFjhD9mrhLvFAPjnFDRxAU79vGdOH47Lf0mlINrC1TsuWIa4SwH6h8ZGFa0h/Irq799UwfG88Z82Ntbx3gJbXuovRYMxDI037N9BdZTlwBVkZfnPw1n8PupDtBVM/1yfVRw2fGVdFeOvY68zm+weoHz6HVIbGGhWXWzTW840kjE0zCeJ5HEnLfGoL40cMoy+cr4PeEP76+85J/Xc9iHnFe6+qtX7/YmIIwf1Hyb4aWHYzuQ5fZ0J7RFDEcg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1733 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: cff7e45d-33e2-4574-d24a-08d85e1d8f97 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CEuOlpa60QAF0lkbucs9SYfSMXWsEXsIW8ES8PHhjTyISV0mcoC7nChyWUVvlKeSzfhCD7Uke6seUzSnpJQV3kxJId8BvIGVYuGD6uZau2vXdb2MGVJFEmd4lpR0Fefu0tgqf4EcrSzCBPLBRfQz9KhY5CNoqouXS852NrevkNk7vnf6So1lkAvQjF+Hk4vEgu2UQsivrXBAIHf7Am9NllzMjwpRgZlO8Y70bp7ISd8hPyOl6lHmDAhGIot2PL938asPm6T5rJlN2M0uX2TpZgvz+OMp1t4ROtWMEr41W01n3bLnQZWzsj1UE/ksrVQ4qa/vCKik5i2V1ov/2IAJOIR++TOqWpJKL/f4gBmk8isrMsBnWPirqIUFcQFrttsRJ7f45GM94LYjbOPAZSyRXg== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(396003)(39860400002)(136003)(376002)(346002)(46966005)(26005)(2906002)(70206006)(86362001)(186003)(336012)(55016002)(478600001)(70586007)(4326008)(83380400001)(8936002)(53546011)(6506007)(9686003)(82310400003)(52536014)(316002)(7696005)(81166007)(33656002)(5660300002)(82740400003)(47076004)(54906003)(110136005)(6636002)(8676002)(356005); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2020 11:00:40.9216 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: febec55e-0c8d-47cd-ad53-08d85e1d945f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3695 X-Spam-Status: No, score=-15.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Sep 2020 11:00:49 -0000 Hi Andrea, > -----Original Message----- > From: Gcc-patches On Behalf Of > Richard Sandiford > Sent: 21 September 2020 11:58 > To: Andrea Corallo > Cc: Richard Earnshaw ; nd ; > gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] aarch64: Do not alter value on a force_reg returned = rtx > expanding __jcvt >=20 > Andrea Corallo writes: > > Hi all, > > > > From the `force_reg` description comment I see the returned register > > should not be modified, thus IIUC should not be used as a GEN_FCN > > target. > > > > Assuming my interpretation is correct this fix this case inside > > `aarch64_general_expand_builtin` while expanding expanding the > > `__jcvt` intrinsic. If is not the case please discard. >=20 > Good catch. Can you please also backport it to the appropriate branches as well after s= ome time on trunk. Thanks, Kyrill >=20 > > Regtested and bootsraped on aarch64-linux-gnu. > > > > Andrea > > > > From 403ad66b8f9c108d7f38b406ed1afcb603b7e25f Mon Sep 17 00:00:00 > 2001 > > From: Andrea Corallo > > Date: Thu, 17 Sep 2020 17:17:52 +0100 > > Subject: [PATCH] aarch64: Do not alter value on a force_reg returned rt= x > > expanding __jcvt > > > > 2020-09-17 Andrea Corallo > > > > * config/aarch64/aarch64-builtins.c > > (aarch64_general_expand_builtin): Use expand machinery not to > > alter the value of an rtx returned by force_reg. >=20 > OK, thanks. >=20 > Richard >=20 > > --- > > gcc/config/aarch64/aarch64-builtins.c | 16 ++++++++-------- > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > > diff --git a/gcc/config/aarch64/aarch64-builtins.c > b/gcc/config/aarch64/aarch64-builtins.c > > index 4f33dd936c7..b787719cf5e 100644 > > --- a/gcc/config/aarch64/aarch64-builtins.c > > +++ b/gcc/config/aarch64/aarch64-builtins.c > > @@ -2128,14 +2128,14 @@ aarch64_general_expand_builtin (unsigned int > fcode, tree exp, rtx target, > > return target; > > > > case AARCH64_JSCVT: > > - arg0 =3D CALL_EXPR_ARG (exp, 0); > > - op0 =3D force_reg (DFmode, expand_normal (arg0)); > > - if (!target) > > - target =3D gen_reg_rtx (SImode); > > - else > > - target =3D force_reg (SImode, target); > > - emit_insn (GEN_FCN (CODE_FOR_aarch64_fjcvtzs) (target, op0)); > > - return target; > > + { > > + expand_operand ops[2]; > > + create_output_operand (&ops[0], target, SImode); > > + op0 =3D expand_normal (CALL_EXPR_ARG (exp, 0)); > > + create_input_operand (&ops[1], op0, DFmode); > > + expand_insn (CODE_FOR_aarch64_fjcvtzs, 2, ops); > > + return ops[0].value; > > + } > > > > case AARCH64_SIMD_BUILTIN_FCMLA_LANEQ0_V2SF: > > case AARCH64_SIMD_BUILTIN_FCMLA_LANEQ90_V2SF: