From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2067.outbound.protection.outlook.com [40.107.22.67]) by sourceware.org (Postfix) with ESMTPS id 368813857C71 for ; Fri, 24 Jul 2020 09:16:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 368813857C71 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Kyrylo.Tkachov@arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bLJKGGy8KQ4g99ae856M8jjf7tdmJV3z0FOjLtzX1t0=; b=s1lP7gOvCSH7oRbUWkAspeEdyNsJGUyL8FA0bRwzhsVbB+NyfuZFfCh3Q1s1/n9A5C8a+njP5ufbMhmew+gCbxYRzHqV+z4mBu2m2wuuG11UNYTgFHVpbHsRruRCP/S+390fVWsMe+BUIqFnZorigF6/gEo/iZcKlibWO/KKmec= Received: from AM0PR01CA0156.eurprd01.prod.exchangelabs.com (2603:10a6:208:aa::25) by AM0PR08MB3826.eurprd08.prod.outlook.com (2603:10a6:208:105::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.21; Fri, 24 Jul 2020 09:15:59 +0000 Received: from AM5EUR03FT029.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:aa:cafe::c8) by AM0PR01CA0156.outlook.office365.com (2603:10a6:208:aa::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.20 via Frontend Transport; Fri, 24 Jul 2020 09:15:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;gcc.gnu.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT029.mail.protection.outlook.com (10.152.16.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.10 via Frontend Transport; Fri, 24 Jul 2020 09:15:58 +0000 Received: ("Tessian outbound 8f45de5545d6:v62"); Fri, 24 Jul 2020 09:15:58 +0000 X-CR-MTA-TID: 64aa7808 Received: from e4439204d01a.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 03FEFBA1-54CC-4CE1-9099-B2C722EE35FA.1; Fri, 24 Jul 2020 09:15:53 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e4439204d01a.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 24 Jul 2020 09:15:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZQIKKZA7N6WU1qpu6HD/shflsi8hvoQCoT25tR6LNtIh8pMtcrRi7x9yxVvvsZzGBYFjHmMQw7j+oRv3YO3XxUSpIV9Z3zI9pS1MoM/S9cTxdJ5+/aXopDCztl4bRw1zlyJJLpQOUCybGqj4lUpIXzh8slW8+7i26neIYB2F+QPu9S7PwEMnX2XlVNHeKPzepRuhmx+bTb0YhaM2XBf0k+HwOZro0FMkC+pGoAcnERwClcYmpzwgkLhMynMV+jN6Q0XNX0CbSWysPoWmFx4WlEBgt4i9fsvCksgWtCVWg1zr31xUJttsCQ9mK8I15tKBIxTpdMUDIaSNea4uDucLdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bLJKGGy8KQ4g99ae856M8jjf7tdmJV3z0FOjLtzX1t0=; b=K/dPC00wa1F26VL7DLwnpBYXn5OAPRM/WZjmHrAIBfaW2Yr1hYo2ZEv0BkNlzcBOC9rfVz1jWlH/pt2YHzPle8d7vY1S8wyBQG2DU4+thl/9I/RuKJK+DjezTCicYinqoR+cU8+RCa2yy0d0a2MmcqIrXmf2L3tGxbSkieR21fQsgidxDf7J6x7CLwL8O/5Z+T2HsmOfvPeBI5VPldxijdQE4mv94XV+s0Pb3DUYjABHwAyqbnpq6OH9NQah9qJNGvi8Zo62N14BPgFOgkragB9+F/oXEdqROTnolmShmIbvHGMo/3HhD/TeZvuwnLbo+O21cy7ZqLRm50Bof8M9XQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bLJKGGy8KQ4g99ae856M8jjf7tdmJV3z0FOjLtzX1t0=; b=s1lP7gOvCSH7oRbUWkAspeEdyNsJGUyL8FA0bRwzhsVbB+NyfuZFfCh3Q1s1/n9A5C8a+njP5ufbMhmew+gCbxYRzHqV+z4mBu2m2wuuG11UNYTgFHVpbHsRruRCP/S+390fVWsMe+BUIqFnZorigF6/gEo/iZcKlibWO/KKmec= Received: from DB7PR08MB3002.eurprd08.prod.outlook.com (2603:10a6:5:20::25) by DB8PR08MB5515.eurprd08.prod.outlook.com (2603:10a6:10:11f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.24; Fri, 24 Jul 2020 09:15:52 +0000 Received: from DB7PR08MB3002.eurprd08.prod.outlook.com ([fe80::7953:31a2:720e:82d2]) by DB7PR08MB3002.eurprd08.prod.outlook.com ([fe80::7953:31a2:720e:82d2%4]) with mapi id 15.20.3195.028; Fri, 24 Jul 2020 09:15:52 +0000 From: Kyrylo Tkachov To: Szabolcs Nagy , "gcc-patches@gcc.gnu.org" Subject: RE: [PATCH 1/2] aarch64: add PAC GNU property note to libgcc lse.S Thread-Topic: [PATCH 1/2] aarch64: add PAC GNU property note to libgcc lse.S Thread-Index: AQHWYQ2p0BCjqiV+d0Opjq8Fym4KDakWc95g Date: Fri, 24 Jul 2020 09:15:51 +0000 Message-ID: References: <20200723162337.10248-1-szabolcs.nagy@arm.com> In-Reply-To: <20200723162337.10248-1-szabolcs.nagy@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 420e1736-cbe8-4c3a-b38c-1551cf3ade84.1 x-checkrecipientchecked: true Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [80.5.218.175] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 31ceba8f-016e-474d-1e79-08d82fb22d98 x-ms-traffictypediagnostic: DB8PR08MB5515:|AM0PR08MB3826: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: CNJbKbg9DBjELNo6NKkMHNst9kTQ2yw5zAhJiOiDmTtBsqhTYUgt198CXARAhUYBvIaYdioofFK8AfCB7RPT5sqAZSnt7zb5t+Jc0TWxBReFWTtZU/EKDNPkK6+qBz9nqxOz8XfC7JuadpnXaNiQjYq5w8b1riPOBE++xbzFhi1GX1NturBqiwdcUNArzpccTtcoDCHVOrap49kXjNSimglUeaNGzGTm1jJXfQ/gRFRiA4slOwyz2ST3OmFqb2AkOajHcq/iDC3lpfGbTNYpyJwsSBnLx3eKt0SrDCXm5SxBwCK1j3IQkGUwV7Noc/BA X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR08MB3002.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(376002)(396003)(39860400002)(366004)(136003)(186003)(64756008)(8936002)(2906002)(66476007)(83380400001)(66556008)(478600001)(5660300002)(66446008)(7696005)(52536014)(8676002)(26005)(33656002)(9686003)(86362001)(71200400001)(53546011)(110136005)(55016002)(66946007)(6506007)(316002)(76116006); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 6I0J5xzae0STvg584SC3iJb0JSULgrPkKokWULiviv/LEbfKugazrnpiVgzQZBkWJ5zjaX829hHgcHd80ArvVTReJyMPtDPxWTf9pth5IWlHcPECo2kNO2qFPQ8pCOnTZGVtuVkQtDjVdTSwiXFTmK5Dlq2/Mc0QdNhLf2niEeaga8mivrBRqTwwiJqfWDPOyCroUSVVob7hTqNYNk9i/fTyMFme0sLVIgsK3cSr01+pcR85I72zmII4dY712Q/Qg4ClhrAGuMv7ydpp8LYQfuLEAC3EuxWSBGZepWLy70wZJdGDvknwEIh+opapRau2FMHcJS1UiYl6OvyrGbi7126UTTQzO+G9/AfBBy5GUBz3KzfoFYKeyLx40qZ1NGOfrMEs+O5yCv68zUxI/6ulxkdUSfIne7m2Yit7AESGp8YFG5EvpE/LnP90s5o7t2XOz7MWX1iOMSDjkcPuOOKffaG7rIjSTVywahbFPKQmurM= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5515 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 15f3fa95-7e28-4339-4f20-08d82fb22995 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cG5FEujhDloi0KCtRb6aIRqdGC5RGNMqKFqsyIhea6SZMoigsCbSiUTwtrfLtVuPuYFjeqgxZpk7CKle/O3bNNv/ze8am8Ky33JWOfVdWLnijnAokwm/fKgQPBwM516Eyv8rFYvgkdCVgD0O98dfz5e18xV3RHgsJ2I1WbFf1OfXIUWAJBUmcJCQYwTwI3zf1EX2/R+5sBgcXwK/x7gsUb9ffL1ZBtMGauN7rcgwuyhjVtBe6F8Ovfs4+n8bgn9qMvpAsUUbQAEI9Nmr72WF1IkBDbX/1jXpMRq5wyobOVTaVQslrpLrmeT4LyHiQsbO07LOeqG8RxuLdnLa4HwEGgd8pIpIBglumboyRYeDpGzlG4GMFcdvxrIUAoOtYu8DSf9x6kOtSPZO72j+S3iRxQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(396003)(376002)(136003)(39860400002)(346002)(46966005)(70206006)(70586007)(478600001)(52536014)(36906005)(5660300002)(110136005)(33656002)(316002)(336012)(86362001)(8936002)(356005)(9686003)(55016002)(2906002)(82310400002)(81166007)(47076004)(82740400003)(186003)(7696005)(8676002)(6506007)(83380400001)(53546011)(26005); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2020 09:15:58.7973 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 31ceba8f-016e-474d-1e79-08d82fb22d98 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3826 X-Spam-Status: No, score=-16.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jul 2020 09:16:03 -0000 Hi Szabolcs, > -----Original Message----- > From: Szabolcs Nagy > Sent: 23 July 2020 17:24 > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov > Subject: [PATCH 1/2] aarch64: add PAC GNU property note to libgcc lse.S >=20 > This note is not used anywhere currently but it is supposed to mark > objects if the return address is protected with PAC on the stack. > Since lse.S only has leaf functions the return address is never > saved on the stack so we can add the note. >=20 > The note is only added if pac-ret is enabled because it can cause > problems with old linkers and we don't have checks for that. This > can be changed later to be unconditional, for now it is consistent > with how gcc generates the notes. >=20 Ok. Thanks, Kyrill > libgcc/ChangeLog: >=20 > * config/aarch64/lse.S: Add PAC property note. > --- > libgcc/config/aarch64/lse.S | 17 +++++++++++++++-- > 1 file changed, 15 insertions(+), 2 deletions(-) >=20 > diff --git a/libgcc/config/aarch64/lse.S b/libgcc/config/aarch64/lse.S > index 64691c601c1..aa3e3dc4f2d 100644 > --- a/libgcc/config/aarch64/lse.S > +++ b/libgcc/config/aarch64/lse.S > @@ -283,6 +283,19 @@ ENDFN NAME(LDNM) > #define FEATURE_1_BTI 1 > #define FEATURE_1_PAC 2 >=20 > +/* Supported features based on the code generation options. */ > +#if defined(__ARM_FEATURE_BTI_DEFAULT) > +# define BTI_FLAG FEATURE_1_BTI > +#else > +# define BTI_FLAG 0 > +#endif > + > +#if __ARM_FEATURE_PAC_DEFAULT & 3 > +# define PAC_FLAG FEATURE_1_PAC > +#else > +# define PAC_FLAG 0 > +#endif > + > /* Add a NT_GNU_PROPERTY_TYPE_0 note. */ > #define GNU_PROPERTY(type, value) \ > .section .note.gnu.property, "a"; \ > @@ -300,7 +313,7 @@ ENDFN NAME(LDNM) > .section .note.GNU-stack, "", %progbits >=20 > /* Add GNU property note if built with branch protection. */ > -# ifdef __ARM_FEATURE_BTI_DEFAULT > -GNU_PROPERTY (FEATURE_1_AND, FEATURE_1_BTI) > +# if (BTI_FLAG|PAC_FLAG) !=3D 0 > +GNU_PROPERTY (FEATURE_1_AND, BTI_FLAG|PAC_FLAG) > # endif > #endif > -- > 2.17.1