From: Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: Richard Sandiford <Richard.Sandiford@arm.com>
Subject: RE: [PATCH] rtl-ssa: Include memmodel.h before tm_p.h
Date: Thu, 17 Dec 2020 13:41:21 +0000 [thread overview]
Message-ID: <DB7PR08MB30026D82AA3C14E2199D453093C40@DB7PR08MB3002.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <yddwnxgyb12.fsf@CeBiTec.Uni-Bielefeld.DE>
Hi Rainer,
> -----Original Message-----
> From: Gcc-patches <gcc-patches-bounces@gcc.gnu.org> On Behalf Of
> Rainer Orth
> Sent: 17 December 2020 10:36
> To: gcc-patches@gcc.gnu.org
> Cc: Richard Sandiford <Richard.Sandiford@arm.com>
> Subject: [PATCH] rtl-ssa: Include memmodel.h before tm_p.h
>
> The RTL SSA merge broke SPARC bootstrap:
>
> In file included from ./tm_p.h:4,
> from /vol/gcc/src/hg/master/local/gcc/rtl-ssa.h:54,
> from /vol/gcc/src/hg/master/local/gcc/fwprop.c:29:
> /vol/gcc/src/hg/master/local/gcc/config/sparc/sparc-protos.h:45:47: error:
> use of enum 'memmodel' without previous declaration
> extern void sparc_emit_membar_for_model (enum memmodel, int, int);
> ^~~~~~~~
>
> and similarly in rtl-ssa/functions.cc, rtl-ssa/changes.cc, and
> rtl-ssa/insns.cc.
>
> Fixed by moving the memmove.h include in rtl-ssa.h before tm_p.h.
>
> Tested on sparc-sun-solaris2.11 and i386-pc-solaris2.11 (both into stage
> 3 now, so the compilation error is gone).
>
> Ok for master?
AFAIK simple patches like this that fix build/bootstrap are viewed as obvious and can be committed.
I hope I'm not wrong 😊
Thanks,
Kyrill
>
> Rainer
>
> --
> -----------------------------------------------------------------------------
> Rainer Orth, Center for Biotechnology, Bielefeld University
>
>
> 2020-12-17 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
>
> gcc:
> * rtl-ssa.h: Include memmodel.h before tm_p.h.
next prev parent reply other threads:[~2020-12-17 13:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 10:36 Rainer Orth
2020-12-17 13:41 ` Kyrylo Tkachov [this message]
2020-12-17 13:49 ` Rainer Orth
2020-12-17 14:04 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR08MB30026D82AA3C14E2199D453093C40@DB7PR08MB3002.eurprd08.prod.outlook.com \
--to=kyrylo.tkachov@arm.com \
--cc=Richard.Sandiford@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).