public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>
To: Srinath Parvathaneni <Srinath.Parvathaneni@arm.com>,
	"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: RE: [PATCH][GCC] arm: Fix the warning -mcpu=cortex-m55 conflicting with -march=armv8.1-m.main (pr97327).
Date: Fri, 16 Oct 2020 13:51:26 +0000	[thread overview]
Message-ID: <DB7PR08MB300273B67A8A473961444DA993030@DB7PR08MB3002.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <VI1PR0802MB2368142FD81EF0146E1A89989B030@VI1PR0802MB2368.eurprd08.prod.outlook.com>



> -----Original Message-----
> From: Srinath Parvathaneni <Srinath.Parvathaneni@arm.com>
> Sent: 16 October 2020 14:21
> To: gcc-patches@gcc.gnu.org
> Cc: Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>
> Subject: [PATCH][GCC] arm: Fix the warning -mcpu=cortex-m55 conflicting
> with -march=armv8.1-m.main (pr97327).
> 
> Hello,
> 
> This patch fixes (PR97327) the warning -mcpu=cortex-m55 conflicts with -
> march=armv8.1-m.main
> for -mfloat-abi=soft by adding the isa_bit_mve_float to clearing FP bit list.
> 
> The following combination are fixed with this patch:
> $ cat bug.c
> int main(){
> return 0;
> }
> 
> $ arm-none-eabi-gcc -mcpu=cortex-m55 -mfloat-abi=soft bug.c -c
> $ arm-none-eabi-gcc -mcpu=cortex-m55 -mfloat-abi=soft -march=armv8.1-
> m.main+mve bug.c -c
> 
> Before this patch for above combinations:
> cc1: warning: switch '-mcpu=cortex-m55' conflicts with '-march=armv8.1-
> m.main' switch
> 
> After this patch for above combinations no warning/errors.
> 
> Regression tested on arm-none-eabi and found no regressions.
> 
> Ok for master? Ok for GCC-10 branch?

Ok for master and for the branch next week if testing shows no problem.
Thanks,
Kyrill

> 
> Regards,
> Srinath.
> 
> gcc/ChangeLog:
> 
> 2020-10-16  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
> 
> 	PR target/97327
> 	* config/arm/arm.c (fp_bitlist): Add isa_bit_mve_float to FP bits
> array.
> 
> gcc/testsuite/ChangeLog:
> 
> 	PR target/97327
> 	* gcc.target/arm/mve/intrinsics/pr97327.c: New test.
> 
> 
> ###############     Attachment also inlined for ease of reply
> ###############
> 
> 
> diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c
> index
> 0b8c5fa074d32e9ced107d1917323479c19d4c4e..dfadaca6fdfe16cfd5b6531
> ae8564d01063bbe77 100644
> --- a/gcc/config/arm/arm.c
> +++ b/gcc/config/arm/arm.c
> @@ -3429,8 +3429,9 @@ arm_option_override (void)
>  {
>    static const enum isa_feature fpu_bitlist_internal[]
>      = { ISA_ALL_FPU_INTERNAL, isa_nobit };
> +  /* isa_bit_mve_float is also part of FP bit list for arch v8.1-m.main.  */
>    static const enum isa_feature fp_bitlist[]
> -    = { ISA_ALL_FP, isa_nobit };
> +    = { ISA_ALL_FP, isa_bit_mve_float, isa_nobit };
>    static const enum isa_feature quirk_bitlist[] = { ISA_ALL_QUIRKS, isa_nobit};
>    cl_target_option opts;
> 
> diff --git a/gcc/testsuite/gcc.target/arm/mve/intrinsics/pr97327.c
> b/gcc/testsuite/gcc.target/arm/mve/intrinsics/pr97327.c
> new file mode 100644
> index
> 0000000000000000000000000000000000000000..8f6d36063811607623048
> c0a95920b29e43f4c39
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/arm/mve/intrinsics/pr97327.c
> @@ -0,0 +1,8 @@
> +/* { dg-require-effective-target arm_v8_1m_mve_fp_ok } */
> +/* { dg-skip-if "Incompatible float ABI" { *-*-* } { "-mfloat-abi=hard" } { "" } }
> */
> +/* { dg-additional-options "-mcpu=cortex-m55 -mfloat-abi=soft -
> mfpu=auto -Werror" } */
> +
> +int main ()
> +{
> +  return 0;
> +}


      reply	other threads:[~2020-10-16 13:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-16 13:21 Srinath Parvathaneni
2020-10-16 13:51 ` Kyrylo Tkachov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB7PR08MB300273B67A8A473961444DA993030@DB7PR08MB3002.eurprd08.prod.outlook.com \
    --to=kyrylo.tkachov@arm.com \
    --cc=Srinath.Parvathaneni@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).