From: Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>
To: Christophe Lyon <christophe.lyon@linaro.org>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: RE: testsuite: [aarch64] Fix aarch64/advsimd-intrinsics/v{trn, uzp, zip}_half.c
Date: Fri, 25 Sep 2020 10:39:27 +0000 [thread overview]
Message-ID: <DB7PR08MB30028EACCA3572A163B3594693360@DB7PR08MB3002.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <CAKdteOZ4OYdsqTXkRYDnd2WghWqORPH6AzzfT=HCM6jhEPP-Vw@mail.gmail.com>
> -----Original Message-----
> From: Gcc-patches <gcc-patches-bounces@gcc.gnu.org> On Behalf Of
> Christophe Lyon via Gcc-patches
> Sent: 25 September 2020 11:35
> To: gcc Patches <gcc-patches@gcc.gnu.org>; Kyrill Tkachov
> <kyrylo.tkachov@foss.arm.com>
> Subject: testsuite: [aarch64] Fix aarch64/advsimd-intrinsics/v{trn, uzp,
> zip}_half.c
>
> Since r11-3402 (g:65c9878641cbe0ed898aa7047b7b994e9d4a5bb1), the
> vtrn_half, vuzp_half and vzip_half started failing with
>
> vtrn_half.c:76:17: error: redeclaration of 'vector_float64x2' with no linkage
> vtrn_half.c:77:17: error: redeclaration of 'vector2_float64x2' with no linkage
> vtrn_half.c:80:17: error: redeclaration of 'vector_res_float64x2' with
> no linkage
>
> This is because r11-3402 now always declares float64x2 variables for
> aarch64, leading to a duplicate declaration in these testcases.
>
> The fix is simply to remove these now useless declarations.
>
> These tests are skipped on arm*, so there is no impact on that target.
>
> 2020-09-25 Christophe Lyon <christophe.lyon@linaro.org>
>
> gcc/testsuite/
> PR target/71233
> * gcc.target/aarch64/advsimd-intrinsics/vtrn_half.c: Remove
> declarations of vector, vector2, vector_res for float64x2 type.
> * gcc.target/aarch64/advsimd-intrinsics/vuzp_half.c: Likewise.
> * gcc.target/aarch64/advsimd-intrinsics/vzip_half.c: Likewise.
>
> OK?
Oops, yes ok.
Thank you for catching these,
Kyrill
prev parent reply other threads:[~2020-09-25 10:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 10:35 Christophe Lyon
2020-09-25 10:39 ` Kyrylo Tkachov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR08MB30028EACCA3572A163B3594693360@DB7PR08MB3002.eurprd08.prod.outlook.com \
--to=kyrylo.tkachov@arm.com \
--cc=christophe.lyon@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).