From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20043.outbound.protection.outlook.com [40.107.2.43]) by sourceware.org (Postfix) with ESMTPS id 66F79384402F for ; Mon, 26 Oct 2020 11:33:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 66F79384402F Received: from AM6P193CA0088.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:88::29) by AM4PR08MB2675.eurprd08.prod.outlook.com (2603:10a6:205:10::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Mon, 26 Oct 2020 11:33:02 +0000 Received: from AM5EUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:88:cafe::df) by AM6P193CA0088.outlook.office365.com (2603:10a6:209:88::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18 via Frontend Transport; Mon, 26 Oct 2020 11:33:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;gcc.gnu.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT014.mail.protection.outlook.com (10.152.16.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18 via Frontend Transport; Mon, 26 Oct 2020 11:33:02 +0000 Received: ("Tessian outbound ba2270a55485:v64"); Mon, 26 Oct 2020 11:33:02 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 5ff5374727b62ec7 X-CR-MTA-TID: 64aa7808 Received: from f7b38fcacc30.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 43C6BCC0-5B49-4C12-9182-7F3B9C8DE581.1; Mon, 26 Oct 2020 11:32:46 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f7b38fcacc30.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 26 Oct 2020 11:32:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aQY7+RWBwoYWtVyXAc+rTWG6aiWphM1/bo0e1FrDFdDLFdiR8x0aBcJcKB0yAajM/PV/G1tH9bc/t/XNclxFHA/Ek26Yqg39M7seP3iDzgh1ZwCi2HZWX8k7KSVwbPRoK07DuDgj3TIgYS2sCuon6UxQVX+HljbBBXoDIfXHkCkhIli2C859VrPMilZ3aSOOaNeK+4JDCwqaAO5iHZdqhZ3wYWVV/VE3OCi531Y3nR3+TbywKKHy1+uCF4McLObBuKZBdqdAP5mjgkLHVgzesOPhLLIV3TLngLltZJ93Y0/9yDz59amn5qJzztEbM/Ut3QYhOxaQowjVRtF75d1t0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iUlGc8W9RdSTHDq4Narj0C8pViVfLovUNptVrUu1UEk=; b=Ix9ZjB0yeEoQQ6Ud0xgkk+dpOE5j2zUgYtZ8V7a2i5F1ZvYNOyMnpgKnje5TlIl1sU+mTuoeDeOhffc1DS1mmFs2WwMFl4fC5XJ4aeCsLQ8xHnOrS2yQVgNlLNgzuHtSXP1JuUR80H+os/naTfVGHDbbKYMJsq/l4RFB6Jn+NoRT6ra2IXatX1+QWWHocF2R1lPlhFREpqvWSjez6XO+8Gw2fmrbrEU4eXsRbfsoEXrBSU0wMoyijR9rswrJxmywPdBii+vfGk2o6B/1jnBEc36pdzgYQ0h5p+cyIZkvj1vGVnrCHzbrRbAAGa1b/I1JWis+RAzeAYHm61q6ZGzD8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Received: from DB7PR08MB3002.eurprd08.prod.outlook.com (2603:10a6:5:20::25) by DB7PR08MB3788.eurprd08.prod.outlook.com (2603:10a6:10:31::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Mon, 26 Oct 2020 11:32:44 +0000 Received: from DB7PR08MB3002.eurprd08.prod.outlook.com ([fe80::9ce1:1ded:d7a5:af85]) by DB7PR08MB3002.eurprd08.prod.outlook.com ([fe80::9ce1:1ded:d7a5:af85%7]) with mapi id 15.20.3477.028; Mon, 26 Oct 2020 11:32:44 +0000 From: Kyrylo Tkachov To: Jakub Jelinek CC: "gcc-patches@gcc.gnu.org" Subject: RE: [PATCH] PR tree-optimization/97546 Bail out of find_bswap_or_nop on non-INTEGER_CST sizes Thread-Topic: [PATCH] PR tree-optimization/97546 Bail out of find_bswap_or_nop on non-INTEGER_CST sizes Thread-Index: AdareTZ8jz6n9vc9RrarUtJyOoVoDgAAam6AAAQuioA= Date: Mon, 26 Oct 2020 11:32:43 +0000 Message-ID: References: <20201026093209.GG7080@tucnak> In-Reply-To: <20201026093209.GG7080@tucnak> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-ts-tracking-id: 9A5811DE6B426341AB0D096BB5D1851B.0 x-checkrecipientchecked: true Authentication-Results-Original: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [80.5.218.175] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 1479020b-42eb-40c7-0d44-08d879a2e63c x-ms-traffictypediagnostic: DB7PR08MB3788:|AM4PR08MB2675: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: IthEeXSsfJeg7jFp+ZsIr6xvM89mgMaRN6h0QatEfi5rA+7AGLWNRCQZbaFn4px6FHsOWCBU3ZHJkJWjdbl73php5b5HFDxjZFvhZmAkEHC66iSBgQz5wLJ0urOs/wmfY7W4k3UEagz+4tSySGKFwPUH9UaIP206mCLq59jaxtb43YFGc+ey7QI//5SrIgULzmcw1Oy+qPVMDSLy/1PUQB8eiIzuFuNJjlVwD2CRJjem+njTndI5ez/vb5SEQLgiI6w3OyhYuGkWhAblalJpYbx8rW55nwshR6CEx8pGb0hxVYg2q64h5YZSOb6BvzCHH8JNkkqc4yPyVTkpZRZ67Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR08MB3002.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(366004)(136003)(376002)(39860400002)(346002)(33656002)(6506007)(316002)(83380400001)(53546011)(2906002)(7696005)(186003)(71200400001)(55016002)(66616009)(8936002)(8676002)(66946007)(5660300002)(4326008)(9686003)(478600001)(64756008)(52536014)(86362001)(66476007)(6916009)(99936003)(76116006)(26005)(66556008)(66446008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: QWK9kj5N3kZ5dXBA7CCKtQVIMvt5kKhkc6w4s4BvM2OVmaSU7R378Vx/YHEmkZmAoQdc9QE+cTxMMiloo4zb7ERZwmFgXaxJU07CGq5mvDkoPC0X7kNO14PhpwheIopSKnYRuUnXxrzASIWrhaJ2fYaYi5rj+GA/uKSBBMGlvF7dWKYTSUJPLMkf/9Oj39PIFzQu+GXbIM6HjnpuEX7mYBjcbJ6fpYfI/4CC7ZtEuu8GsZ+q/mtwj/KpDIGce3balAuEy4VVP8VRhYZMftfcDcDDlKUfupyGbBTBAxUEckxkLCFfafT6wWYShdoPUdexsPqcagNcFbsPtN1VhFxtXqmtsR5bHGETE5YQCeY4iUGmvqGWARiRNWScKQ/fihe8kYWiEvo8C6yf2JGowwnKJXloow1btLpEEDbFK5sx2klSkZh9AnhjUd18HI9fVksqWhtOwJOGDkP6Y+RAmNdIaTzb7RmQekZP2FYaFg4GdI1/+tbqAGEkiEBYXhLQrL12BM/FD4a2ej56NGK80oqPAAZKbCwzYnmsPqAU2a0feIDASm1VSzvQBWYzV/SW5UVeow3ePaRphU0Q8fJDbDqqH0W5m2ja80N06R1vGD/EGWOgdoPdwlqOompCSPgp4R5Ku+AEfFfGct0RQd6JpDigFg== x-ms-exchange-transport-forked: True Content-Type: multipart/mixed; boundary="_002_DB7PR08MB3002A939F3220D601DC0879493190DB7PR08MB3002eurp_" MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3788 Original-Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 5d517f57-169b-4a70-a209-08d879a2db26 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ob+6tq6Ubuz04/Ek40Rk55FvmRMaDg8GlwNqgOpocnSfxLTd0CHzQBEzbJplmpVehtL7NpgIQPOWLPbl4EGqdoavZmpKnWWhbLySZ0IxdrGiLkBrJ2eCMOh0LRgiq8iCIqQPWV8yHq4hNzKMiKzRcsSSZtM2QAH+VSuhqKVSX+4Ro49wCav6h5umLLakcPUacp4ST7CN6DqEAXHUgLRBD2upIGb+W6CxHvhb6F+3qAqajDXvgi9L9UCBeGifREU/Bp4KxoGBlHleHDiP3bYGc5FsxDTOyZ7UBQolFHcnBX3jIewC/iwijA49DmUPiVyPLSPrFI7WMCiV2WDz23FYVY1PeNppSUDzAcsG8qQ3a7QE7m9bQXIJlL3mlneYzMlrWzClszIQjMXhprRUJUaRlA== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(376002)(136003)(346002)(39860400002)(396003)(46966005)(356005)(82740400003)(82310400003)(47076004)(7696005)(8936002)(66616009)(33656002)(70206006)(6506007)(5660300002)(235185007)(81166007)(6862004)(53546011)(478600001)(4326008)(99936003)(86362001)(336012)(83380400001)(26005)(8676002)(55016002)(70586007)(316002)(36906005)(52536014)(186003)(9686003)(2906002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2020 11:33:02.6653 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1479020b-42eb-40c7-0d44-08d879a2e63c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB2675 X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Oct 2020 11:33:08 -0000 --_002_DB7PR08MB3002A939F3220D601DC0879493190DB7PR08MB3002eurp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Jakub Jelinek > Sent: 26 October 2020 09:32 > To: Kyrylo Tkachov > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] PR tree-optimization/97546 Bail out of > find_bswap_or_nop on non-INTEGER_CST sizes >=20 > On Mon, Oct 26, 2020 at 09:20:42AM +0000, Kyrylo Tkachov via Gcc-patches > wrote: > > This patch fixes the ICE in the PR by bailing out of find_bswap_or_nop = on > poly_int sizes. > > I don't think it intends to handle them and from my reading of the code= it's > the most appropriate place to reject them > > here rather than in the callers. > > > > Bootstrapped and tested on aarch64-none-linux-gnu. > > > > Ok for trunk? > > Thanks, > > Kyrill > > > > gcc/ > > PR tree-optimization/97546 > > * gimple-ssa-store-merging.c (find_bswap_or_nop): Return NULL if > type is > > not INTEGER_CST. >=20 > I think better use tree_fits_uhwi_p instead of cst_and_fits_hwi and > instead of TREE_INT_CST_LOW use tree_to_uhwi. > TYPE_SIZE_UNIT which doesn't fit into uhwi but fits into shwi is somethin= g > that really shouldn't appear. > Otherwise LGTM. Thanks, that makes sense. Is the attached patch ok? Kyrill >=20 > > gcc/testsuite/ > > PR tree-optimization/97546 > > * gcc.target/aarch64/sve/acle/general/pr97546.c: New test. >=20 >=20 >=20 > Jakub --_002_DB7PR08MB3002A939F3220D601DC0879493190DB7PR08MB3002eurp_ Content-Type: application/octet-stream; name="sm-poly.patch" Content-Description: sm-poly.patch Content-Disposition: attachment; filename="sm-poly.patch"; size=1975; creation-date="Mon, 26 Oct 2020 11:32:00 GMT"; modification-date="Mon, 26 Oct 2020 11:13:36 GMT" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2djYy9naW1wbGUtc3NhLXN0b3JlLW1lcmdpbmcuYyBiL2djYy9naW1wbGUt c3NhLXN0b3JlLW1lcmdpbmcuYwppbmRleCAyOGZjMmUyLi5kMmEwNjlmIDEwMDY0NAotLS0gYS9n Y2MvZ2ltcGxlLXNzYS1zdG9yZS1tZXJnaW5nLmMKKysrIGIvZ2NjL2dpbXBsZS1zc2Etc3RvcmUt bWVyZ2luZy5jCkBAIC04NTEsMTIgKzg1MSwxNiBAQCBmaW5kX2Jzd2FwX29yX25vcF9maW5hbGl6 ZSAoc3RydWN0IHN5bWJvbGljX251bWJlciAqbiwgdWludDY0X3QgKmNtcHhjaGcsCiBnaW1wbGUg KgogZmluZF9ic3dhcF9vcl9ub3AgKGdpbXBsZSAqc3RtdCwgc3RydWN0IHN5bWJvbGljX251bWJl ciAqbiwgYm9vbCAqYnN3YXApCiB7CisgIHRyZWUgdHlwZV9zaXplID0gVFlQRV9TSVpFX1VOSVQg KGdpbXBsZV9leHByX3R5cGUgKHN0bXQpKTsKKyAgaWYgKCF0cmVlX2ZpdHNfdWh3aV9wICAodHlw ZV9zaXplKSkKKyAgICByZXR1cm4gTlVMTDsKKwogICAvKiBUaGUgbGFzdCBwYXJhbWV0ZXIgZGV0 ZXJtaW5lcyB0aGUgZGVwdGggc2VhcmNoIGxpbWl0LiAgSXQgdXN1YWxseQogICAgICBjb3JyZWxh dGVzIGRpcmVjdGx5IHRvIHRoZSBudW1iZXIgbiBvZiBieXRlcyB0byBiZSB0b3VjaGVkLiAgV2UK ICAgICAgaW5jcmVhc2UgdGhhdCBudW1iZXIgYnkgMiAqIChsb2cyKG4pICsgMSkgaGVyZSBpbiBv cmRlciB0byBhbHNvCiAgICAgIGNvdmVyIHNpZ25lZCAtPiB1bnNpZ25lZCBjb252ZXJzaW9ucyBv ZiB0aGUgc3JjIG9wZXJhbmQgYXMgY2FuIGJlIHNlZW4KICAgICAgaW4gbGliZ2NjLCBhbmQgZm9y IGluaXRpYWwgc2hpZnQvYW5kIG9wZXJhdGlvbiBvZiB0aGUgc3JjIG9wZXJhbmQuICAqLwotICBp bnQgbGltaXQgPSBUUkVFX0lOVF9DU1RfTE9XIChUWVBFX1NJWkVfVU5JVCAoZ2ltcGxlX2V4cHJf dHlwZSAoc3RtdCkpKTsKKyAgaW50IGxpbWl0ID0gdHJlZV90b191aHdpICh0eXBlX3NpemUpOwog ICBsaW1pdCArPSAyICogKDEgKyAoaW50KSBjZWlsX2xvZzIgKCh1bnNpZ25lZCBIT1NUX1dJREVf SU5UKSBsaW1pdCkpOwogICBnaW1wbGUgKmluc19zdG10ID0gZmluZF9ic3dhcF9vcl9ub3BfMSAo c3RtdCwgbiwgbGltaXQpOwogCmRpZmYgLS1naXQgYS9nY2MvdGVzdHN1aXRlL2djYy50YXJnZXQv YWFyY2g2NC9zdmUvYWNsZS9nZW5lcmFsL3ByOTc1NDYuYyBiL2djYy90ZXN0c3VpdGUvZ2NjLnRh cmdldC9hYXJjaDY0L3N2ZS9hY2xlL2dlbmVyYWwvcHI5NzU0Ni5jCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAuLjI1NzA3Y2QKLS0tIC9kZXYvbnVsbAorKysgYi9nY2MvdGVzdHN1 aXRlL2djYy50YXJnZXQvYWFyY2g2NC9zdmUvYWNsZS9nZW5lcmFsL3ByOTc1NDYuYwpAQCAtMCww ICsxLDIyIEBACisvKiB7IGRnLW9wdGlvbnMgIi1PMiIgfSAqLworCisjaW5jbHVkZSA8YXJtX3N2 ZS5oPgorCitzdGF0aWMgc3Zib29sX3QgdmlzaW5mX3ZvX3ZmKHN2ZmxvYXQzMl90IGQpCit7Cisg IHJldHVybiBzdmNtcGVxX25fZjMyIChzdnB0cnVlX2I4ICgpLAorICAgICAgICAgICAgICAgICAg ICAgICAgc3ZhYnNfZjMyX3ggKHN2cHRydWVfYjggKCksIGQpLAorICAgICAgICAgICAgICAgICAg ICAgICAgX19idWlsdGluX2luZmYgKCkpOworfQorCitjb25zdCBzdmludDMyX3QgX1pHVnNOeHZf aWxvZ2JmKHN2ZmxvYXQzMl90IGQpCit7CisgIHN2aW50MzJfdCBlID0gc3ZyZWludGVycHJldF9z MzJfZjMyIChzdmR1cF9uX2YzMiAoMC4wZikpOworICBlID0gc3ZzZWxfczMyIChzdmNtcG5lX2Yz MiAoc3ZwdHJ1ZV9iOCgpLCBkLCBkKSwKKyAgICAgICAgICAgICAgICAgc3ZkdXBfbl9zMzIgKDIx NDc0ODM2NDcpLAorICAgICAgICAgICAgICAgICBlKTsKKyAgZSA9IHN2c2VsX3MzMiAodmlzaW5m X3ZvX3ZmIChkKSwKKyAgICAgICAgICAgICAgICAgc3ZkdXBfbl9zMzIgKDB4N2ZmZmZmZmYpLAor ICAgICAgICAgICAgICAgICBlKTsKKyAgcmV0dXJuIGU7Cit9Cg== --_002_DB7PR08MB3002A939F3220D601DC0879493190DB7PR08MB3002eurp_--