* [PATCH][GCC][Arm]: Do not process rest of MVE header file after unsupported error
@ 2020-04-02 8:19 Andre Vieira (lists)
2020-04-02 8:25 ` Kyrylo Tkachov
0 siblings, 1 reply; 2+ messages in thread
From: Andre Vieira (lists) @ 2020-04-02 8:19 UTC (permalink / raw)
To: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 503 bytes --]
Hi,
This patch makes sure the rest of the header file is not parsed if MVE
is not supported. The user should not be including this file if MVE is
not supported, nevertheless making sure it doesn't parse the rest of the
header file will save the user from a huge error output that would be
rather useless.
Is this OK for trunk?
gcc/ChangeLog:
2020-04-02 Andre Vieira <andre.simoesdiasvieira@arm.com>
* config/arm/arm_mve.h: Condition the header file on
__ARM_FEATURE_MVE.
[-- Attachment #2: mve_unsupported.patch --]
[-- Type: text/plain, Size: 612 bytes --]
diff --git a/gcc/config/arm/arm_mve.h b/gcc/config/arm/arm_mve.h
index f1dcdc2153217e796c58526ba0e5be11be642234..1ce55bd2fc4f5c6a171ffe116d7fd9029e11a619 100644
--- a/gcc/config/arm/arm_mve.h
+++ b/gcc/config/arm/arm_mve.h
@@ -24,11 +24,9 @@
#if __ARM_BIG_ENDIAN
#error "MVE intrinsics are not supported in Big-Endian mode."
-#endif
-
-#if !__ARM_FEATURE_MVE
+#elif !__ARM_FEATURE_MVE
#error "MVE feature not supported"
-#endif
+#else
#include <stdint.h>
#ifndef __cplusplus
@@ -27554,4 +27552,5 @@ extern void *__ARM_undef;
}
#endif
+#endif /* __ARM_FEATURE_MVE */
#endif /* _GCC_ARM_MVE_H. */
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [PATCH][GCC][Arm]: Do not process rest of MVE header file after unsupported error
2020-04-02 8:19 [PATCH][GCC][Arm]: Do not process rest of MVE header file after unsupported error Andre Vieira (lists)
@ 2020-04-02 8:25 ` Kyrylo Tkachov
0 siblings, 0 replies; 2+ messages in thread
From: Kyrylo Tkachov @ 2020-04-02 8:25 UTC (permalink / raw)
To: Andre Simoes Dias Vieira, gcc-patches
> -----Original Message-----
> From: Andre Vieira (lists) <andre.simoesdiasvieira@arm.com>
> Sent: 02 April 2020 09:20
> To: gcc-patches@gcc.gnu.org
> Cc: Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>
> Subject: [PATCH][GCC][Arm]: Do not process rest of MVE header file after
> unsupported error
>
> Hi,
>
> This patch makes sure the rest of the header file is not parsed if MVE is not
> supported. The user should not be including this file if MVE is not supported,
> nevertheless making sure it doesn't parse the rest of the header file will save
> the user from a huge error output that would be rather useless.
>
> Is this OK for trunk?
Ok.
Thanks,
Kyrill
>
> gcc/ChangeLog:
> 2020-04-02 Andre Vieira <andre.simoesdiasvieira@arm.com>
>
> * config/arm/arm_mve.h: Condition the header file on
> __ARM_FEATURE_MVE.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-02 8:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-02 8:19 [PATCH][GCC][Arm]: Do not process rest of MVE header file after unsupported error Andre Vieira (lists)
2020-04-02 8:25 ` Kyrylo Tkachov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).