From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2043.outbound.protection.outlook.com [40.107.6.43]) by sourceware.org (Postfix) with ESMTPS id 80D9F3854570 for ; Fri, 25 Nov 2022 13:30:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 80D9F3854570 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+RFX+HMc9AbrxPDw1o/aro4JvcoDZpbiAowwf6Eraes=; b=RrtEFqZisvc9nifr6V38Rxk3y10q0duUJ5whiFxGOBTIK2x3PhWPSIpo73h58Biz/fOvoCPQ2beKRM9ajdm69PDDYWZRUNfcG5XRcqpa5aEV547grdkMz6XA7wdfEZYMau16Gc8zmT4V0IEcyfUiCy4PG6PTwUe2tVoUhOa4afo= Received: from FR2P281CA0128.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::9) by PAVPR08MB10329.eurprd08.prod.outlook.com (2603:10a6:102:32c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19; Fri, 25 Nov 2022 13:30:47 +0000 Received: from VI1EUR03FT010.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:9e:cafe::2e) by FR2P281CA0128.outlook.office365.com (2603:10a6:d10:9e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.20 via Frontend Transport; Fri, 25 Nov 2022 13:30:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT010.mail.protection.outlook.com (100.127.144.228) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Fri, 25 Nov 2022 13:30:46 +0000 Received: ("Tessian outbound 2ff13c8f2c05:v130"); Fri, 25 Nov 2022 13:30:46 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: d9e04d37b117902e X-CR-MTA-TID: 64aa7808 Received: from 1559b4ae2637.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A814273B-0505-463D-8B5C-E7F106090C77.1; Fri, 25 Nov 2022 13:30:35 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1559b4ae2637.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 25 Nov 2022 13:30:35 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZfzmA65OFOhESkTOyRyVAuVqoSyyYUss/IuSHebqb9/H0NKtssNiXqoARoNFsDT3fMepYQyrYHpYzQTOYGcK7biwcopOBuuFeGLDLFA821nBWcK9AWE7YpAjv1ikCzKq9Ziyaxfgtv/PByA+Q8NMmD9ZUO5zg/YyMo09c+HGwzGODyMg8qwhypbVS/0wbZjTtrcdSda5cEBB3jsdw3oGSn9xUyHUMT3yg6Yi4+J/bfjlNOaDQOrmTwjJ2EKvGH9PmndLinGo6VaVq8IX2N/1trYZzFkODPbm7+Z5LCOrlfoyuUwExAZEp59VEeHWJvQz4lWA11sZdlCg0SF2txpoGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+RFX+HMc9AbrxPDw1o/aro4JvcoDZpbiAowwf6Eraes=; b=el2SqFfCnVLicc4TsNq6DT5nIERMm0PHC+OSbtGTOEu7hvs9R2zKZtXPAFejTrcJqcz8RT5Q0reECfTjRCsBQ7isUXeFtPbuPuvw20EDW7pLmbeiyQ3lDIBeCR9ai7sOceg/iToNd9kf4xiS+qQTdDHi8XmOKL9xD/gVOxi+WbmeHJIJDuHUL75tAS7bCR5DUwYqy5phsUh24bZDOgqnH6u/D01JVOp2mryRGIgo51/XkG3Q8PzG9iV3TbZTEeOuE06PdB6QmkxpghQ3kWgecmEbGvHSsIDrdpfbY8PeXjREZgTNugaUNPs3y9m4afjW8kVn2BMWDJaiEPyIhSBW5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+RFX+HMc9AbrxPDw1o/aro4JvcoDZpbiAowwf6Eraes=; b=RrtEFqZisvc9nifr6V38Rxk3y10q0duUJ5whiFxGOBTIK2x3PhWPSIpo73h58Biz/fOvoCPQ2beKRM9ajdm69PDDYWZRUNfcG5XRcqpa5aEV547grdkMz6XA7wdfEZYMau16Gc8zmT4V0IEcyfUiCy4PG6PTwUe2tVoUhOa4afo= Received: from DB9PR08MB6474.eurprd08.prod.outlook.com (2603:10a6:10:255::17) by PAWPR08MB9639.eurprd08.prod.outlook.com (2603:10a6:102:2ec::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.5; Fri, 25 Nov 2022 13:30:28 +0000 Received: from DB9PR08MB6474.eurprd08.prod.outlook.com ([fe80::4410:cc67:3c0d:de90]) by DB9PR08MB6474.eurprd08.prod.outlook.com ([fe80::4410:cc67:3c0d:de90%5]) with mapi id 15.20.5880.005; Fri, 25 Nov 2022 13:30:27 +0000 From: Vaseeharan Vinayagamoorthy To: "gcc-patches@gcc.gnu.org" , Richard Biener Subject: Re: [PATCH] tree-optimization/107672 - avoid vector mode type_for_mode call Thread-Topic: [PATCH] tree-optimization/107672 - avoid vector mode type_for_mode call Thread-Index: AQHY/k9LGjLhQZAFrUqD1i3tU/HqJK5Pp0Bi Date: Fri, 25 Nov 2022 13:30:27 +0000 Message-ID: References: <20221122084850.B6CA313B01@imap2.suse-dmz.suse.de> In-Reply-To: <20221122084850.B6CA313B01@imap2.suse-dmz.suse.de> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: DB9PR08MB6474:EE_|PAWPR08MB9639:EE_|VI1EUR03FT010:EE_|PAVPR08MB10329:EE_ X-MS-Office365-Filtering-Correlation-Id: 7583f598-2986-4a0f-65c1-08dacee942d3 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: tJxSwqdIWPwPjHj2jYILD9sQkA28tuFeUoKSDIKRGBuDMT2jn28Vkk2zAhTvIjxlWa3tEanFxr2XO3zVlwwT9Y7EmxHi2lPjg6n9DI9xx85st7Ce+L4cUesVatqX8tkS3EsNv00iPR2nersTQ8ru8qrJRbmfRdm0+a0ujzd3/KBg3ndj4202w1DFgEMIO/k2fDyHm+dA/QGUYxKdXafmMCg78olSQqz/fCRPocfsrznThyPNGNIKKi4cX8l7BAcOpGpGJtKooj7TGTeR4aXbVv0VSCom7bfdAXn+4WEj1k7Y4iP/v5PEVvrS/TVB2rSvzc0X06yE8wrvswisMfaQ82qAvh5V5Qk87hPU6bex80OumXSY1Gct9RU7U+gA+OZOUes19sXjVx1UMIkNIvxVEQb8j5nqCZblnscN/kpNevtJPG5ed5RKwKA5TP42LsYBRnB6h+dE9MBG+hG5ap57vnPWmA9TZV/xqRhpK4raYMZlvHzSoJi2XIWroFo7ULsp7g4imXx4+E83MmirJvri7Qn/tmpeBvYI6dt193ozC7Qc26KfLGMeR10dJW/q27GQn8SWtSuGhMms3M6flcKAeZrhanMOLYbqx0U9pvS8t56ISulXkGYrscwlScNWx6g/hQtoa+l9NvIBaCcXTG5xaGpfoxVHp3B8O/H7viRE91nqbNo8k11OtIt8u3POu5mwJ+clg05HIzw05bhihd4J7DctMxkrp7MjYve3wJFheDU= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB6474.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(396003)(376002)(346002)(39860400002)(136003)(451199015)(83380400001)(38100700002)(19627405001)(86362001)(71200400001)(26005)(7696005)(6506007)(110136005)(38070700005)(55016003)(33656002)(122000001)(9686003)(186003)(5660300002)(52536014)(478600001)(53546011)(8936002)(91956017)(66446008)(66476007)(8676002)(66556008)(66946007)(64756008)(316002)(76116006)(2906002)(41300700001);DIR:OUT;SFP:1101; Content-Type: multipart/alternative; boundary="_000_DB9PR08MB6474CBE326ADC026B9285947810E9DB9PR08MB6474eurp_" MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9639 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d7a0529f-6007-458c-3af2-08dacee9374c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rgSjYI211ua5Y9M+5414Mk6/XCu9KTD2EKZy9LNXxLNlKIVYbvU6sajrXXw+rEYNkoxnHeQwjQ2Z25zr/E3xx0QpD1Ns2H8uKyLC8/dPRoCNf2P78NL2LYhsKXocYUcK860XmG/DAAmMH2mWY643dpHjfTg6BUpg7lDab2ognlLLF+wDUCsbphC2CGJjXSktVTavW9man/U0NU3SPNwfOXIOpqCLPTbmUDeES0EpesndEekftgGofRlhf6w9MNtGSCPUyy9rulAc5n2xuGVfSw+H+VMVcLhFOR9qLgDzrttpDWErJPHUWPeeA48Hn0Zu2DZ1nrgdlt0G2QefYvQKufAbk8fsLvrfExE1Ji7zT/zkl8shqJHirURIXS2c2YbwR3SSb87viEqHw6gIXmECTDUxFV2A7/FlRb5KmVOoFcC5F3PYU9yn4v7goE9jFg9CavCf9WfUcMYoEuVeORaZrNgx2yXjbrzaJN2m+mUz6f1R4Tsmfqtgf7K4m+Uzz0qcgj68IblOeT2oWpAn0xN1T/zQuazUy7kTo4RFMDPcE3n8sfnl1/fsfbsMdVHfwgh7ZbPO2dedqDW+WTF/gAEPKIpt4lxg9ZbvZebadjo2FXGKpDpSo+8bg6NHFRlF7ia23UbNhuCfHbC4/1ill/iYmMCVHfGWm/BW7m+nO/pRY8Le8qRQGMkjyJO8hxoxHu4fmAHA9I9POndXA0wf/bSC29MEs6qxS4XQpwHWb08EhHY= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(346002)(136003)(376002)(451199015)(36840700001)(40470700004)(46966006)(19627405001)(2906002)(36860700001)(83380400001)(81166007)(33656002)(40480700001)(186003)(40460700003)(55016003)(41300700001)(70206006)(70586007)(86362001)(356005)(82740400003)(7696005)(110136005)(6506007)(82310400005)(53546011)(8676002)(5660300002)(336012)(47076005)(52536014)(8936002)(26005)(9686003)(478600001)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2022 13:30:46.8792 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7583f598-2986-4a0f-65c1-08dacee942d3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB10329 X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,HTML_MESSAGE,KAM_DMARC_NONE,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY,WEIRD_PORT autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --_000_DB9PR08MB6474CBE326ADC026B9285947810E9DB9PR08MB6474eurp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Hi, I am seeing an internal compiler error, related to this patch: during GIMPLE pass: slp options-save.cc: In function 'void cl_optimization_restore(gcc_options*, gc= c_options*, cl_optimization*)': options-save.cc:1292:1: internal compiler error: in supportable_widening_op= eration, at tree-vect-stmts.cc:12199 1292 | cl_optimization_restore (struct gcc_options *opts, struct gcc_optio= ns *opts_set, | ^~~~~~~~~~~~~~~~~~~~~~~ /=85/src/gcc/gcc/profile-count.cc: In member function 'int profile_count::t= o_cgraph_frequency(profile_count) const': /=85/src/gcc/gcc/profile-count.cc:308:1: note: parameter passing for argume= nt of type 'profile_count' changed in GCC 9.1 308 | profile_count::to_cgraph_frequency (profile_count entry_bb_count) co= nst | ^~~~~~~~~~~~~ /=85/src/gcc/gcc/profile-count.cc: In member function 'sreal profile_count:= :to_sreal_scale(profile_count, bool*) const': /=85/src/gcc/gcc/profile-count.cc:326:1: note: parameter passing for argume= nt of type 'profile_count' changed in GCC 9.1 326 | profile_count::to_sreal_scale (profile_count in, bool *known) const | ^~~~~~~~~~~~~ 0x2195bdd supportable_widening_operation(vec_info*, tree_code, _stmt_vec_in= fo*, tree_node*, tree_node*, tree_code*, tree_code*, int*, vec*) /=85/src/gcc/gcc/tree-vect-stmts.cc:12199 0x2180493 vectorizable_conversion /=85/src/gcc/gcc/tree-vect-stmts.cc:5064 0x2192fdd vect_analyze_stmt(vec_info*, _stmt_vec_info*, bool*, _slp_tree*, = _slp_instance*, vec*) /=85/src/gcc/gcc/tree-vect-stmts.cc:11256 /=85/src/gcc/gcc/profile-count.cc: In member function 'profile_count profil= e_count::combine_with_ipa_count(profile_count)': /=85/src/gcc/gcc/profile-count.cc:398:1: note: parameter passing for argume= nt of type 'profile_count' changed in GCC 9.1 398 | profile_count::combine_with_ipa_count (profile_count ipa) | ^~~~~~~~~~~~~ 0x14f95d1 vect_slp_analyze_node_operations_1 /=85/src/gcc/gcc/tree-vect-slp.cc:5958 0x14f9c19 vect_slp_analyze_node_operations /=85/src/gcc/gcc/tree-vect-slp.cc:6147 0x14f9b4d vect_slp_analyze_node_operations /=85/src/gcc/gcc/tree-vect-slp.cc:6126 0x14fa439 vect_slp_analyze_operations(vec_info*) /=85/src/gcc/gcc/tree-vect-slp.cc:6387 0x14fd423 vect_slp_analyze_bb_1 /=85/src/gcc/gcc/tree-vect-slp.cc:7372 0x14fd599 vect_slp_region /=85/src/gcc/gcc/tree-vect-slp.cc:7419 0x14fe0d1 vect_slp_bbs /=85/src/gcc/gcc/tree-vect-slp.cc:7610 0x14fe46f vect_slp_function(function*) /=85/src/gcc/gcc/tree-vect-slp.cc:7698 0x151a109 execute /=85/src/gcc/gcc/tree-vectorizer.cc:1532 Please submit a full bug report, with preprocessed source (by using -frepor= t-bug). Please include the complete backtrace with any bug report. See for instructions. Makefile:1146: recipe for target 'options-save.o' failed make[3]: *** [options-save.o] Error 1 That happens when building the arm-none-linux-gnueabihf toolchain natively = with glibc bootstrap: Build:arm-none-linux-gnueabihf Host:arm-none-linux-gnueabihf Target: arm-none-linux-gnueabihf The compiler being used to build the toolchain is gcc 7.5.0. Kind regards Vasee ________________________________ From: Gcc-patches on b= ehalf of Richard Biener via Gcc-patches Sent: 22 November 2022 08:48 To: gcc-patches@gcc.gnu.org Subject: [PATCH] tree-optimization/107672 - avoid vector mode type_for_mode= call The following avoids using type_for_mode on vector modes which might not work for all frontends. Instead we look for the inner mode type and use build_vector_type_for_mode instead. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR tree-optimization/107672 * tree-vect-stmts.cc (supportable_widening_operation): Avoid type_for_mode on vector modes. --- gcc/tree-vect-stmts.cc | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/gcc/tree-vect-stmts.cc b/gcc/tree-vect-stmts.cc index bc0ef136f19..b35b986889d 100644 --- a/gcc/tree-vect-stmts.cc +++ b/gcc/tree-vect-stmts.cc @@ -12195,9 +12195,15 @@ supportable_widening_operation (vec_info *vinfo, intermediate_type =3D vect_halve_mask_nunits (prev_type, intermediate_mode); else - intermediate_type - =3D lang_hooks.types.type_for_mode (intermediate_mode, - TYPE_UNSIGNED (prev_type)); + { + gcc_assert (VECTOR_MODE_P (intermediate_mode)); + tree intermediate_element_type + =3D lang_hooks.types.type_for_mode (GET_MODE_INNER (intermediat= e_mode), + TYPE_UNSIGNED (prev_type)); + intermediate_type + =3D build_vector_type_for_mode (intermediate_element_type, + intermediate_mode); + } if (VECTOR_BOOLEAN_TYPE_P (intermediate_type) && VECTOR_BOOLEAN_TYPE_P (prev_type) -- 2.35.3 --_000_DB9PR08MB6474CBE326ADC026B9285947810E9DB9PR08MB6474eurp_--