public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Saurabh Jha <Saurabh.Jha@arm.com>
To: Richard Sandiford via Gcc-patches <gcc-patches@gcc.gnu.org>,
	Richard Sandiford <Richard.Sandiford@arm.com>,
	Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>,
	Richard Earnshaw <Richard.Earnshaw@arm.com>
Subject: [PATCH] testsuite, arm: Fix testcase arm/pr112337.c to check for the options first
Date: Tue, 30 Jan 2024 17:07:12 +0000	[thread overview]
Message-ID: <DBBPR08MB60918AE230D10DD319EBB686F87D2@DBBPR08MB6091.eurprd08.prod.outlook.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 757 bytes --]

Hey,

Previously, this test was added to fix this bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112337. However, it did not check the compilation options before using them, leading to errors.

This patch fixes the test by first checking whether it can use the options before using them.

Tested for arm-none-eabi and found no regressions. The output of check-gcc with RUNTESTFLAGS="arm.exp=*" changed like this:

Before:
# of expected passes          5963
# of unexpected failures      64

After:
# of expected passes          5964
# of unexpected failures      63

Ok for master?

Regards,
Saurabh

gcc/testsuite/ChangeLog:

        * gcc.target/arm/pr112337.c: Check whether we can use the compilation options before using them.

[-- Attachment #2: rb18229.patch --]
[-- Type: application/octet-stream, Size: 978 bytes --]

From b65084c05c165af6fce22e5de19eb508d9ce0ff3 Mon Sep 17 00:00:00 2001
From: Saurabh Jha <saujha01@e130340.arm.com>
Date: Tue, 30 Jan 2024 15:03:36 +0000
Subject: [PATCH] Fix testcase pr112337.c to check the options first

---
 gcc/testsuite/gcc.target/arm/pr112337.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gcc/testsuite/gcc.target/arm/pr112337.c b/gcc/testsuite/gcc.target/arm/pr112337.c
index 5dacf0aa4f8..b664229b210 100644
--- a/gcc/testsuite/gcc.target/arm/pr112337.c
+++ b/gcc/testsuite/gcc.target/arm/pr112337.c
@@ -1,5 +1,8 @@
 /* { dg-do compile } */
-/* { dg-options "-O2 -march=armv8.1-m.main+fp.dp+mve.fp -mfloat-abi=hard" } */
+/* { dg-require-effective-target arm_hard_ok } */
+/* { dg-require-effective-target arm_v8_1m_mve_ok } */
+/* { dg-options "-O2 -mfloat-abi=hard" } */
+/* { dg-add-options arm_v8_1m_mve } */
 
 #pragma GCC arm "arm_mve_types.h"
 int32x4_t h(void *p) { return __builtin_mve_vldrwq_sv4si(p); }
-- 
2.43.0


             reply	other threads:[~2024-01-30 17:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-30 17:07 Saurabh Jha [this message]
2024-02-09 11:35 ` Saurabh Jha
2024-02-09 14:57 ` Richard Earnshaw (lists)
2024-02-19 10:11   ` [PATCH v2] " Saurabh Jha
2024-03-05  9:56     ` Saurabh Jha
2024-03-05 15:31     ` Richard Earnshaw (lists)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DBBPR08MB60918AE230D10DD319EBB686F87D2@DBBPR08MB6091.eurprd08.prod.outlook.com \
    --to=saurabh.jha@arm.com \
    --cc=Kyrylo.Tkachov@arm.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=Richard.Sandiford@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).