From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2108.outbound.protection.outlook.com [40.107.22.108]) by sourceware.org (Postfix) with ESMTPS id 627093858CD1 for ; Wed, 22 May 2024 14:32:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 627093858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=microsoft.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=microsoft.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 627093858CD1 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.22.108 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1716388349; cv=pass; b=JzMOagT9nMm8gnR//M9Fljx0P0dH8k7WBb8C/VzmN8/vyZHz6Jsa8H2lNKQGPJSEcXpzSSwkZcT6l1Omd1q4oRj0GGw3G3S2W5yAGGbL3rchso6KRk6RFlWfjhfZiZxaBTVwI19KPWJMHbX6VOvDE3j31+btGsXD1KHdBWWiMO4= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1716388349; c=relaxed/simple; bh=rPOnAGA1h14qg/IGHrykOZOPxtsLIM9OfwJckCcuYNQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Q9IaHwHYH8AJzqzX4g9HPzL6ufhHIAGXbcbPL9dXnw5MUVzV1urkNQyWyjObOC4d3lkgWz+aBmQ6E1yQKcI/aFC51RnN0+XM1wk0DDsLlenQ+FfurffkKaIHWJ0uU8osJgYupQhHXMuhDxi/12VDgq9q1RhciONi2epnBXMzFkM= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CBaX9mPDYtaBbU39mTwviNLfANONrIZqO7GX0ZYvPWhGUBMH741O982fNHoK+sVqm8D+JYu4NysSjzYREyK59MDw61LUr6qjPt3A1nF3CW45AhmARvVv3oENXPPqpcWk8m7fdKIwftNubB5jaaiPC0oXhFjyF8z4Et343gKqbeHYkHAJaKRJe0pxwbzbUCJyb61RGfU2rpuKxn5gOcDEjsGQOhrxEIv5+PSTEIuPxvaAJdq3+5CtqkwQBDEcOmqPuqZFrTcy9JepIQSqpNPnN0cMsJ8W+jLKgGyvQwnzlKTAcQ2M0Eu9XcFwmFokXZQKE6g0R5FstxxJvmhJsMz6tQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nfx+2vs3iwkjAMuwp5ZTKNFh0eLTHU27N2i1diB2QJc=; b=kywKL3Ezti4pj9tP32pkhCY/ruBWayFj0wmb1+Db/x4yatC2dygzMJNt2goMEIAoMkI2P9jrn4rnCO5vk4D6dOdQ0sVo/4cZfN104iDUCZLPi9rWBxtGUjBY+gTD25jD2sdRr9Fyj7xB8WjUsNMcT8bVdXdSQIJn6Ka9+j5eKfTBEcB7YbL69xbQfrSAIM1EByrtHtOWK0KP5bC/SyE8hU0LotsT0LlXkIOWZWJfCqO0oGwgMy0BeaD+FhWWCzYtJWT6AhXVQClDOWbkUDS7VA2Ul+o4vypl5DULo6HDlFqLNoQYDHKGOAOHhyBdqxQci4pn+w9GoQkMbNirH26kLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nfx+2vs3iwkjAMuwp5ZTKNFh0eLTHU27N2i1diB2QJc=; b=OvdE5zNqrrmoWHtUQYtqQ7WdO+s9wnkaPmZq9eOzy/Yw88Fel3eWCbo7w3Afis6jKOuEdP/f7elFvi3ZE7HU4zdjjEcm3xAtf7sJX8ROd0K/+5O3mytcfKCjqiSok3Z/6eydqah9mtHTjnBdw00VkgZCjeTd9r1FaEh9rSj+yp0= Received: from DBBPR83MB0613.EURPRD83.prod.outlook.com (2603:10a6:10:533::21) by DBBPR83MB0634.EURPRD83.prod.outlook.com (2603:10a6:10:533::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.9; Wed, 22 May 2024 14:32:24 +0000 Received: from DBBPR83MB0613.EURPRD83.prod.outlook.com ([fe80::399d:9bfc:1209:af10]) by DBBPR83MB0613.EURPRD83.prod.outlook.com ([fe80::399d:9bfc:1209:af10%7]) with mapi id 15.20.7633.001; Wed, 22 May 2024 14:32:24 +0000 From: Evgeny Karpov To: "hubicka@ucw.cz" , Richard Sandiford , "ubizjak@gmail.com" CC: "gcc-patches@gcc.gnu.org" , "Richard Earnshaw (lists)" , Maxim Kuvyrkov , Radek Barton Subject: Re: [PATCH v1 2/6] Extract ix86 dllimport implementation to mingw Thread-Topic: [PATCH v1 2/6] Extract ix86 dllimport implementation to mingw Thread-Index: AQHarFTdu/wOpacS9E2hEAtVy915+A== Date: Wed, 22 May 2024 14:32:24 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=85fe51ec-6b75-4610-a995-420c07e56c67;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2024-05-22T14:25:05Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DBBPR83MB0613:EE_|DBBPR83MB0634:EE_ x-ms-office365-filtering-correlation-id: b1540fe4-7a12-4d94-d6fd-08dc7a6bff8b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230031|376005|1800799015|366007|38070700009; x-microsoft-antispam-message-info: =?us-ascii?Q?aQhTY0bnqNVR0m24MkV8XpZHx4Gj8WLqWiAGS7lOQjbv7iM+8k5jDn8evGO1?= =?us-ascii?Q?AG7TDAGm1VKXECrxPj0FGoRxBO+PINYypscXz53sNCDL+hqfeTAxAUD5f1Sw?= =?us-ascii?Q?YPorG0vqWV8Mv94EZ6cYp3J/VO9ekDBltC1TGHAzTDDCRF2EpAeAERC+pn1c?= =?us-ascii?Q?JxK5EwEyO8jH/5XtYOMrAUpjMgUqThrylGC8k/VDZRH/nkYIu+rGcwyzG3V4?= =?us-ascii?Q?NOlVTECPzUY2VR9uQaI3BlXSxGHFsr0MzaDfk97Uyx2YESpZCOwz4p8SAWc1?= =?us-ascii?Q?03b0z38t+CoaPl3SpswfrqGHVFtTBsz1EBX58lUGKUzo6z9wnLKre1NZK6gX?= =?us-ascii?Q?PfcUvE0ZDMmkgIhuUen8FZtwh/APwSMVNIBrixSGulBAjc47Ex3RVoDsxuq2?= =?us-ascii?Q?jXNBjYBj809n+hdDpvzn6fCG+VJpzwvpGbo/2jbdMdVfHTBVivujMU56hfDa?= =?us-ascii?Q?gDP8a3e3oAl4Un8L3YseFzhn3X/JseEfw4d1EIyi9Et3a/liz7SECTJBTG8r?= =?us-ascii?Q?GY1tu5HvBb00trS00iWQeTmlja4lYEdWA2qHt+mS7wMac8vQknj9NEgQ6nHb?= =?us-ascii?Q?Laap3wKNLisZjBR9zscXiRWF6GjqkTsS//0TAiBfrPq6tlPfJZhyoQewxufX?= =?us-ascii?Q?6NLMN8f06spVBIlh38owNseFvV1Uoo9GeoTumbbKppdnabWdENps/TuP8P1z?= =?us-ascii?Q?cYwYErZxQfHgmyZh5UHXxdEEW3IYuYFS4mmLx67skukimsIQ51pn5UeyenTZ?= =?us-ascii?Q?KO+F3fBxtf5fk6ofLq2YaQtfu+LVlkaCt9m8o7MmM+E0Q+w7povxyUSkZmzI?= =?us-ascii?Q?q5JdBKEw2byFOTtI9fd7N4WGOMZWo0t+T7uXEsRemtuG2ZBOiGzwIHKQ6NhB?= =?us-ascii?Q?vSHmDlHMJKNvLL7njtnllWZgIZsCeAiUJglT60L19rcYGIUWC6RgEy4kFDtv?= =?us-ascii?Q?GI93MKedtZEh4xIrfWEWW4rcuiBwAI39mg4ghuVPNPFcyv6tfBiWTzr6Krno?= =?us-ascii?Q?l8SFzMeNtQdiAs/sJhdTcej07YgvJYGPwg7rAZlWK26pbrMge9Qhf+3lIIsB?= =?us-ascii?Q?44lEvRcSSL6o9S7TMf2uDvi2qa4oCXivnIClmAsngdTADy2JQyx2hLn2NQ9V?= =?us-ascii?Q?I0HpJbY9Wk5vmghLYiThDCVvR99hZLwA51U/ZM07HLpeO0/gGTyQIAn7TaH+?= =?us-ascii?Q?RgxZr1ReHeFALI42t4PjRypdHKb0oxH7tJhyBJwXJFZhwX4NYAtNL0hhh0kt?= =?us-ascii?Q?zZs2tKH2ZpuC8qrjmXjGgAZMaUDi3aZtMn41dctRJGsmi8fQxfqrjLtkKCL/?= =?us-ascii?Q?D3V6aTshV1T/tDz6F4dysRAdnBsW0iW+0uFuaMGN/27xWw=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DBBPR83MB0613.EURPRD83.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(1800799015)(366007)(38070700009);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jdwATgYEHChYnb1h5p2fNhGg+eTqQzsScK05S1EjE5DowgGPx0KZNYJ8ZfAq?= =?us-ascii?Q?LWcJQu0569AE3Hzo6OjrIWPftxGEgVb8WduI6QaGz4bptVy6Avjtbskomnc7?= =?us-ascii?Q?Bu/OFQ2XDXqaAxiMIjYp0P9+399DLa0Y3J2Rc3sl/ms3oFTHPCzTdyPX9QDW?= =?us-ascii?Q?4fdFChIH4LgU+msg61lIibe8nVknDpIsAIH+9qtQV9Rqm2tjnbhH1SIGK58K?= =?us-ascii?Q?7xQHM0J4ot8gBDayt6VEMRbVIsdfoWVCh+rMwFyj8+PWf58u4LNuE2HuA+92?= =?us-ascii?Q?GRxAlf1/QEedFAOl2C3o/HJRGagf/js5jOerAI40fWURibbk816S8aFNuBk9?= =?us-ascii?Q?Wts/16jBA+ZnevQCbn688S30vopq2dBZRnUfBS3KmIATZdI5kD1RsP2vgGI5?= =?us-ascii?Q?VgJhNreLljGOxOsg0Te8Q4C4vl2K5rDUAB3hWydnhXcUWI8c8Djiru2Y7SSn?= =?us-ascii?Q?BAVWfbHLnlZaCHBNcfYhxwH4utJXUsSlhc3FG6as4MfFbZdtlW+/mFSqTS7u?= =?us-ascii?Q?2zL0TTDg7I47azSEDYEBzO+cfQgtXxQdlo4EzmcXnWgatKKCXZRJ5EM/rEtY?= =?us-ascii?Q?XFYmoFjrIVgQZgPt9PsKoferZxnDmXQKTbAGuc9mftCUFkvUJTAn4FQT3tIq?= =?us-ascii?Q?qU6oqqh5/kUHYI98tn9fIImHTUqmwJG6YZzRHjbmUES5ZpMvWPtDl1vhVsCG?= =?us-ascii?Q?EcEAumGRvWej/njnBSUEEB5AQn54JVlee1oDgq3MWWRfJU/wM0EKMHeOaQMz?= =?us-ascii?Q?F/erN+mfw+PU116T66UwxufPlUd36xXFd1SL1qjsht9GdENnRR7fG9/43p27?= =?us-ascii?Q?kpctM0S++yfA5kLqUFZxgQ9p9GfAyhgSlobwu0Z5yqZqz0EYdtITa8wGFZvw?= =?us-ascii?Q?tZzKqoIXFUDSJ+IqWasmt2mmPihWZ9AtY16J/Vkl4OYIO8vgXmLz+DY1hO/P?= =?us-ascii?Q?rF4YqMdp2svMrhUL69SIU8OxM/xZU+2ygblYx4kbjhxHHwep9b7D/Je74UwF?= =?us-ascii?Q?GMz8jjXwOO+jrbDdPCEgFF47/1mGlvj44QJ+8T5pqmpgQCk93Iewj9TZswTE?= =?us-ascii?Q?oHNWDskvf/7bOknnJC6Xxw9HEJ/gvvuG9+DSSIRdIL2DbjOSvHz1/z1904EB?= =?us-ascii?Q?AbXZFyAbqJaNeWKCJpVG7NA3IcfRkd+OBFEPllFyo+I3DdUUnz1DbLjLiv6k?= =?us-ascii?Q?LpOorFlQIRDl2kZYBolo889Nek2J1Y41GrcN6sWOCZFoDVdPpBUqVyPxh7cA?= =?us-ascii?Q?vaSgFLIbClkcRQp2FVBYOyn7IQrxB/1BsqwTuXMtfi6REqdX2pSc62ooM8UK?= =?us-ascii?Q?I+SQIYbKxd5wjWwceOfaowIb/S6bZBm7HVkF+8xl3w4UH7m2RyhkACSBpprc?= =?us-ascii?Q?wtSN630taOzljLKrjKNxTRT6JO/oqRB/MP1sIZpzRsW7ISyth1ynaeXxnTkG?= =?us-ascii?Q?6FWrj4sgK7+TVJaUmcfgOUvYPqFuiZjsvHLUiKkEMg5R9q+lrLX2EfORPFlD?= =?us-ascii?Q?brlmO9OuhnSoyYO5VTj7Y/Ri0ClGrat9p1hBNOB4YMi7+EpGLvhbsCW7J4al?= =?us-ascii?Q?6PTIJfhitCCQUyksAt54wDuI9aVzK/U4GFBu9eukxg7+xeL15YYxFo1Rn2yu?= =?us-ascii?Q?NhcjsOBYxXzIiUXkxtJs71lQVr3S/fUjAYIqSjgwk/EJ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DBBPR83MB0613.EURPRD83.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1540fe4-7a12-4d94-d6fd-08dc7a6bff8b X-MS-Exchange-CrossTenant-originalarrivaltime: 22 May 2024 14:32:24.6689 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yvVFsMlcO5Mpr+9/J4kJJUm4rq5WUYnvg/PlPGAWh5FY9praJP6eAONlb24gmMNpJGu+c5P7t8AS/saPJMKaBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR83MB0634 X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Wednesday, May 22, 2024 1:06 PM Richard Sandiford wrote: > This looks good to me apart from a couple of very minor comments below, b= ut > please get approval from the x86 maintainers as well. In particular, the= y might > prefer to handle ix86_legitimize_pe_coff_symbol in some other way. Thanks, Richard, for the review! The suggestions will be addressed in the next version. Jan and Uros, could you please review x86 refactoring for mingw part? Thank= s. Regards, Evgeny